My app keeps crashing and this is the stack strace:

ODServiceInfoProvider getServiceInfoWithViewController:appConfiguration:completion:], /XcodeProjects/Project/Pods/OneDriveSDK/OneDriveSDK/Accounts/ODServiceInfoProvider.m:45 2015-09-27 23:44:19.584 PhotoCal[8800:2364421] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: viewController'

Can somebody tell me what is going wrong?

Hi.

I have initialized the ODClient with the parameter capability:"Directory". When I try to get the child items of the root element SDK shows me the next error: OneDrive SDK ERROR : Error from data task : Error Domain=com.microsoft.onedrive.errors Code=400 "bad request" UserInfo={error= malformed : (null), NSLocalizedDescription=bad request} 2016-05-11 20:16:41.435 App-iOS2[1279:242395] OneDrive SDK ERROR : Caused by request <NSMutableURLRequest: 0x124fdddc0> { URL: https://graph.windows.net/company.onmicrosoft.com/drive/items/root/children } I am wondering what is incorrect in the request. Could someone help me to sort this out?

We're using the ios sdk to upload files. It works fine for a new file. but if we try to upload the same file again, the sdk will return a 409 error as follows: Error Domain=com.microsoft.onedrive.errors Code=409 "conflict" UserInfo={error= nameAlreadyExists : An item with the same name already exists under the parent, NSLocalizedDescription=conflict}

Here is the request we are using to upload the file to our app folder :

[[[[[[self.client drive] special:@"approot"] itemByPath:name] contentRequest] nameConflict:[ODNameConflict replace] ] uploadFromFile: [NSURL fileURLWithPath:path] completion:^(ODItem *response, NSError *error) { if (error == nil) { } else { NSLog(@"one drive upload:%@", error); } } ];

I created a temp file (creates file of size 107Mb): mkfile -n 107m 1.rar

I try to upload it and it works but in the completion block I always get a random error. Examples of errors: ...2.rar, error: Error Domain=NSCocoaErrorDomain Code=3840 "JSON text did not start with array or object and option to allow fragments not set." UserInfo={NSDebugDescription=JSON text did not start with array or object and option to allow fragments not set.}

OneDrive SDK ERROR : Error from download response Error Domain=com.microsoft.onedrive.errors Code=413 "request too large" UserInfo={NSLocalizedDescription=request too large}

Is there anyway to get upload progress without KVO? I am getting weird behavior when the app stays in the background too long. I remove the observer before I deallocate, but that doesn't seem to help. Closing the app and reopening fixes that issue.

Thanks for the fix for #3. Unfortunately I still have an issue with getting the actual progress. Downloading files of MIME type application/octet-stream and showing its progress doesn't seem to work.

Here is a shortened output log of the NSProgress object while downloading a ~2 MB file.

2015-09-05 21:59:33.249 [...] <NSProgress: 0x7f843c547790> : Parent: 0x0 / Fraction completed: 0.0000 / Completed: 0 of -1  
2015-09-05 21:59:33.250 [...] <NSProgress: 0x7f843c547790> : Parent: 0x0 / Fraction completed: 0.0000 / Completed: 1043 of -1  
2015-09-05 21:59:33.252 [...] <NSProgress: 0x7f843c547790> : Parent: 0x0 / Fraction completed: 0.0000 / Completed: 8192 of -1  
2015-09-05 21:59:33.254 [...] <NSProgress: 0x7f843c547790> : Parent: 0x0 / Fraction completed: 0.0000 / Completed: 6040 of -1  
2015-09-05 21:59:33.257 [...] <NSProgress: 0x7f843c547790> : Parent: 0x0 / Fraction completed: 0.0000 / Completed: 8187 of -1  
2015-09-05 21:59:33.272 [...] <NSProgress: 0x7f843c547790> : Parent: 0x0 / Fraction completed: 0.0000 / Completed: 8192 of -1  
2015-09-05 21:59:33.275 [...] <NSProgress: 0x7f843c547790> : Parent: 0x0 / Fraction completed: 0.0000 / Completed: 8187 of -1  
2015-09-05 21:59:33.278 [...] <NSProgress: 0x7f843c547790> : Parent: 0x0 / Fraction completed: 0.0000 / Completed: 8192 of -1  
2015-09-05 21:59:33.281 [...] <NSProgress: 0x7f843c547790> : Parent: 0x0 / Fraction completed: 0.0000 / Completed: 8187 of -1  

...

As you can see totalUnitCount (or expectedBytes) is always -1. Furthermore completedUnitCount (or sentBytes) isn't accumulating, not sure if this works out for other file types as well that are not affected by this bug.

Any idea how to solve this? I have this bad feeling that it has to be fixed at the backend, because this progress delegate is called by NSURLSession (in ODURLSessionManager) and it relies on Content-Length being set.

Hi all, In our app we integrate a lot of external sources, among them OneDrive.

We are integrated with OneDrive (before SkyDrive) since a couple of years. Last year, as it was asked by our users to support ODfB, we changed the SDK into OneDrive SDK (from CocoaPods, interference was the pod ADALiOS). It worked well.

However, since last month this integration stopped to work. Please see below detailed information.

Currently during log in to ODfB account, we get error:

“There was a problem logging you in. Could not discover the api endpoint for the given user. Make sure you have correctly enabled the SharePoint files permissions in Azure portal." Error code: 1

The Access settings should be correct, we set these with this instructions: https://dev.onedrive.com/app-registration.htm#3-register-your-app-with-azure-active-directory

We have a problem with getting the correct address of resources URL https://dev.onedrive.com/auth/aad_oauth.htm#step-3-discover-the-onedrive-for-business-resource-uri

When we send request for services: https://api.office.com/discovery/v2.0/me/services in response we get only capability of Directory, and not like in documentation: MyFiles.

{
    "@odata.context" = "https://api.office.com/discovery/v2.0/me/$metadata#allServices";
    value =     (
                {
            "@odata.editLink" = "services('Directory@[email protected]')";
            "@odata.id" = "https://api.office.com/discovery/v2.0/me/services('Directory@[email protected]')";
            "@odata.type" = "#Microsoft.DiscoveryServices.ServiceInfo";
            capability = Directory;
            entityKey = "Directory@[email protected]";
            providerId = "…";
            providerName = Microsoft;
            serviceAccountType = 2;
            serviceApiVersion = "v1.0";
            serviceEndpointUri = "https://graph.windows.net/miknobuisness.onmicrosoft.com/";
            serviceId = AZURE;
            serviceName = "Microsoft Azure";
            serviceResourceId = "https://graph.windows.net/";
        }
    );
}

When we request other rest: allServices, the response has more descriptions: https://api.office.com/discovery/v2.0/me/allServices

{
    "@odata.context" = "https://api.office.com/discovery/v2.0/me/$metadata#allServices";
    value =     (
                {
            "@odata.editLink" = "allservices('Directory@AZURE')";
            "@odata.id" = "https://api.office.com/discovery/v2.0/me/allservices('Directory@AZURE')";
            "@odata.type" = "#Microsoft.DiscoveryServices.ServiceInfo";
            capability = Directory;
            entityKey = "Directory@AZURE";
            providerId = "72f988bf-86f1-41af-91ab-2d7cd011db47";
            providerName = Microsoft;
            serviceAccountType = 2;
            serviceApiVersion = "";
            serviceEndpointUri = "http://azure.microsoft.com/";
            serviceId = AZURE;
            serviceName = "Microsoft Azure";
            serviceResourceId = "<null>";
},
{…},
{
            "@odata.editLink" = "allservices('MyFiles@O365_SHAREPOINT')";
            "@odata.id" = "https://api.office.com/discovery/v2.0/me/allservices('MyFiles@O365_SHAREPOINT')";
            "@odata.type" = "#Microsoft.DiscoveryServices.ServiceInfo";
            capability = MyFiles;
            entityKey = "MyFiles@O365_SHAREPOINT";
            providerId = "72f988bf-86f1-41af-91ab-2d7cd011db47";
            providerName = Microsoft;
            serviceAccountType = 2;
            serviceApiVersion = "";
            serviceEndpointUri = "http://www.microsoft.com/en-us/office365/online-software.aspx";
            serviceId = "O365_SHAREPOINT";
            serviceName = "Office 365 SharePoint";
            serviceResourceId = "<null>";
}

In documentation is info about we should get address of serviceEndpointUri and serviceResourceId, but they are wrong.

Can you help us please?

It seems to me that this SDK doesn't take remote items and shared folders into account, as it should do: https://dev.onedrive.com/misc/working-with-links.htm

I came across this issue, because ODItem's folder property is nil for shared folders. It would be great if this SDK would handle shared folders properly. I'll implement on a workaround for my project in the meantime.

Edit: Maybe some further information for reproducing... share a folder from a second account to your first account... that's it! That means, you can't be the owner of the shared folder. If you're the owner of the shared folder, everything's just fine. The other way round causes the issue.

Repro step:

• Sign in using MSA.
• Test to see if you can get ODClient.loadCurrentClient() simply by just calling it. (Good)
• Kill the app/re-start the app.
• Attempt to refresh the token or call anything that triggers “storeAccount” in ODAccountStore such as making the token expires so that it will automatically refreshes the token.
• Kill the app/re-start the app
• You can no longer access ODClient.loadCurrentClient()
• Now it gets into an unrecoverable state.

Reason:

The OneDriveSDK upon sign in does this:

Sign in:

• Get a response back , parse and store the tokens and userId (where userId is lowercase) in the keychain.
• There is a map of accountId:serviceInfo (accountId is case sensitive) that gets stored in a file via NSKeyedArchiver.
• There is a field called “currentSession” which is also the accountId (case sensitive) gets stored in a file via NSKeyedArchiver
• When you call ODClient.loadCurrentClient(), everything works as expected because all of the sessions are still in memory.

What happens when we kill and relaunch the app and attempt to access the current client?

• It calls loadAllAccounts, which deserialize the ‘currentSession’ and the ‘accountId:serviceInfo' map into memory. Because both of the currentSession and accountId stored in the map are case-sensitive , the look up will succeed. We can find all of the account information associate with this session.
• It then loads all of the secured information from keychain.
• The problem here occurs when the code attempts to assign the “currentSession" to the session we found in the keychain. The session’s account id is now LOWERCASE

IF NOTHING triggers “storeAccounts”, then everything will work fine because nothing new gets saved. However, since the OneDriveSDK supports automatic refreshing token, upon succeeding the refresh, it will call ‘storeAccounts’ , and rewrite the “currentSession” to a file in lowercase. The next time the application loads, it will not be able to find a matching account information due to case-mismatch.

We can no longer call ODClient.loadCurrentClient()

I'm using the iOS SDK to authenticate with a "onedrive.appfolder" scope and query/download files within the application folder.

The request below works as expected:

[[[[self.odClient drive] special:@"approot"] request] getWithCompletion:^(ODItem *response, NSError *error) {
  NSLog (@"response: %@", response);
}];

However when I modify it to fetch the children items instead, the response received is an empty array:

[[[[[self.odClient drive] special:@"approot"] children] request] getWithCompletion:^(ODCollection *response, ODChildrenCollectionRequest *nextRequest, NSError *error) {
  NSLog (@"response: %@", [response value]);
}];

If I try and fetch the items using an explicit path to the Apps folder, it works as expected and the array returned contains all 3 items within the app's folder.

[[[[[self.odClient root] itemByPath:@"Apps/[APP_NAME_REDACTED]"] children] request] getWithCompletion:^(ODCollection *response, ODChildrenCollectionRequest *nextRequest, NSError *error) {
    NSLog (@"response: %@", [response value]);
}

Is this a bug or am I doing something wrong? Thanks, Rog

When I call the function authenticatedClientWithCompletion in order to log in with OneDrive for Business account it fails with the following errors:

1. Cannot add a new item in the keychain. Error code: -25243
2. Failed to login OneDrive with error: Error Domain=com.microsoft.onedrivesdk.autherror Code=1 "There was a problem logging you in" UserInfo={ODAuthErrorKey=Could not discover the api endpoint for the given user. Make sure you have correctly enabled the SharePoint files permissions in Azure portal., NSLocalizedDescription=There was a problem logging you in}

Could please suggest a solution?

1. When I create new App on https://portal.azure.com, I also configurate Redirect URL for IOS platform like this: 'msauth.com.abc.apps.xyz://auth'
2. AppDelegate: ODClient.setMicrosoftAccountAppId("cc07b813-1749-4745-88cf-1e9e0fb183b3", scopes: ["onedrive.readwrite", "offline_access"])
3. call:
   ODClient.client { (client, error) in guard error != nil else { return } }
4. Error when open MS sign in view controller: "invalid_request: The provided value for the input parameter 'redirect_uri' is not valid. The expected value is a URI which matches a redirect URI registered for this client application. onedrive sdk"
5. more infor: when i try with AppID(ClientID: '0000000048160AF8' or another my old app: ) from the sample: https://github.com/OneDrive/onedrive-sdk-ios/tree/master/Examples/iOSExplorer -> no problem

Apple does not accept iOS apps which using the deprecated UIWebView anymore.

Currently, onedrive-sdk-ios is only working with the long time deprecated ADAL version 1.2. This version of ADAL is using UIWebView. Please update onedrive-sdk-ios to use the lates ADAL version which is using WKWebViews.

Compiler warning: Pods/ADAL/ADALiOS/ADALiOS/ADAL_iPad_Storyboard.storyboard:s1f-g9-Kf9: warning: UIWebView is deprecated since iOS 12.0 [7]

/Pods/ADAL/ADALiOS/ADALiOS/ADAL_iPhone_Storyboard.storyboard:aQj-zZ-Grp: warning: UIWebView is deprecated since iOS 12.0 [7]

when calling (ODClient authenticatedClientWithCompletion) in iOS 13. The present controller appears for login but the user can dismiss it using gesture as per iOS 13. When the user does not use the cancel button the delegate not being called and progress hud disappear after request time out.