Reason for changes

The buttons all extended from PaymentButton, which is in essence a UIButton. In order to make the buttons available on SwiftUI, the buttons conformed to the UIViewRepresentable protocol as well. As of iOS 16, we started getting: Fatal error: UIViewRepresentables must be value types: PayPalButton. Any SwiftUI view must be a struct and cannot inherit from any class, only conform to protocols. So, this PR splits the buttons into two classes, one for UIKit and another one for SwiftUI. The SwiftUI ones are essentially a container to theUIKit buttons.

Summary of changes

• Refactor to split the buttons into UIKit and SwiftUI implementations
• UIKit Buttons: UIPaPalButton, UIPayPalPayLaterButton and UIPayPalCreditButton
• SwiftUI buttons: PayPalButton, PayPalPayLaterButton and PayPalCreditButton

Checklist

• [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

• @jcnoriega

Reason for changes

We can use Fastlane to

1. Run tests locally and (potentially) via Github Actions
2. Release the SDK via each of our dependency managers as part of our CI process
3. Attach code coverage test reports / code coverage reports to PRs (in conjunction with GH actions)

These are all things that can be done via a rakefile or exclusively through GH actions, but using fastlane means we can take advantage of the built in fastlane actions (https://docs.fastlane.tools/actions/), as well as have flexibility to run lanes from the command line instead of relying exclusively on GH actions to not fail.

In order to run fastlane via CI, we would just need to run bundle exec fastlane tests

Summary of changes

• Added a Gemfile and a Fastfile
• Added a single lane to execute our unit tests
• Edited the test scheme to be able to run all of our test targets (this was causing the test command to fail)

Reason for changes

This PR adds an HTTPClient to allow for a single HTTPResponse type used to simplify the response of a (URLResponse?, Data?, Error?) result from URLSession data tasks.

Summary of changes

• Create API and HTTP protocols
• Create HTTPClient and APIClient to use HTTPClient
• Move response parsing up a level in CardClient
• Create MockAPIClient and MockHTTPClient to use in unit tests

Checklist

~- [ ] Added a changelog entry~

Summary

This PR:

• Adds root-level PayPal.xcworkspace. This workspace will be the main workstation for this project.
  • The workspace contains two xcodeproj files. One is for the Demo, the other is for the framework's source code & tests.
  • The Demo app imports the Card and PayPal modules.
• Adds framework targets for PaymentsCore, Card, and PayPal modules.
  • The code in here is "Dummy" code that is included for us to test that the project setup works (meant to be replaced).
  • The Card and PayPal modules depend on PaymentsCore. We can follow this pattern when adding new payment methods in the future.
• Adds unit test targets for each module.
• Adds Demo, UnitTest, Card, PayPal, and PaymentCore schemes.
• Adds a Package.swift & PayPal.podspec.

Notes

This PR will be much easier to review by checking out the branch and opening PayPal.xcworkspace. The auto-generated Xcode code is a lot.

This project requires Xcode 13-beta.

What's Next

• Add GitHub Actions CI
  • Add build commands per package manager
• Add UITest & IntegrationTest targets
• Create README from HackMD iOS RFC
• Add Rakefile (or Fastlane) setup for running tests locally
  • Add instructions for running these commands in README
• Create new, shared, development team for Demo App signing. (Currently using Braintree Payment Solutions, LLC)
• Add Demo app Icon

Screenshot

Reason for changes

There was a bug in ordersv2 where we had to add appliction_context to the order creation request, in order for 3DS to work. Now, we only have to add it in the confirm_payment_source request, removing it from order creation

Jira Ticket: https://engineering.paypalcorp.com/jira/browse/DTNOR-606

Summary of changes

• Add Application context to ConfirmPaymentSourceRequestFactory

Checklist

• [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

• @jcnoriega

Reason for changes

This PR updates the CardClient API to better align with the Orders v2 API. In the future, we may revisit API naming to improve the developer experience.

Summary of changes

• Rename CardClient approveOrder method to confirmPaymentSource

Checklist

~- [ ] Added a changelog entry~

Reason for changes

To represent a button in SwiftUI we need the buttons to be represented as a UIViewRepresentable. Taking a look at some best practices across other SDKs, extending the button and adding a Representable struct is the best way to do this. We also needed a coordinator class to coordinate the button actions. While there is some duplication involved, adding this to our SDK allows for us to account for merchants using either/both UIKit and SwiftUI without needing to build out this logic themselves.

Adding this to our SDK allows a merchant to do the following to create a button in their SwiftUI view:

PayPalButton {
    // button action here
}

This very closely models the way a merchant would do this in standard SwiftUI without a representable:

Button("Title") {
    // button action here
}

Summary of changes

• Add Coordinator class to pass action to UIKit button in SwiftUI
• Add PayPalButton and PayPalCreditButton as UIViewRepresentable conforming classes
• Add both buttons to the SwiftUIPayPalDemo
• Moved shared PayPal logic to BaseViewModel - this could probably use a refactor in the future

Checklist

• ~[ ] Added a changelog entry~

Authors

List GitHub usernames for everyone who contributed to this pull request.

• @jaxdesmarais @sarahkoop

Reason for changes

This will allow us to see the linter warnings via Xcode when building instead of needing to wait for CI to finish to see them. If you've not installed swiftlint yet on your machine, to run the linter the first time you will need to install via:

brew install swiftlint

Once you install swiftlint via homebrew, you will not need to run the above command again.

Summary of changes

• Display swiftlint warnings inline
• Make us all a little happier

Checklist

• ~[ ] Added a changelog entry~

Authors

List GitHub usernames for everyone who contributed to this pull request.

• @jaxdesmarais

Reason for changes

This PR creates the PayPalUI module for iOS to separate PayPal SDK UI elements from other modules.

Summary of changes

• Create PayPalUI module

Checklist

~- [ ] Added a changelog entry~

Reason for changes

We need to integrate with PayPalCheckout and provide support for PayPal paysheet to handle PayPal transaction

Summary of changes

• Add PayPalCheckout as dependency for PayPal module
• Add PayPalError and PayPalResult
• Add PayPalPaysheet and PayPalCompletionState

Sample integration

class MerchantViewController: UIViewController {
    let config = CoreConfig(clientID: "clientID", environment: .sandbox)
    let paypalClient = PayPalClient(config: coreConfig, returnUrl: "returnUrl")

    func checkoutWithPayPal(orderID: String) {
        paypalClient.start(presentingViewController: self, orderID: orderID) { state in
            switch state {
                case .success(let result):
                    print("Order is successfully approved and ready to be captured/authorized")
                case .failure(let error):
                    print("There's an error: \(error)")
                case .cancellation:
                    print("Buyer has canceled checkout")
            }
        }
    }
}

Checklist

• [ ] Added a changelog entry

Authors

• @scannillo
• @jonathajones
• @jaxdesmarais
• @minhthenguyen

Reason for changes

• We want Northstar Mobile SDKs to send all analytics to FPTI. This PR sets up a very basic implementation of sending an analytic event to FPTI via APIClient.sendAnalyticsEvent().
• In follow PRs we will address:
  • Batch event uploads
  • Refactoring into separate AnalyticsAPI if necessary / aligning with Android
  • Sending actual events in source code
  • Testing the sendAnalyticsEvent() function, once it is actually used

Summary of changes

• Add AnalyticsEventRequest type which conforms to APIRequest
• Add AnalyticsEventRequest_Tests for validating metadata sent
• Add encodable models for Analytics JSON post body

Checklist

• ~Added a changelog entry~ Will update CHANGELOG once events are sent.

Authors

@mattwylder @scannillo

Reason for changes

1. Simplify code snippet for retrieving presentation anchor
2. couldn't fix runtime warning of running on background thread

Summary of changes

Checklist

• [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

• @kgangineni @scannillo