General Information

• Project version: 1.1.0

• Platform/OS version: iOS 14 and 15

• IDE version: Xcode 13

• Devices: iPhone 12, iPhone X

Describe the bug

Cursor always jumps to the end when editing text

Steps to reproduce

• Type "Hello World"
• Move cursor to the beginning
• Type "A"

Expected behavior

Cursor should be after "A"

Actual behavior

Cursor automatically moves to the end of the text.

Video

https://user-images.githubusercontent.com/3197049/157152747-5c38b183-233c-4a24-8b9f-0d03d98d5554.mov

Additional context

Since you set the text on update ui, the cursor naturally moves to the end. I have a forked version with a fix. It's something I quickly put together so I'm not entirely confident if its clean enough for a PR request (I'm also particularly new to SwiftUI) . I can send a PR if you're fine with it but if not I hope you could roll out a minor fix.

Hope this helps. And thanks for putting this package together.

EDIT: Replace Imgur video link with embedded video.

Describe the feature

Currently, the font can be configured using a custom func font(_ font: UIFont) -> TextView. SwiftUI however is built around properties exposed to the hierarchy through the environment. It would be great if TextView could adopt this and read the font from EnvironmentValues.font. Similarly it could adopt the other standardized properties exposed through the environment.

Is your feature request related to a problem?

TextView does not respect the .font set in the view hierarchy and needs to be manually configured.

Proposed solution

Remove font(_:UIFont) and read the font from the environment using @Environment. Regrettably there does not appear to be an easy way to convert a SwiftUI.Font into a UIKit.UIFont.

Have you read the Contributing Guidelines?

Yes

General Information

• Project version: 1.1.0

• Platform/OS version: iOS 13.2

• IDE version: Version 12.5.1

• Devices: iPhone 11

• Any related GitHub issues: Nope

Describe the bug

TextView's size didn't update

Steps to reproduce

Provide numbered steps to follow that reproduce the bug.

1. Download Demo
2. Delete Presentation and Browsers packages since they can't run on Xcode 12.5.1
3. Delete PresentationDemo and ScrollViewDemo since the package has been deleted
4. Run the project on the simulator and choose TextView

Expected behavior

The text2 string should be fully displayed

Stack trace, compiler error, code snippets

Nope

Screenshots

Only display the first line of string

Additional context

Changing TextView.swift's calculatedHeight default value to 0 fix the problem.

If the TextView's height is set like .frame(height: 100) the text still goes out of bounds and it also starts in the middle by default. In the cases where height of the view or parent is fixed the text should become scrollable.

Have you read the Contributing Guidelines?

General Information

• Project version: 1.1.0

• Platform/OS version:
  iOS 14 and 15

• IDE version: Xcode 13

• Devices: iPhone 13

• Any related GitHub issues: Nope

Describe the bug

.multilineTextAlignment(.center) doesn't center align the text

Steps to reproduce

Provide numbered steps to follow that reproduce the bug.

• Create a TextView()
• Add .multilineTextAlignment(.center) modifier
• Preview it

Expected behavior

Clearly and concisely describe what you expected to happen.

• .multilineTextAlignment(.center) should center align the text

Screenshots

If applicable, add screenshots, gifs, or videos to help explain your problem.

Hi !

First of all, thanks for this SwiftUI multi-line TextView implementation, that's great to be able to use it as easy as it was under UIKit ;)

I've a question, and maybe I've missed something... but when I use this Textview with an NSAttributedString containing some HTML, style is not updated but Markups are gone...

Maybe I'm doing something wrong...

Do you know if this has already worked for you ?

I mean something like:

// and then in my view

struct MyView: View {
 
  var content: String = "This is a <b>bold</b> text."
 
  var body: some View {
      if let contentHtml = content.htmlAttributedString {
          TextView(.constant(contentHtml))
              .isEditable(false)
              .isSelectable(false)
              .allowsRichText(true)
      }
  }
}

When View is displayed, I would expect the word bold to be in bold but here, <b> and </b> markups are removed but no bold anywhere...

Have any idea about that ?

Thank for your answer and have a nice weekend

Jérémie

// somewhere in my code (in a viewModel and in a String extension for example)

extension String {
    func htmlAttributedString() -> NSAttributedString? {
        guard let data = self.data(using: .utf8) else {  return nil  }

        return try? NSAttributedString(
            data: data,
            options: [.documentType: NSAttributedString.DocumentType.html],
            documentAttributes: nil
        )
    }
}

Have you read the Contributing Guidelines?

Issue # https://github.com/SwiftUI-Plus/TextView/issues/5#issue-1161458839

Describe your changes

Clearly and concisely describe what's in this pull request. Include screenshots, if necessary.

By moving the attributedText setter from updateUIView to makeUIView, the cursor will no longer jump to the end upon editing text.

General Information

• Project version: 1.1.0

• Platform/OS version: iOS >= 14

• IDE version: Xcode 13.4.1

• Devices: iPhone 13 mini

Describe the bug

The text starts from the middle when a TextView has an initial height.

Steps to reproduce

1. Add a TextView
2. Add a frame modifier to set the minimum height

TextView($text)
    .placeholder("Description")
    .frame(minHeight: 80, maxHeight: .infinity)

Expected behavior

I'm trying to replicate the new reminder form ("Notes" field) of the default Reminder app which has a minimum height to start with and grows with the content. This library handles it like a pro except one tiny issue that the text alignment is in the middle instead of top.

Screenshots

Have you read the Contributing Guidelines? Yes

General Information

The issue I see seems very strange to me, in that deleting the last character with the delete key is a fundamental function. Yet, it doesn't work in the situation I'm using it.

What I'm looking for is confirmation that what I'm seeing is a fundamental bug, or just something that is happening in the complex CoreData, @ObservedObject, and SwiftUI architecture.

• Project version:

• Platform/OS version: iOS 15.x. MacOS Cayalist

• IDE version: Xcode 13.2.1

• Devices: iOS and iOS simulator

• Any related GitHub issues:

Describe the bug

After trying a few characters into a TextView and then deleting them using the delete key, all the characters will delete except the last. What happens to the last, is the cursor will move to the 0 position, but the last character remains.

Also, related is if you have one or more characters and you select them and either hit the delete key, or use the Cut menu item, the text remains as described above.

Steps to reproduce

See above.

Expected behavior

The last character to delete.

Stack trace, compiler error, code snippets

None

Screenshots

None

Additional context

My text is coming from a CoreData text string, from an @ObservedObject var dataElement: [CoreDataObjectWithText]

Usage: TextView(Binding(self.$dataElement.text, replacingNilWith: "")) .isEditable(true)

Below is the custom Binding extension.

public extension Binding where Value: Equatable { /// Creates a non-nil binding by projecting to its unwrapped value, translating nil values /// to or from the given nil value. If the source contains nil, this binding will return the /// nil value. If this binding is set to the given nil value, it will assign nil to the underlying /// source binding. /// /// This is useful if you have optional values of a type that has a logical 'empty' value of /// its own, for example String: /// /// @State var name: String? /// ... /// TextField(text: Binding($name, replacingWithNil: "")) /// /// If the name property contains nil, the text field will see an empty string. If the text field /// assigns an empty string, the name property will be set to nil. @available(macOS 10.15, iOS 13, tvOS 13, watchOS 6, *) init(_ source: Binding<Value?>, replacingNilWith nilValue: Value) { self.init( get: { source.wrappedValue ?? nilValue }, set: { newValue in if newValue == nilValue { source.wrappedValue = nil } else { source.wrappedValue = newValue } }) }

Have you read the Contributing Guidelines?

Issue

When you input a multiline string and insert a new line somewhere in the input, the cursor will stay on the previous line whereas the height of the text view has increased (see attachment)

Step or reproduce

1. Input a random string
2. Insert a new line by pressing the return key
3. you can see the cursor stayed at the previous line, but the new line has been added.

Describe your changes

1. Use sizeToFit to get the accurate textView size.
2. Only update the textView size if the diff is larger than the threshold (since it is not that good to use == for floating value comparison)

Clearly and concisely describe what's in this pull request. Include screenshots, if necessary.