It looks like the size of cloned UIView gets shifted (the title moves down then flickers away).. Is it possible to just have a complete black overlay then have the image do the animation expand into its placeholder to avoid showing the existing UIView?

This is preventing me from using this tool in production.

When presenting images, such as the one in the sample project, on the iPhone 6 and 6+ simulators, the main view seems to jerk before presenting the image. It enlarges a little, then shrinks back, then continues with the correct animation.

Any plans or interest in using this controller for video as well as images? If so, I would be happy to work on it (I just don't want to put the work in if you don't have any interest of supporting video at all).

Maybe nitpicking here but the definition and return are not consistent in blurredSnapshotFromParentmostViewController:: defined as UIView and returned as UIImageView

Thanks for your work :-)

I noticed that the view controller that is beneath the image does not rotate. This means if you display an image, then rotate the screen, then dismiss the image. There is an abrupt change in orientation after the animation finishes. Is there a way for the view beneath the image to rotate also?

On a real device, when I want to zoom the image, it flickers (actually really fast resizes/moves), whenever my zoom gesture is fast. I have to zoom very gently to prevent this. Once I manage to zoom it's ok, this issue appears for zoomLevel == 1 and fast gesture.

On simulator it happens if I firstly drag it with mouse, then press option, to begin zooming, when I firstly click option, than mouse, it's ok. So probably it recognizes the beginning of zooming as dragging.

Here's a gif:

(this is iOS 7.1 with JTS 1.3, although I did notice this issue a month ago, when I firstly tried to use it) The example works fine, the problem is with presenting it from my tableViewCell.

I tried with different combinations of referenceRect/View and modifying code in library (messing with _flags and zoomLevel), but with no luck.

What I do is add a UITapGestureRecognizer to my UIImageView in a UITableViewCell. In tap handler I present JTS:

//Note: This happens in UITableViewCell subclass

-(void)awakeFromNib
{
self.photoImageView.userInteractionEnabled = YES;
    UITapGestureRecognizer *imageTapGesture = [[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(handleTap:)];
    [self.photoImageView addGestureRecognizer:imageTapGesture];
}

-(void)handleTap:(UITapGestureRecognizer *)gesture
{
    CGPoint location = [gesture locationInView:[gesture.view superview]];
    if(!CGRectContainsPoint(self.photoImageView.frame, location))
        return;

    JTSImageInfo *imageInfo = [JTSImageInfo new];
    imageInfo.image = self.photoImageView.image;
    imageInfo.referenceRect = self.photoImageView.frame;
    imageInfo.referenceView = self.parentVC.view;

    JTSImageViewController *imageViewer = [[JTSImageViewController alloc] initWithImageInfo:imageInfo mode:JTSImageViewControllerMode_Image backgroundStyle:JTSImageViewControllerBackgroundStyle_ScaledDimmedBlurred];

    imageViewer.interactionsDelegate = self; //thought I could block flickering this way, but tapping also has been disabled
    imageViewer.dismissalDelegate = self;

    [imageViewer showFromViewController:self.parentVC transition:JTSImageViewControllerTransition_FromOffscreen]; //transition has no impact on this issue
}

I may be missing something, but I have a problem when an image is smaller than the image view it is being displayed in. This is mostly an issue on the iPad. The image is stretched to fill the entire image view instead of just being displayed smaller (and at a suitable resolution) within the image view. I feel like I must be missing something, but if not, this may be a bug, or at least an intended effect?

Hi,

First of all thank you for all the amazing work on this project.

The issue I have is very minuscule. In iOS 8 while using a UITableView, I present the JTSImageViewController and upon dismissal the table view scrolls (not animated) to the top, that is to say the contentOffset is lost.

I read through most of the code in JTSImageViewController.m and it is not at fault. Apparently it's the default behaviour to reset the contentOffset after returning from a modal view controller. I have tried automaticallyAdjustsScrollViewInsets = NO and using a UITableView inside a UIViewController instead of a UITableViewController but no luck. I've also tried setting the contentOffset back after the dismissal but it flashes.

It seems setting the modal presentation style of JTSImageViewController to UIModalPresentationOverFullScreen fixes the issue (since it doesn't remove the hierarchy below it and retains the scroll position I think). As this enum is new to iOS 8 I am going to assume that it's an iOS 8 only issue (since if it wasn't there would be more issues about it).

Any thoughts? Has anyone else experienced this? If so should I make a pull request for this simple change?

if ([[[UIDevice currentDevice] systemVersion] compare:@"8.0" options:NSNumericSearch] != NSOrderedAscending) {
    self.modalPresentationStyle = UIModalPresentationOverFullScreen;
}

Hi Jared,

Thanks for writing this component. I added a dynamic framework so that people who use Carthage can use this too. I have also added completion parameter to the -showFromViewController:transition: as I needed this too.

Let me know what you think

Adds a podspec file so the library can be used as a CocoaPod.

If I'm missing anything important in the file, let me know. I tried to keep it fairly simple, and it worked well on test integrations.

under iOS 9, this warning appears several times during compilation:
'setStatusBarHidden:withAnimation:' is deprecated: first deprecated in iOS 9.0 - Use -[UIViewController prefersStatusBarHidden]

It's not difficult to fix per se (the correct approach has been around since iOS 7), but because it doesn't appear that iOS 9 provides a means of animating the status bar fade--you've either got it or not--changing this will affect the logic a bit.

When Analyzing my project, I get that issue : /MyProject/Pods/JTSImageViewController/Source/JTSImageInfo.h:23:1: Property of mutable type 'NSMutableDictionary' has 'copy' attribute; an immutable object will be stored instead

Hey @jaredsinclair .

Maybe you could add a note with links to alternatives like NYTPhotoViewer or IDMPhotoBrowser for example. It took me a while to find some. So maybe that would help people who once used your controller starting new projects.

Best, Roman.

The landscape orientation is not working with my App when I change the orientation of the device. Is the auto rotate feature supported or not ?

I can't see any informations about this.