Reported on 2284689-zen

After updating WordPress for iOS, the app can no longer be started.
If you delete it and install it again, it will be forcibly terminated after 
login, and it will no longer be able to start.

Similar cases in the forums:

• https://ios.forums.wordpress.org/topic/wordpress-app-crashing
• https://ios.forums.wordpress.org/topic/app-crashing-after-update

This was reproduced in iPhone X with version 13.0, and iPhone 7. We could not reproduce it on 5s (iOS 12.4) or 6s . Here's a video of what @chaitanyamsv is experiencing on his phone:

https://cld.wthms.co/8FL1PD ^{Tested with iPhone 7 on iOS 12.2 right after upgrading to WPiOS 13.0.}

(EDIT) Crash details: https://github.com/wordpress-mobile/WordPress-iOS/issues/12338#issuecomment-535896537

Fixes

• Fixes #14744

Description

We have decided to remove Site Switcher in the Editor after collecting the Analytics Data as it's not a widely used feature & more importantly it was a source of few inconsistencies as captured on this (link on Internal References Section) proposal. This PR addresses that.

Testing instructions

• Start a new post in Gutenberg or Aztec Editor
• We shouldn't have Site Switcher
• Instead we should have the Site Title as the ViewController Title
• During intermediate states like Generating Preview & Media Uploading, when we show left bar button item(s), Site Title should hide

Screenshots

|Before|After (Gutenberg)|After (Aztec)|After (Intermediate state of Generating Preview in Gutenberg)| |---|---|---|---| |||||

Screen Recording

Before

https://user-images.githubusercontent.com/16770566/112341452-726cd080-8ce7-11eb-9b52-51e0617e8e5e.mov

After

https://user-images.githubusercontent.com/16770566/112641457-6e1bf100-8e68-11eb-9638-7872b9e95c75.mov

After (Intermediate state of Generating Preview)

https://user-images.githubusercontent.com/16770566/113284507-5e3c5b00-9307-11eb-88ad-646bbff96af1.mov

PR submission checklist

• [x] I have considered adding unit tests where possible.

N/A

• [x] I have considered adding accessibility improvements for my changes.

|Before|After| |---|---| |||

Note: Pringles in the after image is the Site Title

• [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Note

• Big shoutout 💯 🥳 to @ceyhun, my trial buddy for helping me out throughout. Please have a 👀, add the label & milestone, give some ❤️ if you like it 🤝

Internal References

For more details, please checkout

• proposal (p9ugOq-1fv-p2)
• my Trial plan (pbMoDN-2et-p2)

Goals

• Add support for iOS 13's dark mode

Tasks

Global

• [x] Add XCODE11 build flag to support parallel development between Xcode 10 & 11 (#12120)
• [x] Create initial set of preview screenshots
• [x] First-pass at dark mode support on main tab bar screens
• [x] Dark mode versions for badged state of tab bar images
• [x] Fancy alerts have white backgrounds
• [x] Revisions section has white backgrounds
• [x] QuickStart has some white background
• [x] Add new site flow has some white background
• [ ] Update fancy button border style (https://github.com/wordpress-mobile/WordPress-iOS/issues/12320#issuecomment-527646730) #12592
• [x] Change textPlaceholder Muriel color to use tertiaryLabel on iOS 13.
• [x] Register domain has white backgrounds
• [x] Edit comment is white text on white background.
• [x] Pending comments have a white background.
• [x] Gravatar cropping screen has a white background

Regressions

• [x] Reader tag area shows visible side gradients: https://github.com/wordpress-mobile/WordPress-iOS/issues/12457
• [x] Web preview has blue toolbar on iOS 12

NUX

• [x] Dark mode for NUX
• [x] Login NUX button has black spinner while signing in
• [x] Header text on sign up bottom sheet isn't readable
• [x] Header and footer on signup epilogue are white and should be listForeground
• [ ] New account epilogue has a different color behind 'new account' which shouldn't be there https://github.com/wordpress-mobile/WordPress-iOS/issues/12593
• [ ] Modal HUD shown after hitting Continue on New Account screen should use system grey background. https://github.com/wordpress-mobile/WordPress-iOS/issues/12595
• [ ] Activity indicator on secondary NUX buttons appears white-on-white in light mode. #140

Editor

• [x] Dark mode for editor
• [x] Dark text on dark background in Aztec HTML mode
• [ ] Post Settings: Tags screen has white to the left and right of the tags field https://github.com/wordpress-mobile/WordPress-iOS/issues/12596
• [ ] Post Settings: After setting a featured image, tapping on the featured image (e.g. to remove it) shows a white background https://github.com/wordpress-mobile/WordPress-iOS/issues/12597
• [ ] Block editor: Bullet overlaps placeholder when adding a new list block (dark mode only) #1391 Gutenberg

Stats

• [x] Some areas in Stats Insights still have white backgrounds
• [x] Dark countries map can be too dark to read

My Sites

• [x] Posts cells (expanded view) have white backgrounds for some labels
• [x] Post / pages tab bar style should match Stats
• [x] Themes support icon isn't being tinted correctly
• [x] Ghost view in posts / pages has a white background
• [x] Activity logs (in help and support) have white text on white background
• [x] Plans are still light colored
• [x] Activity screen is still light colored
• [x] Reverse text and textSubtle colors in Activity Log list.
• [x] Remove divider below 'free plan' footer in Activity Log list
• [x] Plans list 'Best for...' text should use textSubtle
• [x] Menus: Down arrows and reorder handles should use textTertiary (via textPlaceholder?) Page icon beside 'new item' should use listIcon color.
• [x] Menus: When editing a menu name, use tertiarySystemBackground / gray80 for the background color. Text should be text and X icon should be listIcon.
• [x] Sharing > Sharing Buttons / Manage > Edit sharing buttons – icons should use listIcon. "share this" and "official buttons" should use textSubtle.
• [ ] Posts list: After trashing a post, the "undo" cell has a white background https://github.com/wordpress-mobile/WordPress-iOS/issues/12598
• [ ] Settings: Time Zone & Tags screens have a white background when you pull to refresh https://github.com/wordpress-mobile/WordPress-iOS/issues/12599
• [ ] Settings: Pickers have white text on white background (Posts per page & Discussion settings: Close commenting, Paging, Links in comments) https://github.com/wordpress-mobile/WordPress-iOS/issues/12600

Reader

• [ ] Tapping "Reply" on a reader comment shows a white background around the comment https://github.com/wordpress-mobile/WordPress-iOS/issues/12601
• [ ] Followed Sites: Tapping Manage and then back leaves the "Manage" cell highlighted (white background) https://github.com/wordpress-mobile/WordPress-iOS/issues/12602
• [ ] When liking a post, the star icon has a black background during the animation https://github.com/wordpress-mobile/WordPress-iOS/issues/12603

Extensions

• [x] Update widget
• [x] Update share extension
• [x] Update notifications rich content extension

V2

• [ ] Make tab bar translucent

Switching between dark and light mode #12441

• [ ] Reader Detail
• [ ] Fancy button
• [ ] SearchBar strokes

Notifications

• [x] Comment moderation has incorrect background on the comment cell, screenshot added to the thread.

Analytics

There are no analytics events for this project.

Related issues

This will finally close #6373 🎉

Welcome to the Reader readability, autosizing and scrolling performance PR. The bulk of this PR is geared towards improving our Reader experience on iPad and preparing the way for Reader split-view support. However, many many changes had to be made to support this and keep the experience optimal on both iPhone and iPad:

• Removed a ton of technical debt/code.
• Removed all of the previous manual cell height and layout calculation code.
• Restructured all of our Reader cells for autosizing.
• Additionally restructured our cells with UIStackViews for ease of layout and future adaptability.
• Following Apple's ordained readable margins on all of our cell's content for both iPhone and iPad.
• Took a step toward the upcoming Reader card refresh design by extending our borders to the edges of the screen rather than the boxes we've had before. This is also a far less complicated layout == better scrolling performance.
• Paid very close attention to scrolling performance on all devices, including iPhone 4S, attempting to improve performance where we can.
• Improved refresh, appearance and back-navigation performance.

Note: The ReaderDetailViewController was only minimally touched for this PR and will await the upcoming detail view refresh to receive a needed layout overhaul.

Note: The ReaderCommentsViewController was barely touched on this PR and will need its own revamp to properly support readability, autosizing and iPad. For now, we present Reader comments as a modal on iPad.

Bonus: Fixes: #5994 Fixes: #5981

iPhone and iPad

1. Ensure Reader cards render as expected on all Reader menu streams.
2. Ensure Reader stream scrolling performance is as expected and at least as good as before on older devices, such as iPhone 4S.
3. Ensure Reader cards are following readable margins on iPhone, iPhone Plus landscape, and iPad.
4. Test that all buttons on Reader cards work as expected.

iPad

1. Check that comments open in a modal view controller for Reader streams and from Reader detail.
2. Check that #5082 doesn't reproduce.
3. Test transitioning from iPad split-multitasking transitions nicely and correctly for readable margins.

iPhone

1. Check that Reader comments open as a push onto the navigation stack.
2. Check that #5082 doesn't reproduce on iPhone Plus landscape orientation.

Review

• @frosty are you willing to take a long stroll through some Reader code? I promise most of the +- are from nibs. 😅 We can add additional code reviewers if you'd like.
• @aerych can you take a look at the changes made in WPTableViewHandler as those are particular to the many discussions we've had.

Also, @aerych it would be amazing if you could spend some time testing throughout the Reader experience on both iPhone and iPad to ensure I haven't missed any gotchas or other historical Reader issues that you would be familiar with.

Design Review

@jancavan and/or @mattmiklic can you take a stroll through this build or screenshots? We've made some scrolling performance-dependent design decisions in sync with the upcoming cards refresh. I opted not to go too far into the new refresh design or into what is requested on #5769 as those are better suited for a separate PR. Let me know if anything stands out for this round that we should address now.

Screenshots

Reported in the forums:

Using the current iOS (iPad) Wordpress app to post to a self-hosted (absolutely up-to-date) WordPress Install

Images are uploading 100% AOK but the links in the posts are wrong/nonsense - likely the file on the iPad and not the site?

They looking like

<img data-wpid="2BD088EC-EAC7-4879-8B26-ABDAE30C4261" src="/var/mobile/Containers/Data/Application/9EB99EF4-F0D2-4F4E-850B-4A6F493AC6F5/Documents/Media/img_1230-thumbnail.jpeg" alt="">

Opening this issue to track.

This pull requests introduces a new style post list and a number of new features.

• Posts are now displayed as a card view.
• A post can be displayed in one of three styles depending on whether it is text only, includes images, or has a featured image.
• The list can be searched locally.
• The list can be filtered.
• The trash folder is now supported and posts can be restored from the trash.
• Multi-author blogs have the option to show posts from all authors or just the signed in user.
• You can view status for a specific post.

To accommodate the new features there were changes to:

• core data, we have a new model revision
• service and network layers to support new and modified calls
• how the app handles post status
• NUX and Me for synching user details (like ID)
• miscellaneous changes to related functionality

This is a very significant (and sizable) change and I’d like to have at least a couple of reviewers to help vet all the things, but I'd like to ping a few folks for some specifics : For the storyboards, xibs and layout: @jleandroperez or @astralbodies For changes to core data, networking, and service layers @astralbodies or @koke For changes that impact the editor: @bummytime or @diegoreymendez

Thank you all very much in advance. I will owe you many :beers: for this one.

Refs #3506

This is a continuation of https://github.com/wordpress-mobile/WordPress-iOS/pull/5268 in which we decided to refactor the previous implementation. This PR includes the refactor of nested view controllers as well as including the complete MenuItemEditingViewController and supplemental editing views.

Note: The addition numbers are bloated here since I renamed the files to reflect the refactor of nested view controllers. The MenuItemSourceXXXX view controller are largely untouched from their previous implementation as standalone views once reviewed in https://github.com/wordpress-mobile/WordPress-iOS/pull/5268

To test:

1. Build and run the staging branch feature/menus-views to load the complete Menus implementation.
2. Select a .com site with admin rights.
3. Select "Menus" under the site options.
4. Select a MenuItem to edit its source, such as "Home", "About", "Blog", etc.
5. Source views are loaded as Pages, Posts, Link, Categories, Tags or Posts using custom content types.
6. You can select different types by hitting the header area with the left chevron, which loads the corresponding sources in the correct source view.

Pages

• [ ] Test that pages load as expected for a site.
• [ ] Test that searching loads both local and remote pages.
• [ ] Test that selecting a page and pressing the "OK" button dismisses the view and updated the item on the starting Menus screen.

Posts

• [ ] Test that posts load as expected for a site.
• [ ] Test that searching loads both local and remote posts.
• [ ] Test that posts continue loading via paging when scrolling to the bottom for a site with many posts.
• [ ] Test that selecting a post and pressing the "OK" button dismisses the view and updated the item on the starting Menus screen.

Link

• [ ] Test that the "LINK ADDRESS (URL)" field accepts text as expected.
• [ ] Test that the "Open new link" checkbox checks and un-checks as expected.

Categories

• [ ] Test that the categories load as expected for a site.
• [ ] Ensure the parent/child nesting is as expected for a site.
• [ ] Test that selecting a category and pressing the "OK" button dismisses the view and updated the item on the starting Menus screen.

Tags

• [ ] Test that the tags load as expected for a site.
• [ ] Test that searching tags loads both local and remote tags for a site as expected.
• [ ] Test that paging a long list of tags loads as expected for a site.
• [ ] Test that selecting a tag and pressing the "OK" button dismisses the view and updated the item on the starting Menus screen.

Custom Posts

• [ ] Load some custom post types for a site/theme as noted in https://jetpack.com/support/custom-content-types/
• [ ] Create posts using these types on the site.
• [ ] Load the associated custom type with the app Menus editing.
• [ ] Test that the custom posts load as expected for the site.
• [ ] Test that selecting a post and pressing the "OK" button dismisses the view and updated the item on the starting Menus screen.

Title Editing

• [ ] Test that updating the title text in the top header text area updates the title of the item by hitting
• [ ] "OK" to save the change and it is reflected on the starting Menus view.

Cancel Button

• [ ] Test that making changes to the item and hitting the "Cancel" button indeed cancels the changes the MenuItem is unchanged on the starting Menus view.

Trash Button

• [ ] Test that pressing the trash icon button dismisses the view and deletes the item from the starting Menus view.

Needs review: @aerych 🎉🎉🎉 (let me know if I'm crazy)

Sentry Issue: WORDPRESS-IOS-1FZ2

NSInternalInconsistencyException: Invalid update: invalid number of rows in section 0. The number of rows contained in an existing section after the update (10) must be equal to the number of rows contained in that section before the update (10), plus or minus the number of rows inserted or deleted from that section (1 inserted, 0 deleted) and plus or minus the number of rows moved into or out of that section (0 moved in, 0 moved out). ?, in <redacted> ?, in <redacted> ... (26 additional frame(s) were not displayed)

This PR refreshes the reader comment table view cells UI, updating the style to match what is currently in the Calypso reader and replacing the DTCoreText backed WPRichTextView with our new WPRichContentView.

Fixes: #4034 Fixes: #4710 Fixes: #4641 Fixes: #6083 Refs: #5594

To test: Take the ReaderCommentViewController for a test drive and confirm that all the following work as expected:

• Comments still load :)
• Threaded comments are properly nested up to 4 levels deep.
• You can like a comment. A liked comment correctly shows its status.
• You can reply to a comment.
• The comment author can be tapped to view the author's blog when the author's URL is available.
• Comments still load more as expected.
• The post header and the reply text view are resized when changing orientation, and when multitasking on the iPad.
• Links in comments are opened correctly.
• Images in comments display correctly and can be previewed.
• Videos in comments display correctly and can be played.

Needs review: @kurzee would you be game for the code review?
cc @jleandroperez

Once this one lands, there will be a final PR to remove DT and the last of its dependencies. :)

Before:

After:

Posts published via the app have “Allow Comments” off even though the My Sites > Settings > Discussion > Allow Comments option is toggled on.

The problem in a nutshell: up until the next to last update I was able to post from the app with comments enabled by default. Now comments posted from the app have comments disabled by default and I have to manually fix that every day.

• WPiOS 13.7
• iOS 12.3.1
• Type of site: WordPress.com Personal Plan

^{(internal references: 14015487-hc, 2185450-zen // originally reported 2019-07-17)}

Noting part of a discussion we had about this case earlier which may be helpful:

Took a quick look at the code for the v1.1 and v1.2 REST endpoints to create and update a post. A discussion parameter can be passed to enable or disable comments (among other things) but if it isn’t specified nothing specific is done. I’d assume that whatever the default is for the site would apply? I double checked the WPiOS post service and post service remote code and it doesn't look like discussion is one of the passed parameters.

^{(internal reference: p4a5px-2q4-p2#comment-10284 /hat tip @aerych)}

Note: a few of us have tried a few times to replicate this bug but have not been able to so far.

Fixes https://github.com/wordpress-mobile/gutenberg-mobile/issues/3125

Related PR:

WordPressKit-iOS: https://github.com/wordpress-mobile/WordPressKit-iOS/pull/352

Description

This PR extracts a FilterableCategoriesViewController class from the implementation previously used in the modal layout picker so that the site design collection screen can use the same filterable categories view controller.

Since there are differences in the sibling subclasses (and the types used to represent their data), I've also introduced a CategorySection protocol which allows each subclass to continue to benefit from the strong type bindings, but also utilize the more general implementations of the superclass they inherit from for most of the filtering and display logic.

:construction: Device Mode Selection

Since the device mode selection feature has not yet been added to the modal layout picker, the extracted class does not support this yet. This will need to be implemented in the superclass to retain the feature for the site design screen (and it will subsequently be enabled for the modal layout screen as well).

Update: This has been updated to re-enable device mode selection on the site design screen. The feature can be enabled for the modal layout picker in a subsequent PR.

Testing steps

The steps to test are mostly the same as flows we've already tested, e.g. the category filters should work the same way in the site design screen as they do in the layout picker. To be thorough, I've enumerated many of the flows below.

In order to test this PR, the API will need to be sandboxed until the API changes are deployed.

Update: The API changes have been deployed. This PR can now be tested without sandboxing :tada:

Modal Layout Picker

The layout picker for new pages should behave the same as before. Test to make sure no regressions were introduced during the refactoring.

Site Design Picker

Navigate to the Create WordPress.com site - My Sites > ➕ > Create WordPress.com site

Categories

The site design collection screen should now show a category filter bar that functions the same as that used in the layout picker.

Preview Device Mode Selection

Site design thumbnails

Site design previews

Mode between steps

PR submission checklist:

• [x] I have considered adding unit tests where possible.
• [x] I have considered adding accessibility improvements for my changes.
• [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Expected behavior

Hold off on removing features, until we have a change to reload the UI and remove all features at one go.

Steps to reproduce

Launch the app Enable Phase 4 flag from the debug menu Return to My Site Pull to refresh Notice that JP features are removed from the menu but the tab bar and dashboard are still accessible.

See conversation at https://github.com/wordpress-mobile/WordPress-iOS/pull/19793/files#r1052892161

To test

This change does not affect either the codebase or the automation. Green CI will suffice.

Regression Notes

1. Potential unintended areas of impact – N.A.
2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
3. What automated tests I added (or what prevented me from doing so) – N.A.

• [x] I have completed the Regression Notes.
• [x] I have considered adding unit tests for my changes. N.A.
• [x] I have considered adding accessibility improvements for my changes. N.A.
• [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

Closes #19813 Design ref: qk5s4q4mZsXknwhMWo2vIY-fi-439%3A5242

Description

This PR adds a "Switch to Jetpack" button to the bottom of the menu in phase 4. The card from phase 3 is reused here with a few modifications to match the design of the phase 4 card.

Screenshots

| Light Mode | Dark Mode | | - | - | |||

Testing Instructions

1. Go to JetpackBrandingMenuCardPresenter.swift line 173
2. Change the value of secondsInDay to any small value, 10, for example
3. Launch the app
4. Open the debug menu and enable "Jetpack Features Removal Phase Three"
5. Kill and relaunch the app
6. Make sure the menu card is displayed as the first menu item
7. Make sure the card matches the design
8. Make sure tapping the card displays the overlay
9. Tap the ellipsis and tap on "Hide this"
10. The card should be removed
11. Open the debug menu and enable "Jetpack Features Removal Phase Four"
12. Kill and relaunch the app
13. Make sure the menu card is displayed as the last menu item
14. Make sure the card is compact and matches the design
15. Make sure tapping the card displays the overlay
16. Tap the ellipsis and tap on "Remind me later"
17. The card should be removed
18. Wait for the duration to pass (If you set secondsInDay to 10, then wait for 40 seconds)
19. Pull to refresh the menu
20. Make sure the menu card is displayed

Regression Notes

1. Potential unintended areas of impact Phase 3 card

2. What I did to test those areas of impact (or what existing automated tests I relied on) Manual testing and JetpackBrandingMenuCardPresenterTests

3. What automated tests I added (or what prevented me from doing so) N/A

PR submission checklist:

• [x] I have completed the Regression Notes.
• [x] I have considered adding unit tests for my changes.
• [x] I have considered adding accessibility improvements for my changes.
• [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Description

"Views and Visitors" card in details view has "Week >" button which leads nowhere.

It's a regression from Rebuild Views & Visitors card when selected segment changes since I expanded siteStatsInsightDetailsDelegate with viewsAndVisitorsSegmentChanged and started using in both details and insights tab. However, StatsBaseCell uses siteStatsInsightDetailsDelegate != nil to determine whether to show the "Week >" button.

Move viewsAndVisitorsSegmentChanged to a separate delegate to avoid breaking siteStatsInsightDetailsDelegate != nil shouldShowDetailsButton() mechanism in StatsBaseCell

Testing instructions

Enable "New Appearance for Stats" and "New Cards for Stats Insights" feature flag

Case 1:

1. Open Stats
2. Add Views & Visitors card
3. Click "Week"
4. Confirm that Views & Visitors in details view does not have "Week button"

Regression Notes

1. Potential unintended areas of impact

Breaking changes in https://github.com/wordpress-mobile/WordPress-iOS/pull/19818

2. What I did to test those areas of impact (or what existing automated tests I relied on)

Retesting

5. What automated tests I added (or what prevented me from doing so)

None

PR submission checklist:

• [x] I have completed the Regression Notes.
• [x] I have considered adding unit tests for my changes.
• [x] I have considered adding accessibility improvements for my changes.
• [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Images & Videos

Before the fix

https://user-images.githubusercontent.com/4062343/210357851-34dc0954-57dc-4c1c-b77f-dbc4d7dbc22a.MP4

After the fix

https://user-images.githubusercontent.com/4062343/210358982-5b861b1c-364a-4799-a45c-37626d5774e3.mp4