I studied the example and also use the code for tabbar controller but when the actionsheet, it is invisible.

when I comment out the items.append(sampleView), I can see a CANCEL button.

It seem that something is wrong with my sampleview xib but i can figure it out.

HELP!

Hello, when i create a CustomizableActionSheet with buttons, in a UITableViewController, the last button is below in the UITableViewController but not visible, is it possible to display it with the others in the visible part of my UITableViewController ?

Thanks for the awesome library! I'm having build errors with Swift3 and Xcode8 while using either the swift3 branch or master branch.

I'm using:

pod 'CustomizableActionSheet', :git => 'https://github.com/beryu/CustomizableActionSheet', :branch => 'swift3'

And have a number of build errors. I noticed #8 is open but neither branches seem to work for my project.

Any suggestions?

Hi,

The CustomizableActionSheet.podspec includes the following: s.xcconfig = { 'SWIFT_VERSION' => '3.0' }

This overwrites target projects SWIFT version (which for newer projects are 3.1) and causes this CocoaPods error:

[!] The My-Project [Debug] target overrides the SWIFT_VERSION build setting defined in `Pods/Target Support Files/Pods-My-Project/Pods-My-Project.debug.xcconfig'. This can lead to problems with the CocoaPods installation

I think best practice is not to include the SWIFT_VERSION in your pod spec - see reference here

This pull requests corrects the spelling of CocoaPods 🤓 https://github.com/CocoaPods/shared_resources/tree/master/media

One day I’ll make a bot that looks through the READMEs of all Pods, looks to see if it uses “Cocoapods” and PRs “CocoaPods” :D

— Ørta (@orta) February 10, 2016

The action sheet would cut off from the bottom if it is used in a scrollview and if the scrollable content goes beyond the UIScreen.

This is due to this line in the code in the showInView method-

public func showInView(_ targetView: UIView, items: [CustomizableActionSheetItem], closeBlock: (() -> Void)? = nil) {
   // Save instance to reaction until closing this sheet
   CustomizableActionSheet.actionSheets.append(self)

let screenBounds = UIScreen.main.bounds
.....

The screenBounds should take targetView.bounds instead of UIScreen.main.bounds which resolves the issue.

  public func showInView(_ targetView: UIView, items: [CustomizableActionSheetItem], closeBlock: (() -> Void)? = nil) {
    // Save instance to reaction until closing this sheet
    CustomizableActionSheet.actionSheets.append(self)

    let screenBounds = targetView.bounds

GitHub changed the way Markdown headings are parsed, so this change fixes it.

See bryant1410/readmesfix for more information.

Tackles bryant1410/readmesfix#1

Hi, For iOS and macOS projets it's will be great to make your component Carthage compatible

Take a look at these articles:

• Ruthlessly Simple Dependency Management with Carthage
• Carthage Tutorial: Getting Started
• Making Carthage-compatible Frameworks with Swift
• Swift Cross Platform Framework (section Configure targets for Carthage) 👍

On your README.md add on top and add section for the installation with Carthage.

Hi beryu,

Thank you so much for your CustomizableActionSheet.

I enjoy reading it. Your code is very clean and easy to understand.

I intent to use your library in an app which supports portrait and landscape mode. However, I notice the current code doesn't work well under landscape mode.

Please refer the the following.

Before patch

I did a slight modification, so that it will work well in landscape mode.

I include a few more screenshots, to show it works well under both iPod/ iPhone 12, both portrait/ landscape mode.

After patch

Hope you will agree with the pull request.

Feel free to let me know, if you need further clarification from me.

Thank you.

Open the action sheet in say, the portrait mode and rotate the device, the action sheet will not adapt to the new orientation and therefore cannot be seen on the screen (since the dimensions of the action sheet are made based on the earlier orientation).

Is there any plan to add support for rotation? Thanks.

Fixed #17

• Make convenience initialize function public.
• Use convenience initialize function in demo app.
• Change deployment target version of demo app.

Hi Beryu,

I would like to propose a fix on animation.

The problem will become more obvious, if I increase the height of custom view, and make the animation time longer.

Here's the video before the proposed fix, and after the proposed fix.

The idea of the fix is, the delta Y animation should be the height of the bottom sheet, not the y-position of bottom sheet

Before

https://user-images.githubusercontent.com/308276/104816277-14d68680-5855-11eb-947e-7b93173541f5.mov

After

https://user-images.githubusercontent.com/308276/104816287-291a8380-5855-11eb-9756-679ed72967a4.mov

At the same time, I am also proposing adding self.itemContainerView.transform = CGAffineTransform.identity before setting frame. This enables us to clear off the transform from dismiss(), if we are re-using this CustomizableActionSheet

Thank you very much.

Hi,

I can understand why ActionSheetItemView is required throughout the code.

With ActionSheetItemView, this enables us to perform itemContainerView.addSubview, even before we initialise itemContainerView.frame.

I was wondering, is it possible that we can eliminate the usage of ActionSheetItemView. The reasons are

1. Less code, less chance of having bug
2. Eliminate an extra layer (ActionSheetItemView layer), will improve execution speed

I post proof of concept in the code patch. The only thing I am not sure is, after removing ActionSheetItemView, do we still need to perform view.clipsToBounds = true at line 157?

Thank you for paying attention to this. If you need any further clarification, I am happy to answer.

Thanks.

Hey there, I've made some changes for my own purposes that might be of interest in the main project.

1. Made it more obj-c friendly by adding @objc access to various customisable properties.
2. Buttons on the action sheet now automatically highlight on touch.
3. Item interval spacing is customisable per action sheet.
4. You can define a default font for the whole CustomizableActionSheetItem class to set app-wide font settings simply.