Hi there, I just fixed #45 with this pull request.

All tests passing, after two fixes:

1. Cache burst param was not in the expectations for the URL test
2. As I said in #51, the toShort test suite fails due to the new flags. I did a workaround to test my code but didn't pushed it.

Performance enhancement can be checked in this JSPerf: http://jsperf.com/emojione-replacement-speed-test/3

The previous algorithm was O(c), where c is constant but large c: Emoji's list size (~1K). The new algorithm is O(n), but with n: Number of emojis in the string. So, worst case scenario is replacing a string with more than 1K emojis.

PS: I don't know how to generate the minified JS file, sorry.

Hi, thank you for great package I'm using emojione in my Meteor project. it works great. But some emoji don't work. such as :spy: or :eye: . Could you tell me why ? Maybe the Meteor version is not the newest ?

when using from emojione-android.ttf in app , when writing number , show number like emoji !!!

i write "1" but show this number like emoji . how fix it?

Hello,

on the Emoji One homepage you are saying:

http://emojione.com/

[...] But wait, there's more! 😯 Within the coming months, we'll release the newest emoji additions (which unicode announced in June, around 250 in all) including the ever-adorable middle finger. [...]

But they are still missing.

Could you please add the new Unicode Emojis to Emoji One?

And is there already an ETA for this?

Regards

Hey!

https://github.com/Ranks/emojione/blob/master/assets/fonts/README.md

sing these fonts with Firefox or Microsoft Edge, you can enjoy full-color EmojiOne emoji

but why it's not working with Chrome?

Chromium v.56

Firefox v.52

Looks like I find a possible related comment:

refs https://github.com/eosrei/emojione-color-font/issues/57

Maybe someone of creator can regenerate fonts with CBDT (or similar thing that supported in Chrome)?

cC @caseyahenson @miguelsousa @thinkrick @mikebe11 @eosrei

Thanks

At least these ones:

Heavy Exclamation Mark Symbol: ❗ White Smiling Face: ☺️ White Frowning Face: ☹

UPD: there are more. Too lazy to make links: ✌ Victory Hand, 🖐 Raised Hand With Fingers Splayed, ✍ Writing Hand, ☝ Index Pointing Up, 🗻 Mount Fuji, 🏕 Camping, 🏖 Beach With Umbrella, 🏜 Desert, 🏝 Desert Island, 🏞 National Park, 🏟 Stadium, 🏛 Classical Building, 🏗 Building Construction, 🏘 House, 🏙 Cityscape, 🏚 Derelict House, and many more.

v. 2.x:

v. 3.0.1:

The fonts at: https://github.com/Ranks/emojione/tree/master/assets/fonts don't seem to have any ways to reproduce them from the original sources.

(or I can't find them)

There are missing fill colors on three paths in: https://github.com/Ranks/emojione/blob/6a17f05781837b5379a4c02e81c674c47b199cce/assets/svg/1f43f.svg

The paths are identified in Inkscape as path42, path26 and path6. I assume they should be set to #000000.

Causes https://github.com/eosrei/emojione-color-font/issues/21

Hi,

font/README.md mentions upcoming Linux fonts. What is the plan for these, which format is considered?

I’m quite interested in getting full colour Emoji working on Linux, Emoji One would be a great choice as a default set in distributions, and I’m wondering how this could work.

Twemoji's filenames are lowercase without leading zeroes, e.g. 23-20e3.png gemoji's filenames are lowercase with leading zeroes, e.g. 0023-20e3.png Emoji One's filenames are uppercase with leading zeroes, e.g. 0023-20E3.svg

If you use new URLs for the next major version I think it would make sense to normalize the filenames to lowercase, to be somewhat compatible with Twemoji and gemoji. I think that dropping the leading zeroes would be nice too. With identical filenames (basenames) the difference between a Twemoji image and an Emoji One image would only be in the path to the file and it would make it a bit easier for an application to support both sets.

That's only if the next version comes with new URLs though. Otherwise I'm not sure this is worth the hassle.

Hello :bowtie:

This branch contains an alternative PHP algorithm for replacing strings. Instead of frontloading hundreds of replacements via str_replace, it matches every Emoji or smileys at once with a regular expression and replaces them with a callback. The performance increases tenfold to a hundredfold (hence the branch name) depending on the method called and input provided. Demo 4 with its default input goes from ~4ms to ~60µs on my machine.

A note about those regexps: I wrote $unicodeRegexp by hand. It more-or-less matches the Unicode blocks used in Emojione. The callback filters out false positives. $asciiRegexp was generated programmatically with the help of this class, using the following script:

include '/s9e/TextFormatter/src/autoloader.php';
include '/s9e/emojione/lib/php/Emojione.class.php';

$regexp = s9e\TextFormatter\Configurator\Helpers\RegexpBuilder::fromList(
    array_keys(Emojione::$ascii_replace),
    ['delimiter' => '`', 'caseInsensitive' => true]
);
$regexp = '`(?<!\\S)' . $regexp  .'(?=\\s|$|[!,\.])`Si';

echo var_export($regexp, true), "\n";

I chose to complete the emoticon by passing the method $('#content'). Data("emojioneArea"). getText() gets the content, but the actual expression is not correct.

An error occurred when I inserted the data table.

Please Help me, Thank you

Example picture:

I've Xiaomi Mi 9 with Android I would change to Emojione but when I install ttf for Android, the number character (0,1,2,3...) Change to orange emoji. It's for that, I want fusion with Emojione and another police to text. Who can I do? (Sorry to my bad English, I'm French)

I've been using emojione since v3 on my Android phone in different ways. From renaming and replacing the font in system/fonts to using the Magisk module and it's worked every time for the tens of times I've done it. But with v4.5 it doesn't work on Android 5 in any ways and all I see is black simple ones from the phone fonts itself. I've tried both the replacing way and Magisk module but it's not working. Surprisingly it works with no problem when I do it on Android 7.1.2 LineageOS custom rom. I contacted Emojione support team and they advised me to submit my issue here and also to ask for help from @maximbaz in this case Thanks

When I use the iOS font within my app (after changing the font family name as referenced in #363 to make it work), number characters are incorrectly mapped to emoji characters corresponding to the numbers, so instead of 1, 2, 3, etc... the font renders: 1️⃣2️⃣3️⃣

This is difficult to work around and the font should not convert plaintext numbers to their emoji equivalents.

Why is this change needed?

Emojione does not replace emojis that are inside an <object> or <span> tag. This can be problematic in some scenarios. In our case this is problematic when processing content generated by an editor (TinyMCE), since the editor generates spans to format text.

I don't understand the reasons for avoiding the content inside these tags, but in our case removing them does not cause any problem and solve these issues.

What's the change

The change makes the part of the regexes that match HTML configurable, so that by default it keeps the same behaviour but, if wanted, a new regex can be provided. In our case, the same regex without the part.

The ugly part is that when the HTML regex is changed, the other regexes need to be recomputed, that's why I added the computeRegexes method, so you would use it like:

emojione.htmlRegexp = "<object[^>]*>.*?</object>|<(?:object|embed|svg|img|div|span|p|a)[^>]*>";
emojione.computeRegexes();

Making this more clean would require moving all the regexes inside methods and that's a bigger change.

The change allows to fix https://github.com/emojione/emojione/issues/537