It works great in the simulator but when ran on my phone it crashes. I'm running ios 8.1.1 on a 5s. To be sure it was not my implementation, I used your code sample to test.

So the problem on my end is that when I tested the example on iPhone 5, iOS 8.3 the scrolling, between the images, was not smooth at all. In iMessage is very smooth.

Thank you!

Hey,

For swift 2.3, it's working but not support pod with 8.0

[!] Unable to satisfy the following requirements:

- `ImagePickerSheetController (~> 0.9.3)` required by `Podfile`

Specs satisfying the `ImagePickerSheetController (~> 0.9.3)` dependency were found, but they required a higher minimum deployment target.

i'm sad :( Thanks

When the user takes a photo manually, the didFinishPickingWithOptions (or something really similar) method gets called so you can get the image from there. This also works when manually selecting from Photo Library. The problem I'm encountering it when using the slider to pick an image and click send, I can't get the image file. I can use controller.selectedImageAssets but it's a [phasset] file.

How am I actually able to get a UIImage from the slider? I'm using the example code.

Thanks for your help, really like the layout of the custom picker!

I'm trying to integrate IPSC with carthage. However the building process of IPSC involves all testing stuffs including Nimble/Quick/KIF and fails eventually when trying to build Quick. I suppose apps link against IPSC should not rely on its unit tests.

2015-03-16 01:16:38.893 Example[1186:217454] Could not obtain unique identifier for attached screen <UIScreen: 0x1755fd90; bounds = {{0, 0}, {768, 576}}; mode = <UIScreenMode: 0x17662db0; size = 720.000000 x 576.000000; pixel aspect ratio = 1.092593>>

If an image is already selected when a user taps 'Take Photo', it will skip to the secondary action because the numberOfSelectedImages is already > 0, and the photo is added, rather than presenting the camera UI as expected.

Note that the example app avoids this scenario, because the 'Take Photo' action is no longer available once a photo is selected.

This PR adds the ability for an action to reset the selected images, allowing the 'Take Photo' action to work as expected.

I installed iOS 9 on an iPhone 6 and the library is don't working anymore. Indeed if you tab on any pictures inside the collection view to select one it crashes with the following error :

2015-06-09 23:05:04.010 barter[592:608643] *** Assertion failure in -[UICollectionViewData validateLayoutInRect:], /BuildRoot/Library/Caches/com.apple.xbs/Sources/UIKit/UIKit-3473.13/UICollectionViewData.m:408
2015-06-09 23:05:04.015 barter[592:608643] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'layout attributes for supplementary item at index path (<NSIndexPath: 0xc000000000000016> {length = 2, path = 0 - 0}) changed from <UICollectionViewLayoutAttributes: 0x135b39780> index path: (<NSIndexPath: 0xc000000000000016> {length = 2, path = 0 - 0}); element kind: (UICollectionElementKindSectionHeader); frame = (73 5; 29 130); hidden = YES; zIndex = 1;  to <UICollectionViewLayoutAttributes: 0x135c32f00> index path: (<NSIndexPath: 0xc000000000000016> {length = 2, path = 0 - 0}); element kind: (UICollectionElementKindSectionHeader); frame = (73 5; 29 233); hidden = YES; zIndex = 1;  without invalidating the layout'
*** First throw call stack:

However I fixed the issue in the didSelectItemAtIndexPath method of the library more precisely inside the animateWithDuration block by adding * layout.showsSupplementaryViews = true* between the tableview updates methods.

                self.setNeedsLayout()
                UIView.animateWithDuration(enlargementAnimationDuration, animations: {
                    self.tableView.beginUpdates()
                    layout.showsSupplementaryViews = true
                    self.tableView.endUpdates()
                    self.layoutIfNeeded()
                    }, completion: { finished in
                        self.reloadButtonTitles()
                        layout.showsSupplementaryViews = true
                        self.delegate?.imagePickerSheetDidEnlargePreviews?(self)
                })

It is maybe not a real fix because ios9 is under beta. Moreover the fixe appears to make the collectionview scrolling at the beginning so the selected picture will not be at the center of the collection view. But it can still help someone who is facing the same issue.

Hello @larcus94,

ImagePickerSheet is cool. Though it's missing a way of determining how many items can be selected. My application should allow single selection so I added a little code to support that feature.

Maybe you find it useful as well.

Regards, Eugene

I did a bit of debugging and it seems that in the handle() method of ImagePickerAction the numberOfImages variable is zero despite clicking the Use Photo button on the camera.

If i had more time on hand, I'd probably send a PR but this seems like a trivial fix and the author could probably fix is faster than I could.

Thanks

Swift sytanx used throughout the project causes compiler issues while running Xcode 8.0 beta 2. Issues range from use of renamed objects (NSPredicate has been renamed to Predicate) to simple syntax changes.

Branch: fix-maximum-selection IOS: 11

Currently I faced the problem that the first button in the action-sheet is somehow animated with a scale transition if you present the ImagePickerSheetController which looks really weird.

This is my code which is from the example code:

let presentImagePickerController: (UIImagePickerControllerSourceType) -> () = { source in
    let controller = UIImagePickerController()
    controller.delegate = self
    var sourceType = source
    if (!UIImagePickerController.isSourceTypeAvailable(sourceType)) {
        sourceType = .photoLibrary
    }
    controller.sourceType = sourceType
    
    self.present(controller, animated: true, completion: nil)
}

let controller = ImagePickerSheetController(mediaType: .image)
controller.maximumSelection = 1
controller.addAction(ImagePickerAction(title: "Photo Library", secondaryTitle: "Add Selection", handler: { _ in
    presentImagePickerController(.photoLibrary)
}, secondaryHandler: { _, numberOfPhotos in

}))

controller.addAction(ImagePickerAction(title: "Take Photo", handler: { _ in
    presentImagePickerController(.camera)
}, secondaryHandler: { _, numberOfPhotos in
    presentImagePickerController(.camera)
}))

controller.addAction(ImagePickerAction(cancelTitle: "Cancel"))

present(controller, animated: false, completion: nil)

As you can see I set animated to false cause this seems like the only solution for me. Does someone else have the problem or a solution for it?

I present ImagePickerSheetController with animation set to true, but what happens instead is I see perhaps the last frame of an animation in. The background color fades in, but the picker itself basically just appears.

Hello Laurin - great library you have here, thanks for sharing it. Love the animations and general structure of the code (I'm at the tip of the fix-maximum-selection branch). Just had something of a basic question about the intent/purpose of the two ImagePickerAction rows once at least one image has been selected.

From what I can seem to see, both actions will fire the same handler, though we can have separate titles for them. The example usage refers to "Add Comment" which may well be useful, keeping in mind it would apply to N photos.

In order of importance to me, I'd love to either:

1. Hide/remove that first ImagePickerAction if and only if > 0 images have been selected, or
2. Alter the handler that fires for that first row (so I could pop a modal text field to ask for comments, say). Not sure how I'd know when that happened though, nor can I currently get to the handler: Handler? instance member as it's both fileprivate and a let to boot.

Thanks in advance for your (or anyone else's) thoughts.

In Apple's document, " You access the contents of a fetch result with the same methods and conventions used by the NSArray class. Unlike an NSArray object, however, a PHFetchResult object dynamically loads its contents from the Photos library as needed, providing optimal performance even when handling a large number of results" in PHFetchResult. The method to improve performance is require Image in collectionView:CellForItem method

@lbrndnr Are you able to get specs to run easily? I had to do a ton of work to get them going.

1. Looks like you prefer Carthage, which is 💯 but I'm "old school" and still use Pods, so I added KIF and Quick&Nimble via a Podfile. So that involved using a workspace and changing IPSC.xcodeproj/project.pbproj to be compatible
2. Exposed waitForViewWithAccessibilityIdentifier (and friends) in KIFExtensions.swift. Looks like you used to maintain a fork of KIF, but it's been deleted? These methods are not available in KIF v 3.4.2 (latest)
3. On the upside, it would be easy to get Travis-CI running, I've used it w/ Pods enough to be able to get that going.

Thoughts on all this? Feels like I must be doing something wrong...