Hi Alex,

Just let me say this first... very awesome library, saved me a ton of time. Thank you for making this and sharing this. Using Kingfisher loader too.

One quick question I have, is there an easy way to hide the share icon? I didn't see some option when I looked around.

Thank you,

Chris

Its not working for me. It loses count on swipe and then crashes. For example, when i swipe to the final photo, and then try and swipe for one more, the count goes down and it loses track of the count, and then, ultimately, swiping through more of the photos, it crashes.

I have in my podfile: pod 'AXPhotoViewer' pod 'AXPhotoViewer/Nuke'

And then in my source: import AXPhotoViewer import Nuke .... let integration = NukeIntegration()

I get undeclared identifier for NukeIntegration

What am I missing here? Thanks in advance.

Hi, There is a small fix in fileprivate func updateOverlay(for photoIndex: Int)

517 self.overlayView.internalTitle = NSLocalizedString("(photoIndex + 1) of (self.dataSource.numberOfPhotos)", comment: "")

It must be somelike ...

self.overlayView.internalTitle = "(photoIndex + 1) " + NSLocalizedString("of", comment:"") + " (self.dataSource.numberOfPhotos)"

... to get easy localized version. Or you can use String.localizedStringWithFormat to cover some difficult cases like Arabic language and so on.

Would it be straightforward to walk the minimum iOS version back to 8.0? For this and for AXStateButton? I've got an application in mind that could use a cool image gallery like this but I'd like to target iOS 8 as well.

I was trying to override the actionBarButtonItem and closeBarButtonItem (just for the look and feel) via subclassing the PhotosViewController. The Swift compiler have this warning "Overriding non-open var outside of its defining module". To get this working, I have to change the method declaration from public to open. I wonder if this the only option for just changing the look and feel.

Is there a built in functionality to reload an updated model? For example we currently let user update the caption. However, I don't see a way to reload a photoAtIndexPath?

Also is there a way to delete an item out of datasource?

1.5.0 worked fine. 1.6.1 gives 17 errors.

Environment

• swift 4.0
• target iOS 10.0

I guess I need to update to swift 4.2 too. Thanks for your effort on this amazing photo viewer.

Hi,

I want to know if there's a way to know when the PhotoViewerController did finish dismiss (by both close button and interactive animation) ?

Thank you,

Lib version: AXPhotoViewer (1.3.6) AXStateButton (1.1.4)

crash at line 226 at file AXPhotosTransitionController

photosViewController.currentPhotoViewController at the moment of dismiss have nil value,

guard let imageView = photosViewController.currentPhotoViewController?.zoomingImageView.imageView as UIImageView? else { assertionFailure("No. ಠ_ಠ") return }

P.S. It so funny and so "professional" have this smiles instead description text inside crash log?

To insert an image of an asset, do the following:

for i in 0 ..< images.count - 1 { manager.requestImage(for: images[i], targetSize: CGSize(width: 100, height: 100.0), contentMode: .aspectFill, options: nil) { (result, _) in print(result) let resultphoto = Photo(image: result, url: nil) self.photos.append(resultphoto)
}

I have obviously put nil in the url, but I keep trying to download it. The image is imported from the asset.

   self.urlSession.dataTask(with: self.photos[indexPath.row].url!) { [weak self] (data, response, error) in
        guard let uData = data else {
            return
        }   

I get an error here.

Hello @justindhill! You wrote that you still come here from time to time to maintain the repository. This is a wonderful and simple library with many ready-to-go integrations that we are to this day using in our app.

We want to optimise our pod installation process: at the times of Xcode 10 we had to add :disable_input_output_paths => true to Podfile to mitigate CocoaPods/CocoaPods#8122. These days we found that every other pod moved to using resources_bundle except this one. I wrote a simple PR ( #81 ) to fix this. It would be cool if you could merge it and add version 1.7.2 tag to the master branch.

Thank you in advance!

This fixes build errors on new build system. Currently only this pod in our app is using resources rather than resources_bundle. These changes will allow us to remove :disable_input_output_paths => true from Podfile. See this issue - https://github.com/CocoaPods/CocoaPods/issues/8122

I used this pod 2 years ago, and now that I'm looking for a photo viewer again, I stumbled upon this repo. Thanks Alex for making this project! Indeed your love for iOS engineering will always be remembered.

Glenn

Close #78

If our library was installed via CocoaPods, Xcode 11.4 will issue the warning "MobileCoreServices has been renamed. Use CoreServices instead.".

How to fix: Do not explicitly link MobileCoreServices.framework in the CocoaPods generated project, by deleting MobileCoreServices from the spec.frameworks attribute in our podspec file.

More info: https://github.com/AFNetworking/AFNetworking/pull/4532