https://github.com/mattt/Ono/commit/002d2f2a80ad9ca1eded9f8ac894b2c69437dd39 Fixed a bug in XPathFromCSS that mistakenly matches the CSS string rather than token string, test case added for this bug.

https://github.com/mattt/Ono/commit/94f30a52239bd578cdf01814140e8c9fb954549a Added explicit type cast to fix compilation error for test in Xcode 7 beta, where NSArray returns ObjectType element rather than id. This will not affect previous versions of Xcode. Please refer to 'Objective-C Language Features' in http://adcdownload.apple.com/Developer_Tools/Xcode_7_beta_4/Xcode_7_beta_4_Release_Notes.pdf

Tests/ONOHTMLTests.m file

- (void)testRootElementChildren {
    NSArray *children = [self.document.rootElement children];
    XCTAssertNotNil(children, @"children should not be nil");
    XCTAssertTrue([children count] == 2, @"root element has more than two children");
    XCTAssertEqualObjects([[children firstObject] tag], @"head", @"head not first child of html");
    XCTAssertEqualObjects([[children lastObject] tag], @"body", @"body not last child of html");
}

The last two line of that method occurs following error :

"Multiple methods named 'tag' found with mismatched result, parameter type or attributes..."

Is there any way to fix this? Please help me. Thanks.

Hello Matt,

Are you going to implement this library natively on Swift?

I use this library in Swift project and there're several common Swift to Objective-C inconveniences, e.g.

for object in element.childrenWithTag("td") {
   let child = object as! ONOXMLElement
   ...
}

NSFastEnumeration cannot be used in for-in directly

- (id <NSFastEnumeration>)CSS:(NSString *)CSS;

most methods return ImplicitlyUnwrappedOptional

I can update the code base at least to use Objective-C Nullability.

Please comment.

Hi,

I’ve had problems with CocoaPods before, so liking the look of the more straight forward Carthage. I was wondering if I had to do anything special to get Ono working with Carthage.

I get the error: Project "Ono.xcodeproj" has no shared schemes

I will try building Ono manually and adding that to my Xcode project. Thanks.

a3211b847c3b4c480fb54e0c5b9ec2e3017e269d (context in #20) introduces a fix for a mysterious bug in libxml2 which prevents XML namespaces from being properly populated on xmlNodePtr objects, by using ->nsDef instead of ->ns.

However, namespace definition (->nsDef) info is only available on the node in which the namespace definitions appear (as an XML attribute). This mean that XPath expressions cannot be used on descendant nodes that do not feature the namespace definitions. Put another way, using ->nsDef results in namespaces not being "inherited" by child nodes.

Until the libxml2 bug is fixed (and Apple incorporates the fixed libxml2 into their developer tools distribution), one way to use an XPath expression from a descendant of a node on which an XML namespace has been defined is to walk up the ancestor hierarchy and harvest all of the namespace definitions.

Hello (again!)

I noticed that any XPath queries containing namespaces //ns1:tagname would fail with the error:

XPath error : Undefined namespace prefix
XPath error : Invalid expression

I've added a test case for this issue and the Travis build file to ensure the tests on my fork pass :) https://travis-ci.org/rhodgkins/Ono/builds/26876794

all of these individual warnings come up when compiling ONOXMLDocument.m with -Weverything

-Wshadow -Wsign-conversion -Wfloat-conversion -Wconversion -Wnullable-to-nonnull-conversion -Wcast-qual

Thanks for the very helpful library! While using this with HTML, I found some CSS selector queries don't work. For example, when I tried to find elements under a specific element with a query like "#price .a-color-price", it generates the error below:

XPath error : Invalid expression .//[@id = 'price']/descendant::[@id = 'a-col']*[contains(concat(' ',normalize-space(@class),' '),' a-color-price ')]

Can you please fix this error if I'm not using CSS selector in a wrong way?

I'm working on a pod called Spectra that uses Ono 1.2.2 to parse XML for a scene graph and some other things.

I upgraded to XCode 7.1 yesterday and i haven't been able to resolve this build error at all. I've found a lot of people online asking about this, but for the most part, they're not resolving this issue for a pod their building. So many of the solutions i've found don't work for me.

include of non-modular header inside framework module Ono.Ono

I've found that by changing the following line in ono.h resolve the Ono build issues for me.

// changed from this
#import <Ono/ONOXMLDocument.h>

// to this
#import "ONOXMLDocument.h"

- (NSDictionary *)attributes {
    if (!_attributes) {
        NSMutableDictionary *mutableAttributes = [NSMutableDictionary dictionary];
        for (xmlAttrPtr attribute = self.xmlNode->properties; attribute != NULL; attribute = attribute->next) {
            NSString *key = @((const char *)attribute->name);
            // valueForAttribute is nil for 'description'
            [mutableAttributes setObject:[self valueForAttribute:key] forKey:key];
        }

        self.attributes = [NSDictionary dictionaryWithDictionary:mutableAttributes];
    }

    return _attributes;
}

Sample:

<outline text="BBC Persian" description="&lt;div style=&quot;direction:rtl;text-align:right&quot;&gt;&#x627;&#x6CC;&#x646; &#x635;&#x641;&#x62D;&#x647; &#x62F;&#x6CC;&#x6AF;&#x631; &#x628;&#x647; &#x631;&#x648;&#x62E;.." htmlUrl="http://www.bbc.co.uk/blogs/persian/editors/" xmlUrl="http://www.bbc.co.uk/blogs/persian/editors/rss.xml" subscribe="false" content_type="text/xml" site_icon="http://www.bbc.co.uk/favicon.ico"/>

See #21.

Hopefully if the issue can be fixed these test cases can be used to help! I've created an issue and a pull request separately as this pull request does not fix the issue just shows it.

When I use #import "Ono.h" in .mmfile ,it raises error below

Use of '@import' when C++ modules are disabled, consider using -fmodules and -fcxx-modules

but I change @import Foundation; with #import <Foundation/Foundation.h> in Ono.h ,it's fine

-(NSArray *)childrenAtIndexes:(NSIndexSet *)indexes {

NSMutableArray *mutableChildren = [NSMutableArray array]; 
xmlNodePtr cursor = self.xmlNode->children;
NSUInteger idx = 0;
while (cursor) {
    if ([indexes containsIndex:idx] && cursor->type == XML_ELEMENT_NODE) {
        [mutableChildren addObject:[self.document elementWithNode:cursor]];
    }

    cursor = cursor->next;
    idx++;
}
return [NSArray arrayWithArray:mutableChildren];

}

According to the above code I get child node must be element nodes, but also I think text node's child nodes. Namely： if ([indexes containsIndex:idx] && (cursor->type == XML_ELEMENT_NODE || cursor->type == XML_TEXT_NODE)) { [mutableChildren addObject:[self.document elementWithNode:cursor]]; }

I would like to have a method similar to stringValue which doesn't recursively prints everything under a certain XPathQuery. Here is the full code + HTML and the produced output by Ono plus which output I'd like to have.

My XPath Query: XPathQuery: //div[@class='thread']

Ono code:

document = [ONOXMLDocument HTMLDocumentWithData:file error:&error];

[document enumerateElementsWithXPath:xPath usingBlock:^(ONOXMLElement *element, NSUInteger idx, BOOL *stop) {
    NSLog(@"%@", [element stringValue]);
}];

Which prints:

FirstName LastName, SecondNameFirst SecondNameLast


                FirstName LastName
                Wednesday, December 24, 2014 at 6:57pm UTC+01 


        This is a dummy text


                SecondNameFirst SecondNameLast
                Wednesday, December 24, 2014 at 6:56pm UTC+01


        And a 2nd one just to show off


Another, User


                Another
                Monday, April 27, 2015 at 10:54pm UTC+02


        Text: 2.1


                User
                Thursday, February 26, 2015 at 5:41pm UTC+01


        Text: 2.2


                Another
                Thursday, February 26, 2015 at 4:25pm UTC+01


        Text: 2.3

I would prefer to have an output similar to hpple which is:

FirstName LastName, SecondNameFirst SecondNameLast
Another, User

hpple code:

tutorialsParser = [TFHpple hppleWithHTMLData:file];
tutorialsNodes = [tutorialsParser searchWithXPathQuery:xPath];

for (TFHppleElement *element in tutorialsNodes) {
    NSLog(@"%@", [[element firstChild] content].trim);
}

And I don't want to use hpple since it is too slow.

Here is my input HTML file:

<!DOCTYPE html>
<html>
<head><title/></head>
<body>
    <div class="thread">FirstName LastName, SecondNameFirst SecondNameLast
        <div class="message">
            <div class="message_header">
                <span class="user">FirstName LastName</span>
                <span class="meta">Wednesday, December 24, 2014 at 6:57pm UTC+01 </span>
            </div>
        </div>
        <p>This is a dummy text</p>
        <div class="message">
            <div class="message_header">
                <span class="user">SecondNameFirst SecondNameLast</span>
                <span class="meta">Wednesday, December 24, 2014 at 6:56pm UTC+01</span>
            </div>
        </div>
        <p>And a 2nd one just to show off</p>
    </div>
    <div class="thread">Another, User
        <div class="message">
            <div class="message_header">
                <span class="user">Another</span>
                <span class="meta">Monday, April 27, 2015 at 10:54pm UTC+02</span>
            </div>
        </div>
        <p>Text: 2.1</p>
        <div class="message">
            <div class="message_header">
                <span class="user">User</span>
                <span class="meta">Thursday, February 26, 2015 at 5:41pm UTC+01</span>
            </div>
        </div>
        <p>Text: 2.2</p>
        <div class="message">
            <div class="message_header">
                <span class="user">Another</span>
                <span class="meta">Thursday, February 26, 2015 at 4:25pm UTC+01</span>
            </div>
        </div>
        <p>Text: 2.3</p>
    </div>
</body>
</html>

For the following XML document(SOAP service), XPath can't find the elements.

<?xml version="1.0" encoding="UTF-8"?>
<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
    <soapenv:Body>
        <ServiceResponse xmlns="http://sub.domain.com">
            <ServiceReturn>
                <a>US</a>
                <b>
                    <b>
                        <e>Herrod</e>
                        <f>[email protected]</f>
                        <g>Et Commodo LLC</g>
                        <i>07/14/2014</i>
                    </b>
                    <b>
                        <e>Armand</e>
                        <f>[email protected]</f>
                        <g>Vel Convallis In Consulting</g>
                        <i>04/18/2015</i>
                    </b>
                    <b>
                        <e>Bernard</e>
                        <f>[email protected]</f>
                        <g>Cursus Nunc Mauris PC</g>
                        <i>11/12/2015</i>
                    </b>
                    <b>
                        <e>Dante</e>
                        <f>[email protected]</f>
                        <g>Sit Amet Ltd</g>
                        <i>01/19/2016</i>
                    </b>
                </b>
                <c>0</c>
                <k>12345678</k>
            </ServiceReturn>
        </ServiceResponse>
    </soapenv:Body>
</soapenv:Envelope>

Here are the result of some functions

document.rootElement.firstChildWithTag("Body", inNamespace: "soapenv") //some
document.rootElement.firstChildWithTag("//soapenv:Body/ServiceResponse") //nil
document.rootElement.firstChildWithTag("//Body//b", inNamespace: "soapenv") //nil
document.firstChildWithXPath("//ServiceResponse") //nil
document.firstChildWithXPath("//ServiceReturn") //nil
document.firstChildWithXPath("//*/ServiceReturn/b/b") //nil
document.firstChildWithXPath("//ServiceReturn/b/b") //nil
document.firstChildWithXPath("//b/b") //nil

Another example

<?xml version="1.0" encoding="UTF-8"?>
<S:Envelope xmlns:S="http://schemas.xmlsoap.org/soap/envelope/">
   <S:Body>
      <ns2:OperationHistoryData xmlns:ns2="http://www.domain.org/operation" xmlns:ns3="http://www.domain.org/info" xmlns:ns5="http://www.domain.org/data">
         <ns2:historyRecord>
            <ns2:DestinationAddress>
               <ns2:Index>190000</ns2:Index>
               <ns2:Description>Info 1</ns2:Description>
            </ns2:DestinationAddress>
         </ns2:historyRecord>
      </ns2:OperationHistoryData>
   </S:Body>
</S:Envelope>

Whenever there is nested namespaces, ono can't parse it. I don't know maybe it is limitation of libxml. Only workaround I found is to strip name spaces and other attributes.