Hi, first i really thanks you for the library, it help me alot.

I have using your library to reading subtitles in my video player, it's works fine, subtitle is showing when i watching video but it blinking in 2 positions. May you want to watching clip for more detail.

https://www.dropbox.com/s/op2z83nyagfu2t0/Video%20Nov%2013%2C%2014%2002%2050.mov?dl=0

I have running your example code and it has the same issue.

Hi @mhergon ,

I am facing some issue during parsing two files. https://dl.dropboxusercontent.com/u/32254461/Subtitles/English.srt [Successfully Parsing] https://dl.dropboxusercontent.com/u/32254461/Subtitles/Espanish.srt [Failed to Parse]

Both files structure is same. You can view it by tapping on links.

Code is breaking on these lines: NSString *textString; [scanner scanUpToString:@"\r\n\r\n" intoString:&textString]; textString = [textString stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceCharacterSet]];

"textString" is returning whole file data at once in case of some files. These are just sample files; Its also breaking for many English and Espanish files.

Please look into the issue; If i am doing something wrong then please let me know.

Thanks, Shafqat

Hi mhergon, i was so happy to implement your subtitle class into my app. but. it turns out it crashes on iOS 6.1 i get an bad exec when i start a movie, stop it, then play it again. its the same in your example. any idea?

I try use online video, the link is http://jplayer.org/video/m4v/Big_Buck_Bunny_Trailer.m4v My code as follows, let moviePlayerView = MPMoviePlayerViewController(contentURL: NSURL(string: "http://jplayer.org/video/m4v/Big_Buck_Bunny_Trailer.m4v"))

It doesn't work. Can it support online video?

thx for this great lib but i think there is an issue, asynchronous between sound and video after while,what i mean that there is no match between sound and the scene after a while and this issue appears only if there is subtitle. thx in advance

Hello mhergon,

First of all great job you have done with this library

Can you please provide update in Objective c and suggest me to a way for use .plist file instead of .srt file

When video haven't display if you rotate screen your app will crash. Because this code

• (void)updateLabelConstraints {

  // Default NSString *horizontal = @"H:|-(15)-[weakSubtitleLabel]-(15)-|"; NSString *vertical = @"V:[weakSubtitleLabel]-(15)-|";

  UIView __weak *weakSubtitleLabel = self.subtitleLabel; // Crash because weakSubtitleLable = nil NSDictionary *views = NSDictionaryOfVariableBindings(weakSubtitleLabel); NSArray *constraints = [NSLayoutConstraint constraintsWithVisualFormat:horizontal options:0 metrics:nil views:views]; [self.subtitleLabel.superview addConstraints:constraints]; constraints = [NSLayoutConstraint constraintsWithVisualFormat:vertical options:0 metrics:nil views:views]; [self.subtitleLabel.superview addConstraints:constraints];

  CGRect bounds = [self.subtitleLabel.text boundingRectWithSize:CGSizeMake(CGRectGetWidth(self.subtitleLabel.bounds), CGFLOAT_MAX)
                                                        options:NSStringDrawingUsesLineFragmentOrigin
                                                     attributes:@{NSFontAttributeName : self.subtitleLabel.font}
                                                        context:nil];
  self.heightConstraint.constant = bounds.size.height + 10.0;
  
  [self.subtitleLabel.superview layoutIfNeeded];
  

  }

---- So I change a little in this code

• (void)updateLabelConstraints {

  // Default NSString *horizontal = @"H:|-(15)-[weakSubtitleLabel]-(15)-|"; NSString *vertical = @"V:[weakSubtitleLabel]-(15)-|";

  UIView *weak weakSubtitleLabel = self.subtitleLabel; __if (weakSubtitleLabel) { NSDictionary *views = NSDictionaryOfVariableBindings(weakSubtitleLabel); NSArray *constraints = [NSLayoutConstraint constraintsWithVisualFormat:horizontal options:0 metrics:nil views:views]; [self.subtitleLabel.superview addConstraints:constraints]; constraints = [NSLayoutConstraint constraintsWithVisualFormat:vertical options:0 metrics:nil views:views]; [self.subtitleLabel.superview addConstraints:constraints];

  CGRect bounds = [self.subtitleLabel.text boundingRectWithSize:CGSizeMake(CGRectGetWidth(self.subtitleLabel.bounds), CGFLOAT_MAX)
                                                        options:NSStringDrawingUsesLineFragmentOrigin
                                                     attributes:@{NSFontAttributeName : self.subtitleLabel.font}
                                                        context:nil];
  self.heightConstraint.constant = bounds.size.height + 10.0;
  
  [self.subtitleLabel.superview layoutIfNeeded];
  

  } }

Hi I am trying to port this code to work with AVPlayerViewController with below minimal changes.

// Video file let videoFile = NSBundle.mainBundle().pathForResource("trailer_720p", ofType: "mov")

    // Subtitle file
    let subtitleFile = NSBundle.mainBundle().pathForResource("trailer_720p", ofType: "srt")
    let subtitleURL = NSURL(fileURLWithPath: subtitleFile!)
    // Using AVPLAyerViewController
    let moviePlayerViewAV = AVPlayerViewController()
    moviePlayerViewAV.player = AVPlayer(URL: NSURL(fileURLWithPath: videoFile!))
    moviePlayerViewAV.addSubtitles().open(file: subtitleURL)
    moviePlayerViewAV.addSubtitles().open(file: subtitleURL, encoding: NSUTF8StringEncoding)
    // Change text properties
    moviePlayerViewAV.subtitleLabel?.textColor = UIColor.redColor()
    // Play
    moviePlayerViewAV.player!.play()

And some changes in extension file. Below code is throwing exception "Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Unable to parse constraint format: Unable to interpret '|' character, because the related view doesn't have a superview H:|-(20)-[l]-(20)-| "

subtitleContainer?.translatesAutoresizingMaskIntoConstraints = false subtitleLabel?.translatesAutoresizingMaskIntoConstraints = false var constraints = NSLayoutConstraint.constraintsWithVisualFormat("H:|-(20)-[l]-(20)-|", options: NSLayoutFormatOptions(rawValue: 0), metrics: nil, views: ["l" : subtitleLabel!]) subtitleContainer?.addConstraints(constraints) constraints = NSLayoutConstraint.constraintsWithVisualFormat("V:[l]-(30)-|", options: NSLayoutFormatOptions(rawValue: 0), metrics: nil, views: ["l" : subtitleLabel!])

        subtitleContainer?.addConstraints(constraints)
        subtitleLabelHeightConstraint = NSLayoutConstraint(item: subtitleLabel!, attribute: .Height, relatedBy: .Equal, toItem: nil, attribute: NSLayoutAttribute.NotAnAttribute, multiplier: 1.0, constant: 30.0)

Any help is appreciated.

Missing captions/texts in srt file causes crash

Fixed this issue by add one validation in....

pragma mark - Private methods

• (void)parseString:(NSString *)string parsed:(void (^)(BOOL parsed, NSError *error))completion {

  // Create Scanner NSScanner *scanner = [NSScanner scannerWithString:string];

  // Subtitles parts self.subtitlesParts = [NSMutableDictionary dictionary];

  // Search for members while (!scanner.isAtEnd) {

  // Variables
  NSString *indexString;
  [scanner scanUpToCharactersFromSet:[NSCharacterSet newlineCharacterSet]
                          intoString:&indexString];
  
  NSString *startString;
  [scanner scanUpToString:@" --> " intoString:&startString];
  [scanner scanString:@"-->" intoString:NULL];
  
  NSString *endString;
  [scanner scanUpToCharactersFromSet:[NSCharacterSet newlineCharacterSet]
                          intoString:&endString];
  
  
  
  NSString *textString;
  [scanner scanUpToString:@"\r\n\r\n" intoString:&textString];
  textString = [textString stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceCharacterSet]];
  
  // Regular expression to replace tags
  NSError *error = nil;
  NSRegularExpression *regExp = [NSRegularExpression regularExpressionWithPattern:@"[<|\\{][^>|\\^}]*[>|\\}]"
                                                                          options:NSRegularExpressionCaseInsensitive
                                                                            error:&error];
  if (error) {
      completion(NO, error);
      return;
  }
  

  // if(textString.length>0){

  //Added by Vineeth

  if(!ISEMPTY(textString)){
  
  textString = [regExp stringByReplacingMatchesInString:textString
                                                options:0
                                                  range:NSMakeRange(0, textString.length)
                                           withTemplate:@""];
  
  }else{
  
  
       textString =@"";
  
  }
  
  
  
  
  NSLog(@"textString is:%@",textString);
  
  
  // Temp object
  NSTimeInterval startInterval = [self timeFromString:startString];
  NSTimeInterval endInterval = [self timeFromString:endString];
  NSDictionary *tempInterval = @{
                                 kIndex : indexString,
                                 kStart : @(startInterval),
                                 kEnd : @(endInterval),
                                 kText : textString ? textString : @""
                                 };
  [self.subtitlesParts setObject:tempInterval
                          forKey:indexString];
  

  }

  NSLog(@"subtitlesParts is:%@",self.subtitlesParts);

  completion(YES, nil);

}

Hi, For iOS and macOS projets it's will be great to make your component Carthage compatible

Take a look at these articles:

• Ruthlessly Simple Dependency Management with Carthage
• Carthage Tutorial: Getting Started
• Making Carthage-compatible Frameworks with Swift
• Swift Cross Platform Framework (section Configure targets for Carthage) 👍

On your README.md add on top and add section for the installation with Carthage.

Hello, I got this issue when reading video and its sub: "Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'NSDictionaryOfVariableBindings failed because either one of the values is nil, or there's something wrong with the way the macro is being invoked. Cannot assign value nil for key "weakSubtitleLabel". Keys:( weakSubtitleLabel )'" I created this subtitle by following: [self.item.srtSubtitle writeToFile:srtSubPath atomically:YES encoding:NSUTF8StringEncoding error:&error]; The video and its sub can be downloaded here: https://www.dropbox.com/sh/zgmxujxerydhz9q/AAAlQp7sAMW2_ISJwZ9NO47Xa?dl=0# I've been trying to create the sub with different encoding like: NSUTF8StringEncoding, NSISOLatin1StringEncoding but no luck. Please help me. Thank you.