Bundle.main.version shows the build number with kCFBundleVersionKey when it should show Bundle.main.shortVersion + "-" + Bundle.main.version

Proposing version be renamed to build

Let me know if my project is just wrong but I think my understanding of the keys is correct.

Judging by #14 this used to work with Carthage once upon a time, but currently fails. Would love to see it working again! 😍

Last line of log file:

The following build commands failed: ProcessInfoPlistFile /Users/ianbytchek/Library/Caches/org.carthage.CarthageKit/DerivedData/9.2_9C40b/version/0.6.1/Build/Intermediates.noindex/ArchiveIntermediates/Version/IntermediateBuildFilesPath/UninstalledProducts/macosx/Version.framework/Versions/A/Resources/Info.plist Version/Info.plist

The README suggests that I ought to be able to do

let version : Version = UIDevice.currentDevice().systemVersion

but when I do this, I get the following error: "Cannot convert value of type 'String' to specified type 'Version'".

Googling around, it seems like the code shouldn't be expected to work?

ExpressibleByStringLiteral… is only involved when dealing with literals… you’re dealing with a string value.

Indeed, when I use a literal instead, like

let version : Version = "13.4"

then it does work.

Version("") will crash the device. Shouldn't it be init? instead of init!

Error: Failed to parse version number '': InvalidComponents
Fatal error: Unexpectedly found nil while unwrapping an Optional value
2019-09-11 21:05:13.709726-0400 ec3730[79029:21121642] Fatal error: Unexpectedly found nil while unwrapping an Optional value

I originally wrote a comment about not being sure how to do this because I was coding the string representations. Now the object is being fully and properly coded.

I'm trying to use Version (0.4.0) on Xcode 7.3.1 but when I compile my project it gives me an issue:

Version.swift:271:33: Cannot convert value of type 'Version?' to expected argument type 'String'

Fixes problems described in issue #10.

:zap: CAUTION: This is a breaking change! :bomb:

What I changed/fixed:

1. In order to allow Version to leniently parse invalid (according to semver, at least), yet common versions (and print them back identically to how they were parsed) I added Version.canonicalMinor and Version.canonicalPatch for internal handling.

public var canonicalMinor: Int {
    return self.minor ?? 0
}

1. I extracted the parsing code into a dedicated VersionParser class, which can now be initialized with a strict flag (false being the default). Again, we don't want to break parsing of semi-valid version strings.
2. This is a big one. In order to be a valid semantic version it should ignore build in comparisons. Ignoring build would however lead to unexpected results when comparing “1.0.0+A” and “1.0.0+B”. One would expect these to not be equal. Then again as long as one cannot guarantee a comparable build number (it might be a partial git commit hash, for which sorting makes no sense whatsoever) I therefor removed comparison of build from “func<“, "func==“ and “hashValue” and implemented func=== to re-enable equality checks with build:

public func ===(lhs: Version, rhs: Version) -> Bool {
    return (lhs == rhs) && (lhs.build == rhs.build)
}

1. Fixed.
2. A nil-value in minor or patch now is considered equal to “0”.

I keep getting this crash when comparing semantic versions with your latest CocoaPods release 0.2.0.

Even on the command line it crashes Xcode when doing e.g.:

p NSBundle.mainBundle().shortVersion! < "1.0.0"

Any idea what's going on? I'm using Xcode Version 6.1.1 (6A2008a).

Fix this issue on Linux stack.

remote: /tmp/build_90a63a7a429caba3f86535bd8a819ae1/.build/checkouts/Version/Sources/Version/Version.swift:258:63: error: use of unresolved identifier 'kCFBundleVersionKey'
remote:         return self.versionFromInfoDicitionary(forKey: String(kCFBundleVersionKey))

I upgraded the Hashable implementation, while leaving it backwards-compatible. I deleted all the code for Codable since it's auto-synthesised. Will that make it non-backwards-compatible? 🤔

0.5.0 does not build with Xcode 8. No changes for source needed, just some updates of xcodeproj & build schemes.

Also fixed a build issue cause by incorrect path of Info.plist for Release configuration.

Adjust deployment targets: macOS: 10.9 iOS: 8.0 watchOS: 2.0 tvOS: 9.0

Version 0.7.1 works perfectly, Carthage/Carthage/issues/1763 might be related.

*** Checking out Version at "0.7.2"
Parse error: expected submodule commit SHA in output of task (ls-tree -z 0.7.2 xcconfigs) but encountered: