Getting square objects down round holes

There seem to be some uneccessary rubyisms in the code, most notably method names like each_with_index which should be eachWithIndex or empty which should be isEmpty.

There is more, but due to me typing this on an iPad, i'd rather not list them all out.

Hi, there is a issue of NSArray+rotate when the array.count != 6. Your test array is just a coincidence in unit test.

id rv = @[@1, @2, @3, @4, @5, @6, @7].rotate(-2);

if (pivot < 0) pivot = (int)self.count + pivot; // pivot = 7 - 2 = 5 return self.skip(pivot).concat(self.snip(pivot)); before fix: // self.skip(5) ===> @[@6, @7] // self.snip(5) ===> @[@1, @2] // .concat ===> @[@6, @7, @1, @2] ❌ return self.skip(pivot).concat(self.snip(self.count - pivot)); after fix: // self.skip(5) ===> @[@6, @7] // self.snip(2) ===> @[@1, @2, @3, @4, @5] // .concat ===> @[@6, @7, @1, @2, @3, @4, @5] ✅

So grateful for your YOLOKit that helped me a lot!

Just added YOLOKit to my project using Cocoapods and imported YOLO.h, but XCode keeps complaining that the methods can't be found:

IGAPI.m:61:18: Property 'each' not found on object of type 'NSArray *'

When I comment out the #ifdef YOLO_EACH in YOLO.h everything works fine. It seems like XCode is not correctly setting the pre-compiler definitions correctly.

Any idea what's going wrong in my project? Other Pods don't seem to have these problems.

NSDictionary values can be retrieved with [], eg. @{@1:@"1", @2:@"2"}[@2] => @"2". get() is unnecessary and less readable than [] (-objectForKeyedSubcript:), plus will be slower (extra method dispatch) and take more memory.

This change is causing a crash for me since I updated to 11.1

https://github.com/mxcl/YOLOKit/compare/11...11.1#diff-4bbdff7cda9b63e25e2e8865533250d4L31

Error:

method only defined for abstract class.  Define -[__NSCFArray initWithCapacity:]!

When subclassing or extending NS class clusters like NSArray we need to be extra careful about what assumptions the code makes (https://mikeash.com/pyblog/friday-qa-2010-03-12-subclassing-class-clusters.html).

This is a pretty serious issue so I'm reverting to 11.0 for now.

apologize for bug in previous my pull request.

NSArray.uniq returns NSArray, but it's concrete class is some private class. And the class does not responds -initWithObjects:count:.

I was reading your README.md. To learn Follow the steps in the README.md

The README.md at https://github.com/venmo/venmo-ios-sdk gives instructions on how to add a cross-project reference in Xcode. Follow the steps up to "ADD THE VENMO URL TYPE."

Question for you. Do you know how I could add tagging by full name (not by username) to a UITextView?

As a Linq fan I'm very happy with your library, thanks. What i'm missing is a items.any() method though. Update: I guess items.find() is equivalent :-)

Blocks are neither cached nor global, so every single time one of the block-returning methods is called (and then the block itself is called for execution) the following will happen:

1. Message dispatch - objc_msgSend called. Relatively fast, particularly for cached IMPs
2. The block is allocated on the stack. Fast.
3. Parameters are copied for the closure. Fast, if the parameter is not a block, fast if the block passed in is already on the heap, slow otherwise.
4. The block is copied to the heap. This is slow, both to copy the block itself and all its variables. malloc() is not fast.
5. The block on the heap is returned. Fast.
6. The block is invoked. Fast-ish.
7. The block is executed. There are some issues here, but in principle, this could be fast if some of the implementations in YOLOKit were better.
8. The block returns its result. Fast.
9. The block and any parameter blocks copied in step 3 are released and the returned block in 5 deallocated! SLOW! free() is not fast!

Compare to standard message sending:

1. Message dispatch. Relatively fast.
2. The method is executed. Could be fast.
3. Method returns its result. Fast.

3 potentially fast steps (with 2 pitfalls) versus 7 potentially fast steps (with 3 pitfalls), and 2 guaranteed slow steps.

Suggested fix: hoist all the blocks returned into global scope, or cache them. This will at least eliminate the copy and free on every call, although it only reduces the number of steps to 7.

I think there is an off-by-one error in the documentation of NSArray.indexOf.

Shouldn't it return a zero-based index like

uint rv = @[@1, @2, @3, @4].indexOf(@2)

// rv => 1

mxcl/YOLOKit now has a Chat Room on Gitter

@mxcl has just created a chat room. You can visit it here: https://gitter.im/mxcl/YOLOKit.

This pull-request adds this badge to your README.markdown:

If my aim is a little off, please let me know.

Happy chatting.

PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Not sure how the documentation at http://mxcl.github.io/YOLOKit/ was generated, but there are a bunch of new, undocumented methods for things like NSSet in the current source tree. How can I help update the main docs page?

I noticed that there are some doc generation in a separate branch (https://github.com/mxcl/YOLOKit/tree/gh-pages) -- and reason this is not included in the main repo?