I would like to use OAStackView. I am creating such an attaching view. I am checking on simulator. But it is very slow. To open this view takes around 8 seconds. According to my investigating,,,to use several module(uiview,uilabel and uiimageview) take a long time such a 8 seconds.

are there way how to solve it?

When i use OAStackView in a universal nib/storyboard it works great, but if i add any views anywhere (related to stackView or not) that are only installed in certain size classes, OAStackView won't render properly. Anyone else seen this and/or have a workaround?

My specific scenario.

View
--UISrollView
----OAStackView (Constrained on all sides, also constrained to equal width of scrollview)

At runtime, I need to add views to the stack view. When I add a single view using [self.stackView addArrangedSubview:view], it works adding that single view.

As soon as I try to add a second view programatically, both views disappear, and the constraints (for the stack view and its subviews), are no longer correct.

Note that this is only specific to the current version on Cocoapods. If I target the latest commit on master, this is no longer an issue.

Can we have an update to the spec uploaded?

Thanks!

layout margins relative arrangement

This PR implements the layout margins relative arrangement feature. It defines two new properties:

@property(nonatomic) UIEdgeInsets layoutMargins;
@property(nonatomic, getter=isLayoutMarginsRelativeArrangement) BOOL layoutMarginsRelativeArrangement;

The first one just defines the missing layoutMargins property on iOS7. The second one switches the layout relative to margins.

I also added some buttons to visualize the feature in the example App.

bonus

• In the process of developing this feature I also solved a small bug with the center alignment: because it didn't define any constraints relative to the edges of the stackView, the content views could easily overflow the stackView boundaries. This was fixed.
• I also added a background view to help visualize the margins. Now that the stackView's backing layer is a CATransformLayer we could not set a backgroundColor on it to help visualize the layout. I fixed this by placing a background view behind the stackView and constraining it to have the same size and center of the stackView.

Hi!

Firstly, thanks for working on this, I just started using and it made my life a lot simpler! :smiley_cat: I was missing the arrangedSubview functionality, as also mentioned in #43, so tried to add it, including accompanying specs.

The solution is just for arrangedSubviews to be mutable, initialized as either empty or with the passed in initial views and update it accordingly when inserting or removing subviews. There is another possible enhancement, so that every place where now self.subviews is used, to use self.arrangedSubviews and completely ignore any subviews which aren't array, but I'm not sure if that's a valid option in your opinions, so I haven't implemented that here yet.

Would love to hear feedback! Cheers! :beers:

Had a problem while using aligning views inside of an autoresizable view. The generated constraints for the OAStackView and it's subviews looked like this: [View]-(0)-[View]-(0)-[View]-|

when it should look like: |-[View]-(0)-[View]-(0)-[View]-|

I am working on adding baseline align support, because I needed it. This requires a bit of a change in the way the alignment strategies are called, because the alignment is between views and not between the view and the stack view.

I'm looking for feedback on the following points:

• [ ] Is this how UIStackView baseline aligns labels? (haven't tried it myself yet)
• [ ] What do you think about the way I've extended the alignment strategy?
• [ ] To test this, new (UILabel based?) tests are needed. How do you want the test suite to grow?

Currently in IB you have to set axisValue and so on.

Except there is nothing anything that tells you what the values actually are.

It would take 5 mins to add documentation to these values.

Thanks

Center aligned views are allowed to be wider than the stack view. It would be great if stack view added a width constraint to views such that they may not be wider than the stack view itself.

Also it would be cool if we can get another tagged, stable release!

I would like some padding at the top of the OAStackView before the first view is laid out and space after the last view is laid out. Is it possible to add IBInspectables for them?

This PR removes removeDecendentConstraints method, since the method basically removed all constraints that involved its subviews (and not only constraints added by the OAStackView layout).

Changes:

• OAStackView will use the property for alignmentStrategy and distributionStrategy rather than the synthesized instance variable
• Implemented setAlignmentStrategy and setDistributionStrategy that removes the previous strategies constraints on OAStackView
• OAStackViewDistributionStategy now adds the constraints created by alignLastView: and alignFirstView: to its array of constraints
• Removed the removeDecendentConstraints method.
• OAStackView will only remove the strategies constraints during layoutArrangedViews

The Interface Builder method described in docs simply doesn't work. I just followed all the steps in a new project exactly as said in the Usage section. Buttons stay where they are.

PR #87 breaks the ability to have OAStackView be a static framework (because it uses Swift), and consequently breaks iOS 7 compatibility.

OAStackView's own Examples project (Deployment Target = 7.1) is broken because of this:

ld: embedded dylibs/frameworks are only supported on iOS 8.0 and later (@rpath/OAStackView.framework/OAStackView) for architecture armv7

It can't be worked around, either, as Cocoapods ~doesn't~ can't support static frameworks with Swift. For example if we remove use_frameworks! from the Podfile we get

[!] Pods written in Swift can only be integrated as frameworks; add `use_frameworks!` to your Podfile or target to opt into using it. The Swift Pod being used is: OAStackView

What problem is OAStackViewProxy.swift trying to solve? PR #60 solves the backwards compatibility problem with objc_allocateClassPair.

I am trying to add stackview into my cel xib, but get error: - Unknown class OAStackView in Interface Builder file. - Failed to set (axisValue) user defined inspected property on (UIView): [<UIView 0x7f95e3cd4f70> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key axisValue. - Failed to set (spacing) user defined inspected property on (UIView): [<UIView 0x7f95e3cd4f70> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key spacing. Failed to set (alignmentValue) user defined inspected property on (UIView): [<UIView 0x7f95e3cd4f70> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key alignmentValue. - Failed to set (distributionValue) user defined inspected property on (UIView): [<UIView 0x7f95e3cd4f70> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key distributionValue.

Btw I already tested successfully on storyboard.

Hey there, @oarrabi!

First of all, thanks for OAStackView and all the effort you put into it. I was just playing with it and replaced a previously iOS 9-only codebase without many issues, but found an odd one.

The original code, which uses UIStackView, follows Apple's guidelines and removes subviews by calling removeFromSuperview. Here's what the docs say about removeArrangedSubview::

This method removes the provided view from the stack’s arrangedSubviews array. The view’s position and size will no longer be managed by the stack view. However, this method does not remove the provided view from the stack’s subviews array; therefore, the view is still displayed as part of the view hierarchy.

OAStackView, on the other hand, seems to expect subviews to be removed by using removeArrangedSubview:, isn't that right? Directly calling removeFromSuperview breaks the constraints system most of the time unfortunately.

I can happily submit a PR with fixes for that if you agree with the changes. I just wanted to make sure the project is still under development first.

Thanks!

Any idea why this crash?

Crashed: com.apple.main-thread EXC_BAD_ACCESS KERN_PROTECTION_FAILURE 0x0000000189a49e6a

Crashed: com.apple.main-thread 0 MyAPP 0x100b30000 -OAStackViewAlignmentStrategy addConstraintsOnOtherAxis: 1 MyAPP 0x100b2e9c4 38-[OAStackView setAlignmentConstraints]block_invoke (OAStackView.m:146) 2 MyAPP 0x100b2d784 -OAStackView(Traversal) iterateVisibleViews: 3 MyAPP 0x100b2e8c8 -OAStackView setAlignmentConstraints 4 MyAPP 0x100b2f7f0 -OAStackView layoutArrangedViews 5 MyAPP 0x100b2e234 -OAStackView initWithArrangedSubviews: 6 MyAPP 0x1002745dc -MyFCVMajorCell tk_initialize 7 MyAPP 0x1002735b0 -MyFCVMajorCell initWithFrame: 8 UIKit 0x18988f488 -[UICollectionView _dequeueReusableViewOfKind:withIdentifier:forIndexPath:viewCategory:] + 892 9 UIKit 0x1890abd48 -[UICollectionView dequeueReusableCellWithReuseIdentifier:forIndexPath:] + 180 10 MyAPP 0x1007639a8 -MyFollowingCollectionView collectionView:cellForItemAtIndexPath: 11 UIKit 0x1898873a8 -[UICollectionView _createPreparedCellForItemAtIndexPath:withLayoutAttributes:applyAttributes:isFocused:] + 432 12 UIKit 0x1890a9adc -[UICollectionView _updateVisibleCellsNow:] + 4628 13 UIKit 0x1890a4808 -[UICollectionView layoutSubviews] + 228 14 UIKit 0x1890401e4 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 656 15 QuartzCore 0x1869d2994 -[CALayer layoutSublayers] + 148 16 QuartzCore 0x1869cd5d0 CA::Layer::layout_if_needed(CA::Transaction) + 292 17 QuartzCore 0x1869cd490 CA::Layer::layout_and_display_if_needed(CA::Transaction_) + 32 18 QuartzCore 0x1869ccac0 CA::Context::commit_transaction(CA::Transaction_) + 252 19 QuartzCore 0x1869cc820 CA::Transaction::commit() + 500 20 QuartzCore 0x1869c5de4 CA::Transaction::observer_callback(_CFRunLoopObserver, unsigned long, void) + 80 21 CoreFoundation 0x183e9c728 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION* + 32 22 CoreFoundation 0x183e9a4cc __CFRunLoopDoObservers + 372 23 CoreFoundation 0x183e9a8fc __CFRunLoopRun + 928 24 CoreFoundation 0x183dc4c50 CFRunLoopRunSpecific + 384 25 GraphicsServices 0x1856ac088 GSEventRunModal + 180 26 UIKit 0x1890ae088 UIApplicationMain + 204 27 MyAPP 0x1000d1fc0 main (main.m:22) 28 libdispatch.dylib 0x1839628b8 (Missing)