An animated gif & apng engine for iOS in Swift. Have a great performance on memory and cpu usage.

Hey @wangjwchn, thanks for open sourcing this! I was using FLAnimatedImage in a project several weeks ago and had to abandon GIF support because of the memory issues. Although in Xcode it would show never ending memory growth, I wasn't experiencing an actual memory leak, it was just that the caching system they had implemented was poor and was causing really high transient counts in Instruments.

I would love to run some tests and compare JWAnimatedImage's transient counts to FLAnimatedImage's.

In one of my previous PR I had put a stopGIF() function. This allows for UIViewController that stays in the view hierarchy. For instance in the case of an UINavigationController push, it allows to stop GIFs in the viewDidDisappear, which prevent undisplayed GIFs to hog on the CPU.

An even better way would be to automatically stop any GIF that is not displayed.

Ok I think I found out where the issue came from. First I renamed AddGifImage to SetGifImage, as only one gifImage can be handled per UIImageView at any point in time. So when we use SetGifImage, we expect to use the new image given as parameter. The previous implementation only replaced the image if the UIImageView wasn't attributed to a manager, which isn't what we want. New implementation updates the gifImage, then add the UIImageView to manager if it wasn't before.

This fixes the issue I had on my other project and seems to correctly release CPU and memory as expected.

Have setted all parameter as Readme File specified, in the moment of excecution at line 61 AImage.swift file occurs EXC_BAD_ACCESS trying check CFDictionaryContainsKey(imageProperties[1],unsafeAddressOf("{GIF}"))

I have know idea what I'm doing wrong but it's crashing since swift 4.1 ` }

    let frameDelays: [Float] = frameProperties.map() {
        var delayObject: AnyObject = unsafeBitCast(CFDictionaryGetValue($0, Unmanaged.passUnretained(kCGImagePropertyGIFUnclampedDelayTime).toOpaque()), to: AnyObject.self)
        if (delayObject.floatValue == 0.0){
            delayObject = unsafeBitCast(CFDictionaryGetValue($0, Unmanaged.passUnretained(kCGImagePropertyGIFDelayTime).toOpaque()), to: AnyObject.self)
        }
        return delayObject as! Float   // <-- error occurs here
    }
    return frameDelays
}`

Not really a code issue, really a documentation/README issue. Your README says this code hasn't been updated since April 2016 but of course it has. Also, FLAnimatedImage has had issues (or reported issues) with iOS 10. Have you tested with iOS10 yet? if you would just update the README you can then delete or close this issue.

Thanks for creating this repository!

Hey! I like this solution for rendering gifs, but I can't use it in UITable- or CollectionView. Reasons:

1. UIView doesn't support content mode for scaling images. (https://github.com/wangjwchn/AImage/issues/29)
2. We can't clear cache or view (because image is drawn on view) when prepare for reuse func is called in UITable- or UICollectionCell.

File changes:

1. Declare clear function to public, for clear cache and data when using UITable- or CollectionView;
2. Time fired function;
3. Decode image.

    var frameProperties = [CFDictionary]()
    if(imageProperty.imageType == ImageType.Gif){
        frameProperties = imageProperties.map(){
            let propertyGIFDic =  CFDictionaryGetValue($0,unsafeAddressOf(kCGImagePropertyGIFDictionary))
            return unsafeBitCast(propertyGIFDic,CFDictionary.self)
        }//gif
    }
    else if(CFDictionaryContainsKey(imageProperties[0],unsafeAddressOf(kCGImagePropertyPNGDictionary))){
        frameProperties = imageProperties.map(){
            unsafeBitCast(CFDictionaryGetValue($0,unsafeAddressOf(kCGImagePropertyPNGDictionary)),CFDictionary.self)
        }//apng
    }

When using GIFs on a UICollectionView cell that is reused, the framerate does increase exponentially. A great addition would be to set a maximum framerate.

Hi. There was no problem with Swift 4.0 but on Swift 4.1 on timerFired() func there is a crash on this line:

    `let nextAt = ((self.indexAt)+1)%(self.aImage!.displayIndex.count)`

and it says: Fatal error: Remainder of division by zero

Hey! I see fatal issues from @chanonly123 (https://github.com/wangjwchn/AImage/issues/30). There is happened when we set unsupported data content to the AImage constructor like mp4 :)

So, I add condition for checking the number of images in the image source.

I've tried AImage using Cocoapods and:

• The available version is 1.0.0 and not 2.0.0 yet
• LICENSE file is missing

Using :git => "https://github.com/wangjwchn/AImage.git" on Podfile results a empty installation.

Can you fix it? Thanks!

I have a two-frame gif and only the first frame shows. With a three-frame gif only two frames animate back and forth. One frame is being dropped. I think it has something to do with the displayIndex array on AImage, but I can't understand the logic in the calculateFrameDelay function well enough to figure out exactly what is causing the issue.

@wangjwchn hey! I'm back 😎. So, I have a good news for us: Testing on (iPhone 6s, 11.1, Xcode 9.1 (9B55)) Old implementation: https://puu.sh/ynWBq/affb71ab10.png After small changes: https://puu.sh/ynWBT/8ecccbad27.png Resource: https://wangjwchn.github.io/image/view.gif

@wangjwchn Could you test as you wish and review code ?

Refactor:

1. Change layer contects setting to image setting;
2. Remove decode image function;
3. Time fired function;
4. Add types to variables.

Hi, I'd like to inquire about the app's performance in general. I understand it slows down the view it's in, but it currently seems to be affecting the entire app (I have an iCarousel running in the main View). I have a single apng sitting in my SettingsViewController and display it in the footer view of the table. It's loaded with imageview.APlay();. Do I need to somehow use iamgeview.AStop(); in order for it not to affect the rest of the app? I understand this is a noob question, I'm just slightly confused by how slow the entire app has become all of a sudden.

Thanks a bunch!