Hi,

Under some circumstances, Xcode's Memory Leaks Instrument seems to report leaks when using AnimatedGIFImageSerialization in combination with Crashlytics. I don't know if those are actual leaks or not. All of these have in common Crashlytics and AnimatedGIFImageSerialization:

The leaks seem to go away if you replace AnimatedGIFImageSerialization's swizzling by JRSwizzle, which seems to be safer for subclassing and inheritance:

[self jr_swizzleMethod:@selector(imageNamed:) withMethod:@selector(animated_gif_imageNamed:) error:nil];
[self jr_swizzleMethod:@selector(imageWithData:) withMethod:@selector(animated_gif_imageWithData:) error:nil];
[self jr_swizzleMethod:@selector(imageWithData:scale:) withMethod:@selector(animated_gif_imageWithData:scale:) error:nil];
[self jr_swizzleMethod:@selector(imageWithContentsOfFile:) withMethod:@selector(animated_gif_imageWithContentsOfFile:) error:nil];
[self jr_swizzleMethod:@selector(initWithContentsOfFile:) withMethod:@selector(animated_gif_initWithContentsOfFile:) error:nil];
[self jr_swizzleMethod:@selector(initWithData:) withMethod:@selector(animated_gif_initWithData:) error:nil];
[self jr_swizzleMethod:@selector(initWithData:scale:) withMethod:@selector(animated_gif_initWithData:scale:) error:nil];

I get a exception with endless loop when AnimatedGIFImiageSerialization is imported in classes that are used in unit tests.

The loop happens with this method: + (UIImage *)animated_gif_imageNamed:(NSString *)name attribute((objc_method_family(new))) {

Is there a reason why AFNetworking methods doesn't support this library?

I tried with the UIImageView+AFNetworking methods like [imageView setImageWithURLRequest:req placeholderImage:[UIImage imageNamed:@"placeholder.gif"] ....

The placeholder works but the downloaded image (a GIF) is not animated.

Do i have to do anything special?

PR to request a version bump that includes the -imageWithData:scale: fix. Tag will still need to be created but I figured if I created an issue I could at least propose a solution.

Thank you for this library.

In the .m file, on line 71 I get a warning: "The code will never be executed". Please clean the code, because the warnings are very uncomfortable.

Not sure what the intentions of using NSUInteger here was but this was causing issues where gifs played very fast.

Reverted NSUInteger back to TimeInterval

When loading GIFs with just 1 frame the

 [UIImage animatedImageWithImages:duration:]

constructor was being used, and UIImage's images property was returning an array with only one element.

I think that when loading GIFs with just 1 frame they should load as regular non-animated images. I modified the code so that's the case.

Also added some test logs to check the images property values for 1-framed GIF and for a PNG file.

I was having memory leaks in my project from AnimatedGIFImageSerialization, like in issue https://github.com/mattt/AnimatedGIFImageSerialization/issues/11 I tried similar swizzling with a custom test class, and noticed that if we swizzle a static creation method with __attribute__((objc_method_family(init))) (like animated_gif_imageWithData: and animated_gif_imageWithData:scale:), the returned object will not be deallocated . If swizzle with __attribute__((objc_method_family(new))) (like animated_gif_imageWithContentsOfFile:), it will be deallocated, but at some weird different time compared to when running without swizzling. I had this test:

  @implementation TestClass
  // whatever
  - (void)dealloc {
    NSLog(@"TestClass instance Died! %@", _crab);
  }
  @end

  // in some swizzling category
  + (TestClass*)sqwizzled_testClassWithCrab:(NSObject*)crab
    __attribute__((objc_method_family(new)))
   // if set "init" here, object will not be deallocated - leak!
   // if set "new" here, object will be deallocated but at a different time than when using a non-swizzled method
   // so best not to set attribute and things will work out themselves
  {
    NSLog(@"sqwizzled_testClassWithCrab %@", crab);
    // simply call through to original
    return [self sqwizzled_testClassWithCrab:crab];
  }
  ........
  // in some ViewController
  - (void)viewDidLoad {
    [super viewDidLoad];
    for (int i = 5; i < 10; i ++) {
      TestClass * testClass = [TestClass testClassInstanceWithCrab:@(i)];
      // something something
    }
    NSLog(@"2nd loop end");
  }

When testClassInstanceWithCrab was not swizzled, the output was like this:

2016-10-04 14:17:53.556 SwizzlingTest[10185:261562] TestClass instance Died! 5 2016-10-04 14:17:53.556 SwizzlingTest[10185:261562] TestClass instance Died! 6 2016-10-04 14:17:53.556 SwizzlingTest[10185:261562] TestClass instance Died! 7 2016-10-04 14:17:53.556 SwizzlingTest[10185:261562] TestClass instance Died! 8 2016-10-04 14:17:53.557 SwizzlingTest[10185:261562] TestClass instance Died! 9 2016-10-04 14:17:53.557 SwizzlingTest[10185:261562] 2nd loop end

With "init" family messages from dealloc were never printed. But when swizzled with __attribute__((objc_method_family(new))), the output is a bit different

2016-10-04 14:19:39.474 SwizzlingTest[10213:264787] sqwizzled_testClassWithCrab 5 2016-10-04 14:19:39.474 SwizzlingTest[10213:264787] sqwizzled_testClassWithCrab 6 2016-10-04 14:19:39.475 SwizzlingTest[10213:264787] sqwizzled_testClassWithCrab 7 2016-10-04 14:19:39.475 SwizzlingTest[10213:264787] sqwizzled_testClassWithCrab 8 2016-10-04 14:19:39.475 SwizzlingTest[10213:264787] sqwizzled_testClassWithCrab 9 2016-10-04 14:19:39.475 SwizzlingTest[10213:264787] 2nd loop end 2016-10-04 14:19:39.477 SwizzlingTest[10213:264787] TestClass instance Died! 9 2016-10-04 14:19:39.477 SwizzlingTest[10213:264787] TestClass instance Died! 8 2016-10-04 14:19:39.477 SwizzlingTest[10213:264787] TestClass instance Died! 7 2016-10-04 14:19:39.477 SwizzlingTest[10213:264787] TestClass instance Died! 6 2016-10-04 14:19:39.478 SwizzlingTest[10213:264787] TestClass instance Died! 5

As seen objects are deallocated not immediately like normally, but when method scope ended for some reason. So I removed __attribute__((objc_method_family(new))) from animated_gif_imageWithContentsOfFile:

I am seeing an out of memory exception when trying to display a 3x GIF with 500 frames. I think it has something to do with the size of the mutableImages array.

This is a good project.

Can I save the encoded gif image to the photo library?

UIImage *gifImage = UIImageWithAnimatedGIFData(data);
UIImageWriteToSavedPhotosAlbum(gifImage, nil, nil, nil);

This code not work. Pls give a hand. Thanks

@mattt This pull request should resolve the recursion issue when a non-animated gif is provided to the unswizzled method, while still exposing the animated_gif methods for use.