VLC for iOS and tvOS official mirror

It seems like simply setting _mediaPlayer.position does not actually change the position of control center's scrubber; or am I missing something???

My workaround was using the [VLCMediaPlayer jumpFoward:Int] function to take care of all the magic that happens behind the scenes for me.

Checklist

• [x] I've run bundle exec fastlane test from the root directory to see all new and existing tests pass
• [x] I've followed the vlc-ios code style
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Description

Checklist

• [x] I've run bundle exec fastlane test from the root directory to see all new and existing tests pass
• [x] I've followed the vlc-ios code style and run bundle exec fastlane lint to ensure the code style is valid
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Description

• [x] Adapt empty view to theme
• [x] Adaptive layout
• [ ] Enable scrolling?

It's still work in progress but I wanted to share this. I'm still having the problem that when I hold the phone exactly opposite of the starting point I see the exact start frame upside down again and currently the gesturerecognizers are completely overwritten.

Checklist

• [x] I've run bundle exec fastlane test from the root directory to see all new and existing tests pass
• [x] I've followed the vlc-ios code style and run bundle exec fastlane lint to ensure the code style is valid
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Description

This is the VLC-iOS SwiftFormat integration (https://github.com/nicklockwood/SwiftFormat). I added SwiftFormat as a Xcode run script for VLC-iOS target. Due to my experience with SwiftFormat i disabled the following "magic" rules: blankLinesAtStartOfScope,hoistPatternLet,indent,redundantParens,redundantSelf,trailingCommas,unusedArguments,wrapArguments All SwiftFormat rules are described here: https://github.com/nicklockwood/SwiftFormat#rules

Full list of code changes:

• Fixed inconsistent code - newline at end of functions / structs / computed properties
• Fixed inconsistent code - trailing colon for todos
• Fixed inconsistent code - blank line around marks
• Fixed inconsistent code - multiple spaces instead of one
• Fixed inconsistent code - space inside / at start of comments
• Fixed inconsistent code - trailing spaces for empty lines
• Fixed inconsistent code - space inside brackets
• Fixed inconsistent code - space inside parens
• Fixed inconsistent code - space inside braces
• Fixed inconsistent code - space around operators
• Fixed inconsistent code - code indent
• Fixed inconsistent code - order for access specifiers
• Fixed inconsistent code - redundant self reference
• Fixed inconsistent code - hex formatting
• Fixed inconsistent code - unnecessary nil initialization
• Fixed inconsistent code - no new trailing blank lines from inside braces, brackets, parens or chevrons
• Fixed inconsistent code - sorted imports
• Added SwiftFormat support for VLC-iOS debug schema
• Added run script phase for swiftFormat to VLC-iOS project

Checklist

• [x] I've run bundle exec fastlane test from the root directory to see all new and existing tests pass
• [x] I've followed the vlc-ios code style
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Description

This merge request updates the status bar in dark mode. fixes #403

Major feat in this PR are

• Support for fastlane screenshots with localization
• New UI tests for the new shiny UI with localization

I wasn't sure which screens to capture and what kind of text to put in the frames but here's what I came up with. Here's some demo screenshots in German; thanks to Google Translate 😃

Please note that code for screenshooting is part of UI testing

Checklist

• [x] I've run bundle exec fastlane test from the root directory to see all new and existing tests pass
• [x] I've followed the vlc-ios code style
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Description

Implemented sorting feature inside Google Drive Controller. Sorting can be invoked by pressing the sort button right next to number of files button now, and sorting button will be hidden when using a non-Google-Drive controller.

Checklist

• [x] I've run bundle exec fastlane test from the root directory to see all new and existing tests pass
• [x] I've followed the vlc-ios code style and run bundle exec fastlane lint to ensure the code style is valid
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Description

Acceptance Critieria: please test on iOS 9 and iOS 10, 11 and 12 since different buttons and delegate methods are available depending on the OS. for the requirements: https://code.videolan.org/videolan/vlc-ios/issues?scope=all&utf8=%E2%9C%93&state=opened&search=Donation

The following scenarios should be reviewed:

• not an apple pay capabale device,
• apple pay not setup
• setup cards are not supported

in order to test please create a sandbox test account as described here : https://developer.apple.com/apple-pay/sandbox-testing/

known issues:

• weird animation after a successful donation
• when a card is not setup and the setup flow is finished the UI doesnt update and the user is prompted to still setup a card
• constraints warnings when first showing the screen
• show alternative payment option for those who don't have apple pay
• backend communication with payment provider is still missing

Checklist

• [x] I've run bundle exec fastlane test from the root directory to see all new and existing tests pass
• [x] I've followed the vlc-ios code style and run bundle exec fastlane lint to ensure the code style is valid
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Description

Basic migration of MLLabels and MLFiles.

Small note: This need a fresh build of VLCMediaLibraryKit to work since the changes haven't been released yet.

Checklist

• [x] I've run bundle exec fastlane test from the root directory to see all new and existing tests pass
• [x] I've followed the vlc-ios code style and run bundle exec fastlane lint to ensure the code style is valid
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Description

Add a small delay to recover the playback state.

The bug reproduce steps(install VLC on iPhone)：

1. Play a video with two or more subtitles,
2. Switch to a subtitle other than the first one
3. close the video and back to the video list
4. Open the same video again
5. The selected subtitle was the first one.

Expected behavior: At step 5, the selected subtitle should be the one last selected.

Checklist

• [ ] I've run bundle exec fastlane test from the fastlane directory to see all new and existing tests pass
• [ ] I've followed the vlc-ios code style
• [ ] I've read the Contribution Guidelines
• [ ] I've updated the documentation if necessary.

Description

It is annoying that new stream URLs are added at the bottom to the list, so you have to scroll down to resume a recent stream.

Can we add a setting to change this behavior? Alternatively I added a "reverse sorting" button with this PR.