New issue checklist

• [x] I have reviewed the README
• [x] I have searched existing issues and this is not a duplicate

⚠️ The more information you provide, the faster we can help you. Select what you want - a feature request or report a bug. Please remove the section you aren't interested in.

Report a bug

What did you do?

I added the possibility to select an element of the list.

in your example project just add: performSegue(withIdentifier: "ShowSettings", sender: self) to didSelectItemAt method

What did you expect to happen?

when dismiss viewcontroller the list items should show correctly

What happened instead?

list items not show correctly

Your Environment

• CollectionViewSlantedLayout version: 3.1.1
• Langage: Swift
• Swift version: 4.2
• iOS version(s): 12.1.4
• CocoaPods version: 1.5.3
• Xcode version: 10.1
• Devices/Simulators affected: Device iPhone 6s plus
• Reproducible in the demo project? : Yes

Well, I have tried the demo. The demo used CustomCollectionCell as the slanted cell, but there is no any UILabel in this cell. Simply adding a UILabel to the cell can't display the text in slanted style obviously. So how does the gif showed "Highway" "AC/DC" in slanted style? Thanks for helping me out!

New issue checklist

• [X] I have reviewed the README
• [X] I have searched existing issues and this is not a duplicate

⚠️ The more information you provide, the faster we can help you. Select what you want - a feature request or report a bug. Please remove the section you aren't interested in.

A feature request

Section support

What do you want to add?

Looks like there is some explicit assumptions for the number of sections this collection view layout supports : 1 - Section 0 is hard coded.

Please describe what you want to add to the component.

Support for more than 1 section

Thanks for the project, its quite nice. I may put a PR but just opening this for record/discussion.

Not an Issue but a complicated question.

is there any way to change all the cell's gradient color in real time? im making black/white themes and i found the only way to make changes to the color of gradient is to leave view controller or close/open app again, so the collection view is loading from start, but i have just few view controllers in app and all af them opens from collection view, and does not stops it so it doesnt need to update alot of information every time i open something. the theme change action is happens on main screen with cv so it will be good to have some animation to it too.

New issue checklist

• [x] I have reviewed the README
• [x] I have searched existing issues and this is not a duplicate

⚠️ The more information you provide, the faster we can help you. Select what you want - a feature request or report a bug. Please remove the section you aren't interested in.

A feature request

What do you want to add?

Please describe what you want to add to the component.

How should it look like?

Please add images.

Report a bug

What did you do?

Please replace this with what you did.

What did you expect to happen?

Please replace this with what you expected to happen.

What happened instead?

Please replace this with what happened instead.

Your Environment

• CollectionViewSlantedLayout version:
• Langage: Swift or Objective-C
• Swift version:
• iOS version(s):
• CocoaPods/Carthage version:
• Xcode version:
• Devices/Simulators affected:
• Reproducible in the demo project? : Yes or No

Project that demonstrates the bug

Please add a link to a project we can download that reproduces the bug.

Fix compilation issue by adding import for UIBezierPath

This allow to open project in Xcode 11 by opening Package.swift To have build and test available

Using command line, build could be checked by executing

sdk=`xcrun -sdk iphonesimulator -show-sdk-path`
sdkVersion=`echo $sdk | sed -E 's/.*iPhoneSimulator(.*)\.sdk/\1/'`
swift build  -Xswiftc "-sdk" -Xswiftc "$sdk" -Xswiftc "-target" -Xswiftc "x86_64-apple-ios$sdkVersion-simulator"

could be added to a CI like travis or github workflow like this

Using collectionview.reloaddata() and collectionView.collectionViewLayout.invalidatelayout() but crashes when I delete data. Adding data does not crash the app but the collectionview does not update. Is there something I’m missing?

New issue checklist

• [x] I have reviewed the README
• [ ] I have searched existing issues and this is not a duplicate

⚠️ The more information you provide, the faster we can help you. Select what you want - a feature request or report a bug. Please remove the section you aren't interested in.

A feature request

What do you want to add?

Please describe what you want to add to the component.

How should it look like?

Please add images.

Report a bug

What did you do?

Please replace this with what you did.

What did you expect to happen?

Please replace this with what you expected to happen.

What happened instead?

Please replace this with what happened instead.

Your Environment

• CollectionViewSlantedLayout version:
• Langage: Swift or Objective-C
• Swift version:
• iOS version(s):
• CocoaPods/Carthage version:
• Xcode version:
• Devices/Simulators affected:
• Reproducible in the demo project? : Yes or No

Project that demonstrates the bug

Please add a link to a project we can download that reproduces the bug.

Issue: 1) I am running into a crash when loading the cells dynamically, upon scroll crashes with:

Terminating app due to uncaught exception 'CALayerInvalidGeometry', reason: 'CALayer position contains NaN: [nan -inf]'

Happens on all simulators and also in test devices.

I checked for existing issues and found nothing relating to it.

This happens with other images and the images shipped in the example project, if loaded dynamically.

For anybody having this issue: Solution: Knowing that It was related to the cell size being laid out I assumed that it needed a placeholder image to set it up, and that fixes it, while the thumbnail gets fetched the placeholder should be first added.

I have not checked whether it would be an issue if the image loaded was a different size from the placeholder image however.

Issue 2) On the iPhone X,XS,XS Max when scrolling the cells leave space at the bottom revealing the background. ( This happens with the images found on the example project ) Expected Behavior: Fill the whole cell as in the example project when ran on the iPhone 8,7 (4.7 inch displays)

For this I haven't looked much, maybe someone with more knowledge on the project can jump in?

Swift: 4.0 Xcode: 10

I have an issue where the CollectionView won't add new index path once you add your initial material.

New issue checklist

• [ ] I have reviewed the README
• [ ] I have searched existing issues and this is not a duplicate

⚠️ The more information you provide, the faster we can help you. Select what you want - a feature request or report a bug. Please remove the section you aren't interested in.

A feature request

What do you want to add?

Please describe what you want to add to the component.

How should it look like?

Please add images.

Report a bug

What did you do?

Please replace this with what you did.

What did you expect to happen?

Please replace this with what you expected to happen.

What happened instead?

Please replace this with what happened instead.

Your Environment

• CollectionViewSlantedLayout version:
• Langage: Swift or Objective-C
• Swift version:
• iOS version(s):
• CocoaPods/Carthage version:
• Xcode version:
• Devices/Simulators affected:
• Reproducible in the demo project? : Yes or No

Project that demonstrates the bug

Please add a link to a project we can download that reproduces the bug.

Hi,

I just tried out this layout in my project, which is using RxSwift and RxDataSource for collection views. I realised that the application crashes on binding the sections. This is how I initialise datasource and bind it to the collection view items:

let animationConfiguration = AnimationConfiguration(insertAnimation: .bottom, reloadAnimation: .bottom, deleteAnimation: .bottom)

let dataSource = RxCollectionViewSectionedAnimatedDataSource<TopListSectionModel>(animationConfiguration: animationConfiguration, configureCell: { _, collectionView, indexPath, item  in
            
            let cell: TopListCell = collectionView.dequeueReusableCell(forIndexPath: indexPath)
            cell.configure(with: item)
            
            if let layout = collectionView.collectionViewLayout as? CollectionViewSlantedLayout {
                cell.contentView.transform = CGAffineTransform(rotationAngle: layout.slantingAngle)
            }
            
            return cell
        })
          
sections
      .bind(to: collectionView.rx.items(dataSource: dataSource))
      .disposed(by: disposeBag)

Crash on binding:

Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'request for number of items in section 0 when there are only 0 sections in the collection view'

It seems like the number of sections is not set when the prepare() function in CollectionViewSlantedLayout is called. I managed to fix this by checking the number of sections in the helper numberOfItems:

var numberOfItems: Int {
    guard let collectionView = collectionView, collectionView.numberOfSections > 0 else { return 0 }
    return collectionView.numberOfItems(inSection: 0)
}

This fixes the crash, however it lead to another crash:

Terminating app due to uncaught exception 'CALayerInvalidGeometry', reason: 'CALayer bounds contains NaN: [0 0; nan nan]. Layer: <CALayer:0x600000e47f60; position = CGPoint (187.5 40); bounds = CGRect (0 0; 375 80); delegate = <UIView: 0x7fa76ed7e830; frame = (-8.98847e+307 -8.98847e+307; 1.79769e+308 1.79769e+308); transform = [nan, nan, nan, nan, 0, 0]; gestureRecognizers = <NSArray: 0x6000002f3030>; layer = <CALayer: 0x600000e47f60>>; sublayers = (<CALayer: 0x600000f41de0>, <CATransformLayer: 0x600000e41bc0>); opaque = YES; allowsGroupOpacity = YES; transform = CATransform3D (nan nan 0 0; nan nan 0 0; 0 0 1 0; 0 0 0 1)>'

I tried to debug the issue, but I haven't gotten to a conclusion yet. Could you think of a reason for this crash? Thanks for your help

Hello,

First of all, apologize for my level of English language. I have setup a view collection with a search bar and filters. The layout being made with your package.

When i perform a reload on this with this method : self.collectionView.collectionViewLayout.invalidateLayout().

I obtain this error on the debugger :

[CollectionView] Layout attributes <CollectionViewSlantedLayout.CollectionViewSlantedLayoutAttributes: 0x7ff1035113c0> index path: (<NSIndexPath: 0xbcd26c36f94746f0> {length = 2, path = 0 - 3}); frame = (0 603; 414 275); zIndex = 3;  were received from the layout <CollectionViewSlantedLayout.CollectionViewSlantedLayout: 0x7ff1035148a0> but are not valid for the data source counts. Attributes will be ignored.

After research i solved it by adding this method to your class CollectionViewSlantedLayout.swift

The method to add is :

override open func invalidateLayout() {
    super.invalidateLayout()
    self.cachedAttributes.removeAll()
}

I can put this code and make a pull request if you want and if you are ok.