Im getting an issue where the content at the top of my viewcontroller is being clipped b/c of NotchKit. I was hoping that the library would shift the contents down instead of overlaying them. B/c of this, I have to remove this library since it wont work for my app. Hopefully in the future you plan on adding this in.

Cheers

New issue checklist

• [x] I have reviewed the README
• [x] I have searched existing issues and this is not a duplicate

Not available on cocoapods

When i run "pod install" i get the following response: [!] Unable to find a specification for NotchKit

• [x] I have reviewed the README
• [x] I have searched existing issues and this is not a duplicate

Hey there!

I really like the concept as it looks much cleaner! However, it seems to interfere with Apples iOS Human Interface Guidelines, where placing black bars at the top of the screen is to be explicitly avoided:

Don't mask or call special attention to key display features. Don't attempt to hide the device's rounded corners, sensor housing, or indicator for accessing the Home screen by placing black bars at the top and bottom of the screen. Don't use visual adornments like brackets, bezels, shapes, or instructional text to call special attention to these areas either.

It might be worth mentioning this in the README, as this could lead to rejection by the Apple Store Review Team.

New issue checklist

• [yes ] I have reviewed the README
• [yes] I have searched existing issues and this is not a duplicate

if (@available(iOS 11, *)) { NotchKitWindow *notchWindow = [[NotchKitWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]]; // [notchWindow setMaskedEdges:UIRectEdgeNone]; notchWindow.maskedEdges = UIRectEdgeNone; self.window = notchWindow; } else { self.window = [[UIWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]]; }

error is Property 'maskedEdges' not found on object of type 'NotchKitWindow *'

swift 4.0 var must add the @objc refs ==> https://stackoverflow.com/questions/45656671/unable-to-access-swift-class-from-objective-c-property-not-found-on-object-of

From Apple:

"Don't mask or call special attention to key display features. Don't attempt to hide the device's rounded corners, sensor housing, or indicator for accessing the Home screen by placing black bars at the top and bottom of the screen. Don't use visual adornments like brackets, bezels, shapes, or instructional text to call special attention to these areas, either."

https://developer.apple.com/ios/human-interface-guidelines/overview/iphone-x/

Hi there, the idea is good but there is this tiny rule on the iPhone X Human Interface Guidelines...

Don't mask or call special attention to key display features. Don't attempt to hide the device's rounded corners, sensor housing, or indicator for accessing the Home screen by placing black bars at the top and bottom of the screen. Don't use visual adornments like brackets, bezels, shapes, or instructional text to call special attention to these areas either.

https://developer.apple.com/ios/human-interface-guidelines/overview/iphone-x/

:(

From Apple guidelines:

Don't attempt to hide the device's rounded corners, sensor housing, or indicator for accessing the Home screen by placing black bars at the top and bottom of the screen. Don't use visual adornments like brackets, bezels, shapes, or instructional text to call special attention to these areas either.

Hi, NotchKit is a great framework, and it works well at portrait pages:

But it has some issue at Landscape page(Some view is cropped too much):

The origin Landscape page is look like this:

As the title states, this violate's Apple's guidelines and can lead to removal of an app form the app store.

Don't mask or call special attention to key display features. Don't attempt to hide the device's rounded corners, sensor housing, or indicator for accessing the Home screen by placing black bars at the top and bottom of the screen. Don't use visual adornments like brackets, bezels, shapes, or instructional text to call special attention to these areas either.

Source: https://developer.apple.com/ios/human-interface-guidelines/overview/iphone-x/

Not really sure why this is happening. I set the extension and computed property to public and it didn't fix anything. Happens when updateCornerRadii() gets called in layoutSubviews().

Temporary fix: I added this

private var isiPhoneX: Bool {
      return screen.nativeBounds.height == 2436 && screen.nativeBounds.width  == 1125
}

to NotchKitWindow and replaced all instances of screen.isiPhoneX with isiPhoneX.

Add support to use in SceneDelegate.swift via API checking. Uses:

func scene(_ scene: UIScene, willConnectTo session: UISceneSession, options connectionOptions: UIScene.ConnectionOptions) {
...
let notch = NotchKitWindow(windowScene: scene)
...
}