An image viewer à la Twitter

Changed to make view controller presentable as modal VC using custom transition. Only made a custom transition for the presentation, not the dismissal, where it's not necessary (uses the existing animation).

It seems it's not possible to install the version 3 via cocoapods? The .podspec of v3 points to v2.0.

I also used this line: pod 'ImageViewer', :git => '[email protected]:MailOnline/ImageViewer.git', :tag => '3.0' or pod 'ImageViewer', :git => '[email protected]:MailOnline/ImageViewer.git', :commit => 'f887383cc4fc32374f4096329253b2df5a79c11a'

but it produces strange error: GalleryViewController.swift:367:36: Use of unresolved identifier 'ThumbnailsViewController'. Any ideas?

• Use safeAreaInsets on iOS 11
• compensate for erroneous 20 px top inset with hidden status bar on iOS 11
• add missing .deleteLayout to handling of GalleryConfiguration

Closes #164

Hello,

I've been having trouble figuring out how to setup the asynchronous loading of images in galleryviewcontroller. Could you provide a snippet that will give me a hint on how to do this?

Hello!

Is it possible to use this component when I only have a set of URLs rather the UIImage objects?

Perhaps https://github.com/MailOnline/ImageViewer/blob/master/ImageViewer/Source/GalleryItem.swift Using GalleryItem, custom enumeration

But, in that case, how should I add an activity view while the image is downloaded? Can I combine this library with: https://github.com/rs/SDWebImage and use: [imageView sd_setShowActivityIndicatorView:YES]; [imageView sd_setIndicatorStyle:UIActivityIndicatorViewStyleGray];

Thanks a lot for suggestions.

button.setImage(UIImage(named: "close_normal"), forState: UIControlState.Normal)
button.setImage(UIImage(named: "close_highlighted"), forState: UIControlState.Highlighted)

Podspec doesn't add any assets. When I manually copied them from demo project it worked.

Idea - maybe draw it programmatically instead of using images?

For some reason when I try to dismiss an image by swiping down dragging the image down, the image becomes "stuck" to the bottom. Dismissing the image by swiping up works perfectly, as well as through close button. Looked at the code, and both directions should work just fine with the pangesture. Could you help me out?

I'm investigating using ImageViewer in our app, and I've submitted a PR with changes I need. I'm also working on further improvements. This is in no way a criticism of the good work you guys have done here, but as I've worked on ImageViewer I've found there to be quite a lot of typos in the code. I'd like to clean them up in a separate PR, but only if the changes would be welcome here. What do you say?

Fellow Swifters,

I’ve moved the project to Swift 3. As you know, this is a particularly insidious task that has affected a lot of my time. I think it’d be worthwhile to pull it into the project repository in order to get it into the next release.

Thanks!

Hi, It's will be great to create a Swift 3 version of your component

Article about Swift 3:

• Migrating to Swift 2.3 or Swift 3 from Swift 2.2

With Swift 3 it would also be nice to add support for SwiftPM

Articles about SwiftPM:

• Package.swift — The Manifest File
• Developing Packages
• System Modules
• Swift Package Manager Community Proposal

On your README.md add on top and add section for the installation with SwiftPM.

Hello, when passing a UIImageView (which has a contentMode of .ScaleAspectFit) as a displaced view, GalleryViewController maintains the image size. If the image is fit by height it maintains the aspect ratio and does not layout to the new bounds.

passing first image as displaced:

switching to next image:

passing second image as displaced:

switching to first image:

Hello! Calling the galleryViewController.page(toIndex: index) method triggers an animated transition, but the image changes only after the transition is complete.

Devices that do not have home buttons instead have a greater safe zone at the bottom of the screen. When playing a video, this safe zone is ignored and the video controls are too low to interact with.

Here is a picture of the issue.

I had issues with Carthage and the new xcode12. It looks like that Carthage currently no more is usable with Xcode12 and iOS simulator. When you build the frameworks with 'carthage update' or 'carthage build' there comes an error. A deeper look says "have the same architectures (arm64) and can't be in the same fat output file" So the iOS Simulator build is missing in the framework. This already is discussed as issue here https://github.com/Carthage/Carthage/issues/3019 and here https://github.com/ashleymills/Reachability.swift/issues/370

My workarround was just to move from carthage to Swift Packages. I found out that is really easy to provide an existing iOS framework as Swift Package. Just create a fork of it, put there a configured Package.swift file into the root folder, double click it in finder to open it in Xcode as a SWIFT PACKAGE PROJECT !!! - now just add/change the path to the source files in the Package.swift file. When you could build the project, all is fine and push it to your repo - thats it. For this works.

Maybe you want to add Swift Package support ?

I was using it on new fresh project for playground before integrating with real app on Swift 5. Just want to let know if you're having the same trouble.

While initialize GalleryViewController for the first time, please make sure that you DISABLE SCENE SESSION on your project :

• AppDelegate : remove any scene session delegate
• Remove any scene session related on Info.plist
• Don't forget to add : var window: UIWindow? (on AppDelegate)

Otherwise, you will get error in UIApplication without any error log.

Great library by the way. Cheers. CMIW

The problem can be identified by setting the presentationStyle to .fade in the example project

GalleryConfigurationItem.presentationStyle(.fade),

Is there any workaround for this?

FYI

• The library is installed via pod pod 'ImageViewer', :git => 'https://github.com/Krisiacik/ImageViewer.git'

• My Swift is 4.2

• This issue should be the same one mentioned is issue #190