Hi,

I have an old project in Swift 3 with ImageSlideShow 1.3.2 (XCode 8). It works fine like this:

• I show a dialog of ImageSlideShow with a list of some InputSource items (name as list A).
• When user taps Delete button on dialog, I delete the current InputSource item in list A, then I call ImageSliceShow.setImageInputs(A) to reload the slide show.

Now I upgrade the project up to Swift 5 with ImageSlideShow latest (1.8.0) (with XCode 10.2 - latest iOS SDK). There's an issue:

• It works fine if I show ImageSlideShow dialog with list A containing 1 item (I mean setImageInputs(A) works fine at first time).
• With list A count > 2, when I delete item in A and call setImageInputs(A) to reload the slide show, it works fine.
• But when list A has 2 items, I delete 1 item so list A now contains only 1, then I call setImageInputs(A). ImageSlideShow now shows blank screen. (In Debug View Hierarchy, there's no subview in ImageSlideShow.scrollview).

I apply that deleting spec into example project & get same issue.

Please check, thank you!

I see this issue when images from url loading. At that time, I tap to show full-screen, and I swipe to close. I see the app cracks! someone can tell me the reason and solutions for this.

Must I use pod "ImageSlideshow/Kingfisher" even if I already have Kingfisher installed, or can I simply use pod 'ImageSlideshow', '~> 0.6' ?

First of all, I wanna say thank you very much for this great library :)

I have a little bit issue in here, I get a warning

'pageControlPosition' is deprecated: Use pageIndicatorPosition instead

I get the error in here

open class FullScreenSlideshowViewController: UIViewController {

    open var slideshow: ImageSlideshow = {
        let slideshow = ImageSlideshow()
        slideshow.zoomEnabled = true
        slideshow.contentScaleMode = UIViewContentMode.scaleAspectFit
        slideshow.pageControlPosition = PageControlPosition.insideScrollView
        // turns off the timer
        slideshow.slideshowInterval = 0
        slideshow.autoresizingMask = [UIViewAutoresizing.flexibleWidth, UIViewAutoresizing.flexibleHeight]

        return slideshow
    }()

but when I change pageControlPosition to pageIndicatorPostion, it is said that pageIndicatorPostion doesn't have insideScrollView method

I am using pod 'ImageSlideshow', '~> 1.6'

Hi, I'm using the slideshow and it only makes one transition for me (regardless of the time interval I've set, or how many images I've loaded in the input array). I have the slideshow in multiple places in my app, and this happens in every single place. I've tried mirroring the example given as closely as possible.

Thanks!

Hi there. When the image is in fullscreen mode and I try to exit fullscreen. The App crashes and goes back to Root View (LoginPage). Has this happened to anyone else?

I am running a separate app and it works fine. My code is following the instructions.

Can anyone help?

Also can anyone think of a way to stop viewDidAppear/Disappear being called when I enter/exit fullscreen mode?

Thanks

There is no way that the SDWebImageSource class finds me, whereas the ImageSource works without problems.

`let ab: [InputSource] = items.map { SDWebImageSource(urlString: $0.url)! }

    slideshow.setImageInputs(ab)`

Use of unresolved identifier 'SDWebImageSource'

I've load "import SDWebImage"

Any ideas? Thnks!

Each of our reusable tableview cells have an imageslideshow. When scrolling, the memory jumps from 30mb to 160mb and cpu from 0 to 70%. The memory remains at 160mb even though we dequeue our tableview cells. The only code we have for imageslideshow is setting the image inputs via SDWebImageSource.

We tried a device on iOS 10.3.3 and this issue doesn't occur. Devices we try on iOS 11 have this issue.

Any ideas?

All the settings are working just fine. Although "zoomEnabled" does not seem to have any effect on the sideshow.

This is the code

var images = self.photos.map { (photo) -> KingfisherSource in
  return KingfisherSource(urlString: photo.imageUrl)!
}
self.slideshow.setImageInputs(images)
self.slideshow.setCurrentPage(self.startPosition, animated: false)
self.slideshow.circular = false
self.slideshow.zoomEnabled = true
self.slideshow.pageControlPosition = .hidden

What I am looking for is, either a doubleTap to zoom the image or pinch gesture.

Any thoughts on this?

When I have multiple images in my slideshow and set slideshow.circular = false, then click on an image to present in full screen would not present the current image I tapped. It would actually load the previous image! So I guess the index of the initial image is not set properly when the full screen is presented.

Forget to mention I'm using the swift-3 branch :)

Here is code i try to set it to new images which are downloaded self.homeSlideShow.setImageInputs(convertToAlmofireSource(sliderImages))

//Code for getting data

Alamofire.request(apiMethod("banners"), createUrl("banners", getPram: ["":""]), headers: headers)
            .responseSwiftyJSON({ (request, response, json, error) in
                if error == nil {
                    let jsonData = json
                    if jsonData["error"].bool == false {
                        sliderImages.removeAll()
                        for item in jsonData["data"]{
                            sliderImages.append(createImgUrl("banners", imgName: item.1["img"].string!))
                        }
                        dataSource.setValue(sliderImages, forKey: "banners")
                        self.homeSlideShow.setImageInputs(convertToAlmofireSource(sliderImages))

                    }else if jsonData["error"].bool == true {
                        self.presentViewController(createAlert(jsonData["message"].string!), animated: true, completion: nil)
                    }
                }else{

                    self.presentViewController(createAlert("internet"), animated: true, completion: nil)

                }
            })

//convert function

func convertToAlmofireSource(images: [String]) -> [AlamofireSource]{
    let img = images
    var sliderImg = [AlamofireSource]()
    for item in img {
        sliderImg.append(AlamofireSource(urlString: item)!)
    }

    return sliderImg
}

Everthing works fine just it show white screen when i load new images

Hi all I am using this library and i dont know way how to use these feature configure

slideshowInterval - slideshow interval in seconds (default 0 – disabled) zoomEnabled - enables zooming (default false) circular - enables circular scrolling (default true) Can you help me?

Thanks all

When I scroll from the first image backward to the last one, sometime the slider will blink (please refer the video around 3-4 sec). I am using preload with fixed(offset: 1) to have that issue. If I switch to preload all images, that will not blink.

P.S. Not sure if that related to the "loadImage()" and "releaseImage()" function. P.P.S. I am using KingfisherSource

Thanks for the help.

https://user-images.githubusercontent.com/49747552/180423680-54438ead-bbcc-4444-bdd1-72e5b14656d3.mov

I'm using CI to build my App. So I can't change the target.

/Users/[REDACTED]/git/Pods/ImageSlideshow/ImageSlideshow/Classes/InputSources/KingfisherSource.swift:13:8: compiling for iOS 10.0, but module 'Kingfisher' has a minimum deployment target of iOS 12.0: /Users/[REDACTED]/Library/Developer/Xcode/DerivedData/KirOps-fyjarvswqgnloecwjincivxnewga/Build/Intermediates.noindex/ArchiveIntermediates/KirOps/BuildProductsPath/Release-iphoneos/Kingfisher/Kingfisher.framework/Modules/Kingfisher.swiftmodule/arm64-apple-ios.swiftmodule

Even when I changed the transition from the page on which the image slide show is implemented, the SlideShow timer Still worked. how to stop imageSlideshow?