This pull request adds all the files for a first review of the photo pod.

It includes the sample project and pod files, and fully documented public interfaces for all objects. The project also supports iOS 7 (boooooo) and iOS 8. It so far only includes unit tests for NYTPhotosViewController. Since this includes many files, I'd recommend opening up the workspace and looking at the class files there.

The entire pod starts with NYTPhotosViewController, which is intended to be the only class that clients will be dealing with. If I could make every other class private, I would.

There are a couple things that are not yet supported, like working with a push transition or client hiding of the status bar. These may or may not be in the first pod release, but also are the lowest priority.

Demonstrates use of NYTPhotoViewer from an app written in Swift with UI and unit tests

• Note that this PR includes a workaround for the iPad issue in which tapping Share from the built-in NYTPhotosViewController causes a crash. Although the crasher will be fixed in the underlying pod, the workaround provides a simple demonstration of passing a closure that would otherwise be unnecessary.
• Minimum deployment target is 8.2 (current release as of initial pull request).
• This version supports the Swift 1.1 feature set (using a singleton for the provider) avoiding language improvements still in beta.
• Requires Xcode 6.2 release SDK to build and run. Clone this repo, open the workspace under the Example folder and set the scheme to NYTPhotoViewer-Swift.

Added 2nd Target

(avoiding the '[target 2] has source overlapping sources' problem with a symlink)

    targets: [
        .target(
            name: "NYTPhotoViewer",
            path: "NYTPhotoViewer"
        ),
        .target(
            name: "NYTPhotoViewerGIF",
            dependencies: ["PINRemoteImage"],
            path: "SourceSymLink",
            cSettings: [
              .define("ANIMATED_GIF_SUPPORT", to: "1")
            ]
        )
    ]

Tweaked imports in 3 files by changing

#import <PINRemoteImage/FOO.h>

to

#if SWIFT_PACKAGE
  #import "FOO.h"
#else
  #import <PINRemoteImage/FOO.h>
#endif

Adds Carthage support by:

• Adding a framework scheme and sharing it
• Adding a bridging header which includes

#import <NYTPhotoViewer/NYTPhotosViewController.h>
#import <NYTPhotoViewer/NYTPhoto.h>
#import <NYTPhotoViewer/NYTPhotosOverlayView.h>

• Creating a symlink to the pods project file in the root directory.

Related Issues

• Closes #61
• Closes #62

I am hoping to start a conversation here so that we can direct this at the cocoapods team, but right now using the latest beta NYTPhotoViewer doesn't build and instead outputs the following error:

error: /Users/Path/To/Build/Products/Debug-iphonesimulator/NYTPhotoViewer/NYTPhotoViewer.bundle: No such file or directory

This works on the latest release of cocoapods (0.39.0 I think) but on the betas its broken.

It seems to me that cocoapods has broken the usage of resource_bundle (used here) in the new releases.

Funnily enough Google use the resources property (here) and this seems to be working.

I will submit a bug with cocoapods but I thought it should have visibility here too

When I try to install it through cocoa pods it says NYTPhotoViewer(1.2.0) as the latest version?

Has it come through on to the cocoaPods server yet if there is one?

What it does

Respects the safe area layout guide for the caption view and the top items (https://github.com/NYTimes/NYTPhotoViewer/issues/246).

Thanks so much to @matthiaskmt for submitting this PR: https://github.com/NYTimes/NYTPhotoViewer/pull/247. We decided to go a slightly different route by adding a delegate method photosViewController:captionViewRespectsSafeAreaForPhoto: to allow the client to choose if they want their caption view to adhere to the safe area insets. If a caption has a background view the client may want those colors/gradients/etc. to extend to the edges of the screen.

Allow developers to show the status bar with navigation bar buttons without overlaps. If gallery is showed with visible status bar the navigation buttons overlaps it, with this small change you can set to move content origin under status bar to prevent it.

Before:

After:

Code:

private class PhotosViewController: NYTPhotosViewController {
    override var prefersStatusBarHidden: Bool {
        return false
    }
    
    override var preferredStatusBarStyle: UIStatusBarStyle {
        return .lightContent
    }
}

let viewer = PhotosViewController(photos: [photo], initialPhoto: photo, delegate: nil)
viewer.underStatusBar = true
self.present(viewer, animated: true, completion: nil)

Steps to Reproduce

1. Run either of the sample projects.
2. Tap the photo.

Expected Results

An “X” button called NYTPhotoViewerCloseButtonX is displayed in the upper left corner of the view controller.

Actual Results

No “X” button is displayed and the nyt_photoViewerResourceBundle method returns nil.

Platform and OS

Tested both Swift 2 (with minor changes to get it to compile) and Objective-C sample projects as well as another project.

Xcode Version 7.2 (7C68)

Added viewWillAppear:animated and viewWillDisappear:animated to delegate. Now you can control status bar hidded state if you present from UINavigationController and prevent close and share buttons overlap.

Add support for Swift Package manager by adding a package manifest and creating a few symlinks where the current directory structure of the project was a bit inconvenient or even incompatible with representation in the package manifest.

This requires version 5.3 of the package manager in order to fully support this project including the bundled images.

Closes https://github.com/nytimes/NYTPhotoViewer/issues/332.

Hello, we're localizing our app and we'd like to extend that to NYTPhotoViewer. It doesn't look like it would be much work, you're already using NSLocalizedString(). We could contribute to this effort. Are you interested?

We add NYTPhotoViewer using Cocopods and in 5.0.8 appeared an issue during application launch

dyld: Library not loaded: /System/Library/Frameworks/LinkPresentation.framework/LinkPresentation
  Referenced from: XXXX/Frameworks/NYTPhotoViewer.framework/NYTPhotoViewer
  Reason: image not found

We're switching from cocoapods to SPM. Added the package...

But I'm getting this. The NYTScalingImageView.m file looks fine to me. The @interface declaration is there above the @implementation. I'm not sure what's missing. Any ideas?

*** Terminating app due to uncaught exception 'UIApplicationInvalidInterfaceOrientation', reason: 'preferredInterfaceOrientationForPresentation 'landscapeRight' must match a supported interface orientation: 'portrait'!'

The navigation bar in the overlayView is using the global values I set in my AppDelegate, but only in iOS 15. My AppDelegate:

if #available(iOS 13.0, *) {
            let ap = UINavigationBarAppearance()
            ap.backgroundColor = UIColor.HBlue()
            ap.titleTextAttributes = convertToOptionalNSAttributedStringKeyDictionary([NSAttributedString.Key.foregroundColor.rawValue: UIColor.white, NSAttributedString.Key.font.rawValue: Constants.Fonts.NavigationItemTitleFont!])!
            UINavigationBar.appearance().scrollEdgeAppearance = ap
            UINavigationBar.appearance().standardAppearance = ap
}
        UINavigationBar.appearance().isTranslucent = false

I've seen this issue, but it's recommended solution didn't work for me. iOS 15 introduces some different changes to UINavigationBar's appearance and I believe that's causing this issue.

Any workaround for this so that the navigation bar on the photo viewer remains transparent?

The issue: