After opening a Gallery, I am encountering 2 problems.

1. In portrait, if there is a large amount of photos, the page control goes outside of the view and looks weird.

2. If I swift the orientation while in the gallery

The pictures go off kilter and don't line up properly and skip.

Is there a way to fix these issues? Love the gallery, just wanted to see if I could touch up a couple things.

For more information about why this is required, please read this blog post: https://whispersystems.org/blog/license-update/

Here is how they resolved the issue:

Additional Permissions For Submission to Apple App Store: Provided that you are otherwise in compliance with the GPLv3 for each covered work you convey (including without limitation making the Corresponding Source available in compliance with Section 6 of the GPLv3), Open Whisper Systems also grants you the additional permission to convey through the Apple App Store non-source executable versions of the Program as incorporated into each applicable covered work as Executable Versions only under the Mozilla Public License version 2.0 (https://www.mozilla.org/en-US/MPL/2.0/).

By using the README recommended code to navigate to a specific page:

present(gallery, animated: true, completion: { () -> Void in
    gallery.currentPage = self.index
})

the result is that the images in the array do not match the index of the pageControl. There is some sort of race condition with presenting the view controller, setting the pageControl.currentPage, and setting currentPage.

when i try to zoom my images they start zooming only to bounce back to their original size and double tap won't work i installed the example and tried it the first two images zooms perfectly but the last one have the same issue as mine here is my code

func openGallery(_ btn: UIButton){
        let gallery = SwiftPhotoGallery(delegate: self, dataSource: self)
        
        gallery.backgroundColor = UIColor.black
        gallery.pageIndicatorTintColor = UIColor.gray.withAlphaComponent(0.5)
        gallery.currentPageIndicatorTintColor = UIColor.white
        present(gallery, animated: false) {
            gallery.currentPage = btn.tag;
        }
        
    }

extension CarInfoVC: SwiftPhotoGalleryDataSource, SwiftPhotoGalleryDelegate {
    func numberOfImagesInGallery(gallery: SwiftPhotoGallery) -> Int {
        return imgArr.count
    }
    
    func imageInGallery(gallery: SwiftPhotoGallery, forIndex: Int) -> UIImage? {
        
        return UIImage(named: imgArr[forIndex])
    }
    
    // MARK: SwiftPhotoGalleryDelegate Methods
    
    func galleryDidTapToClose(gallery: SwiftPhotoGallery) {
        dismiss(animated: true, completion: nil)
    }
}

Hi!

First, thanks a lot for a great lib!

Now, I have a question. Is there a way how to explicitly say which image should be shown when the user opens the gallery? e.g. I have a collection of several thumbnails and I want to open a gallery scrolled to the specific image. Is this possible? I was trying to setup the currentPage property before I present the gallery but it always shows the first image.

Thanks!

I am trying to add a "Share" button to the Photo Gallery and I liked @LunaCodeGirl 's answer from Issue #45 of subclassing SwiftPhotoGallery, however attempting this results in the error: "cannot inherit from non-open class outside of its defining module"

Apparently Swift 3 introduced the 'open' versus 'public' access level as explained in this Stackoverflow answer

So, I tried to achieve my Share button with an Extension instead, but overriding viewDidLoad() in an Extension blocks the superclass viewDidLoad() from being called, even with super.viewDidLoad()

The result of using an Extension to add a share button to the photo gallery is that the Page Control Indicator and Tap to Dismiss Gesture are not functioning, because SwiftPhotoGallery.viewDidLoad() is not being called.

Alas, this is not a detrimental UI failure, seeing as I can add a Close button alongside the Share button. But the eye-catchiness of the Photo Gallery is extremely cheapened without the Page Indicator and Swipe/Tap To Close gesture animations. I guess I'll just replicate the behavior in my class or Extension, if possible, or try method swizzling as described at NSHipster

Please consider updating your package to the 'open' access level so that it may be subclassed as @LunaCodeGirl answered.

See code excerpts, (it doesn't matter where super.viewDidLoad() is in the method, it never gets called-- I added print() statements to SwiftPhotoGallery.viewDidLoad() to check)

extension SwiftPhotoGallery {
    
    public override func viewDidLoad() {
        //super.viewDidLoad()
        
        // create the share button
        let shareButton: UIButton! = UIButton(type: .custom)
        
        // configure the share button
        var buttonImage: UIImage!
        let buttonTintColor: UIColor = UIColor.white
        buttonImage = UIImage(named: "share-alt")?.withRenderingMode(.alwaysTemplate)
        shareButton.setImage(buttonImage, for: .normal)
        shareButton.tintColor = buttonTintColor
        
        shareButton.translatesAutoresizingMaskIntoConstraints = false
        
        var shareButtonConstraints: [NSLayoutConstraint] = []
        
        shareButtonConstraints.append(NSLayoutConstraint(item: shareButton,
                                                         attribute: .top,
                                                         relatedBy: .equal,
                                                         toItem: view,
                                                         attribute: .top,
                                                         multiplier: 1,
                                                         constant: 20))
        
        shareButtonConstraints.append(NSLayoutConstraint(item: shareButton,
                                                         attribute: .trailing,
                                                         relatedBy: .equal,
                                                         toItem: view,
                                                         attribute: .trailing,
                                                         multiplier: 1,
                                                         constant: -16))
        
        shareButtonConstraints.append(NSLayoutConstraint(item: shareButton,
                                                          attribute: .height,
                                                          relatedBy: .equal,
                                                          toItem: nil,
                                                          attribute: .notAnAttribute,
                                                          multiplier: 1,
                                                          constant: 25))
        
        shareButtonConstraints.append(NSLayoutConstraint(item: shareButton,
                                                         attribute: .width,
                                                         relatedBy: .equal,
                                                         toItem: nil,
                                                         attribute: .notAnAttribute,
                                                         multiplier: 1,
                                                         constant: 25))
        
        // Add the share button to the view.
        view.addSubview(shareButton)
        view.addConstraints(shareButtonConstraints)
        view.insertSubview(shareButton, aboveSubview: imageCollectionView)
        
        shareButton.addTarget(self, action: #selector(self.shareButtonClicked(_:)), for: .touchUpInside)
        super.viewDidLoad()
    }

//MARK: - sharing activity methods
    
    // method attached to the Share button to display the Share dialog
    func shareButtonClicked(_ sender: UIButton) {
        let appDelegate = UIApplication.shared.delegate as! AppDelegate
        
        // show the share sheet, passing it the current image being displayed so it can be saved & shared by the user
        displayShareSheet(shareContent: appDelegate.photoGalleryImages[currentPage])
    }
    
    // shows the Sharing system activity screen so that the user can easily save/share app content images;
    // must also add Privacy Permission Description to Info.plist so that the user can save images to the Photos library
    // https://blog.xamarin.com/new-ios-10-privacy-permission-settings/
    // https://developer.apple.com/library/content/qa/qa1937/_index.html
    // https://stackoverflow.com/questions/35931946/basic-example-for-sharing-text-or-image-with-uiactivityviewcontroller-in-swift
    func displayShareSheet(shareContent: UIImage) {
        // instantiate the sharing activity, passing it the image to save/share
        let activityViewController = UIActivityViewController(activityItems: [shareContent as UIImage], applicationActivities: nil)
        
        // must include a sourceView for iPad compatibility (crashes on iPad without sourceView)
        activityViewController.popoverPresentationController?.sourceView = self.view
        
        // display the sharing dialog
        present(activityViewController, animated: true, completion: {})
    }
}

I am appending images from an api which gives me the url. I tried appending url process for UIImage but its not working. Can you please tell me how to do that

I tried out the example that is included. on iPHone 6,7,8 I tested it.

1. When in full screen mode (tap on one of the images)
2. When you have first photo up
3. When going from Portrait to Landscape there are 2 photos. being displayed during rotation.

Your delegate methods need an optional UIImage, however SDWebImage sets an image on an ImageView.

Am I supposed to create a random ImageView and pass back the image I get from SDWebImage?

Or how do I utilize this library with SDWebImage?

Hi,

Only with iOS 12, the image loaded moves down and right after less than a second. I have attached an example:

I'm working to find and fix this issue. @Inspirato, do you have any idea what is happening?

Thanks!

Hello . first of all you have created great library swiftphotogalley. I am downloading images from url and those images I want to show on collectionview . please do help.

Great code, update pageControl when getting "numberOfImagesInGallery" to keep it in sync.

SwiftPhotoGallery.swift file public func collectionView(_ imageCollectionView: UICollectionView, numberOfItemsInSection section: Int) -> Int { let numberOfImages = dataSource?.numberOfImagesInGallery(gallery: self) ?? 0 self.pageControl.numberOfPages = numberOfImages return(numberOfImages) }

When gallery view runs on iPad with multitasking enabled, the image is not placed in centre. Because the size of header and footer was set to screen size which doesn't equal view size in multitasking mode.