Summary

This is a render fix, for both radialGradient and linearGradient to match most of SVG files rendering on WebKit browser like Chrome or Safari.

Current issue

The current implementation for radialGradient && linearGradient contains many issues. Let me show it one by one.

1. <radialGradient> not works for SVGLayeredImageView at all. Always show empty result. (Reason: SVGGradientLayer override drawInContext: method will not works for CA render server, which is used for SVGLayeredImageView hardware-rendering.)
2. <linearGradient> in SVGFastImageView contains strange bounding rects, like the demo SVG images firefox_logo_2013 below. (Reason: Apple's bug for CAGradientLayer on iOS. Works well on macOS, suck)
3. <radialGradient> does not supports standard fx, fy, fr properties, cause many valid SVG render failed.

Changes detail

• Seperate the two class and follow SVG spec about the DOM interface SVGRadialGradientElement && SVGLinearGradientElement.
• Refactory the SVGGradientLayer implementations, to supports correct software-rendering for radial gradienrt && linear gradient. Thansk for IJSVG this third-party framework for code reference. I reference his implementation and port it to SVGKit.
• Supports fx, fy, fr on <radialGradient>

Solved issue

1. Solved. because SVGLayeredImageView using CA render server and hardware rendering. It does not call any of your renderInContext: code. Apple's CAGradientLayer contains a type kCAGradientLayerRadial for radial gradient, So I use this for hardaware-rendering. However, it does not supports any focal point (suck Apple...). Anyway, at least all non-focal point radial gradient can now been rendering on SVGLayeredImageView.
2. Solved perfectly.
3. Solved perfectly using SVGFastImageView. However, these properties will be totally ignored for SVGLayeredImageView (See the reason above)

Compare between fix

See comments below since there are many images.

Demo

I also update the iOS demo because it hard-coded to use SVGFastImageView and I want to test SVGLayeredImageView as well. However, to simplify the review from @adamgit, I create another branch for that changes (only about demo changes, not about Core Framework).

See changes in my fork branch : bugfix_radial_gradient_demo. After all review done, I can create MR again.

Hello

Demo App crashed when choose PreserveAspectRatio on iOS simulator. Simulator running on iOS 8 with iPhone5s setup.

Anyone have same problem?

Warning: Error creating LLDB target at path '/Users/key/Library/Developer/Xcode/DerivedData/Demo-iOS-cufjeqyrxikvkfbxdqvtlbjvypzk/Build/Products/Debug-iphonesimulator/Demo-iOS.app'- using an empty LLDB target which can cause slow memory reads from remote devices.
2014-09-17 17:34:26:405 Demo-iOS[52249:607] [SVGKFastImageView] WARNING: you have initialized an SVGKImageView with a blank image (nil). Possibly because you're using Storyboards or NIBs which Apple won't allow us to decorate. Make sure you assign an SVGKImage to the .image property!
2014-09-17 17:34:26:421 Demo-iOS[52249:2703] [SVGLength] WARNING: you are running on the simulator; it's impossible for us to calculate centimeter/millimeter/inches units correctly
2014-09-17 17:34:26:421 Demo-iOS[52249:2703] Found unexpected preserve-aspect-ratio command inside element's 'preserveAspectRatio' attribute. Command = ''
2014-09-17 17:34:26:421 Demo-iOS[52249:2703] [SVGSVGElement] DEBUG INFO: set document viewBox = {{-1, -1}, {-1, -1}}
2014-09-17 17:34:26:421 Demo-iOS[52249:2703] [SVGKParser] WARN: found a tag with no namespace parser: (</desc>), using default parser(<SVGKParserDOM: 0x7b64bb00>)
2014-09-17 17:34:26:426 Demo-iOS[52249:2703] Allocating static NSCharacterSet containing whitespace characters. Should be small, but Apple seems to take up 5+ megabytes each time?
2014-09-17 17:34:26:426 Demo-iOS[52249:2703] unsupported command A
2014-09-17 17:34:26:427 Demo-iOS[52249:2703] [SVGSVGElement] DEBUG INFO: set document viewBox = {{0, 0}, {30, 40}}
2014-09-17 17:34:26:427 Demo-iOS[52249:2703] unsupported command A
2014-09-17 17:34:26:428 Demo-iOS[52249:2703] [SVGSVGElement] DEBUG INFO: set document viewBox = {{0, 0}, {30, 40}}
2014-09-17 17:34:26:428 Demo-iOS[52249:2703] unsupported command A
2014-09-17 17:34:26:429 Demo-iOS[52249:2703] [SVGSVGElement] DEBUG INFO: set document viewBox = {{0, 0}, {30, 40}}
2014-09-17 17:34:26:430 Demo-iOS[52249:2703] unsupported command A
2014-09-17 17:34:26:430 Demo-iOS[52249:2703] [SVGSVGElement] DEBUG INFO: set document viewBox = {{0, 0}, {30, 40}}
2014-09-17 17:34:26:430 Demo-iOS[52249:2703] unsupported command A
2014-09-17 17:34:26:431 Demo-iOS[52249:2703] [SVGSVGElement] DEBUG INFO: set document viewBox = {{0, 0}, {30, 40}}
2014-09-17 17:34:26:431 Demo-iOS[52249:2703] unsupported command A
2014-09-17 17:34:26:431 Demo-iOS[52249:2703] [SVGSVGElement] DEBUG INFO: set document viewBox = {{0, 0}, {30, 40}}
2014-09-17 17:34:26:432 Demo-iOS[52249:2703] unsupported command A
2014-09-17 17:34:26:432 Demo-iOS[52249:2703] [SVGSVGElement] DEBUG INFO: set document viewBox = {{0, 0}, {30, 40}}
2014-09-17 17:34:26:433 Demo-iOS[52249:2703] unsupported command A
2014-09-17 17:34:26:433 Demo-iOS[52249:2703] [SVGSVGElement] DEBUG INFO: set document viewBox = {{0, 0}, {30, 40}}
2014-09-17 17:34:26:433 Demo-iOS[52249:2703] unsupported command A
2014-09-17 17:34:26:434 Demo-iOS[52249:2703] [SVGSVGElement] DEBUG INFO: set document viewBox = {{0, 0}, {30, 40}}
2014-09-17 17:34:26:434 Demo-iOS[52249:2703] unsupported command A
2014-09-17 17:34:26:434 Demo-iOS[52249:2703] [SVGSVGElement] DEBUG INFO: set document viewBox = {{0, 0}, {30, 40}}
2014-09-17 17:34:26:435 Demo-iOS[52249:2703] unsupported command A
2014-09-17 17:34:26:435 Demo-iOS[52249:2703] [SVGSVGElement] DEBUG INFO: set document viewBox = {{0, 0}, {30, 40}}
2014-09-17 17:34:26:436 Demo-iOS[52249:2703] unsupported command A
2014-09-17 17:34:26:436 Demo-iOS[52249:2703] [SVGSVGElement] DEBUG INFO: set document viewBox = {{0, 0}, {30, 40}}
2014-09-17 17:34:26:437 Demo-iOS[52249:2703] unsupported command A
2014-09-17 17:34:26.438 Demo-iOS[52249:658958] [DetailViewController] WARNING: workaround for Apple bugs: UIScrollView spams tiny changes to the transform to the content view; currently, we have NO WAY of efficiently measuring whether or not to re-draw the SVGKImageView. As a temporary solution, we are DISABLING the SVGKImageView's auto-redraw-at-higher-resolution code - in general, you do NOT want to do this
2014-09-17 17:34:26:439 Demo-iOS[52249:607] [SVGKImage] WARNING: no CALayer tree found, creating a new one (will cache it once generated)
Assertion failed: (CGFloatIsValid(x) && CGFloatIsValid(y)), function void CGPathMoveToPoint(CGMutablePathRef, const CGAffineTransform *, CGFloat, CGFloat), file Paths/CGPath.cc, line 254.

Hi guys,

Thanks for the amazing work on SVGKit.

There is a bug on iOS8.0 that makes the app crash. This also manifests with warnings on iOS7+.

When using SVGKLayeredImageView, once it gets deallocated it sends the following exception:

"*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'An instance 0x7f847d8b8970 of class SVGKLayer was deallocated while key value observers were still registered with it. Current observation info: <NSKeyValueObservationInfo 0x7f847d8b92a0> ( <NSKeyValueObservance 0x7f847d884570: Observer: 0x7f847d8b8970, Key path: showBorder, Options: <New: YES, Old: NO, Prior: NO> Context: 0x0, Property: 0x7f847d894250>"

While on iOS7 the same happens but it does not break the app. I'm aware of a similar issue on the observers added to the DOMTree.viewport and i'm removing those on dealloc. But it does not solve the SVGKLayer issue.

How is it possible to color fill an SVGImage or SVGImageView? I've been trying to loop through the sublayers of these objects and all I get are CALayers that do not have any fillColor property... I can't seem to find any CAShapeLayers anywhere...

Any suggestions?

Is there a way to resize the SVG that is displayed via SVGKit?

I've tried displaying on iOS through SVGView/SVGDocumentView, but they don't seem to respond to frame/bounds changes.

I'm guessing this is because it is added directly as a CALayer and the SVGView doesn't resize its sublayers?

Please let me know if you can provide any insight.

@adamgit Hi. I'm the author of SDWebImageSVGCoder, a SVG coder plugin for SDWebImage (A iOS image loading system). Since I want to support macOS (for simply usage, but not expert user), I found that the readme of this repo, point out to let user to use the MaddTheSane/SVGKit fork.

However, his fork master branch is far away from current 2.x branch and it won't compile on Xcode 10. The author change too much of existing APIs and write some custom logic. So it's not easy to merge. So I decide to try it by myself, by taking minimal changes to current core code to bring it to macOS platform.

For macOS user, we can just simply treate NSImage as UIImage, NSView as UIView, and more, so current UIImage exporter can be also used for macOS. Then, I grab the MaddTheSane's SVGKImageRep class (which is one important for macOS but not iOS). After I fix all the compile issue, it seems the framework can work on macOS now.

No changes to current code on iOS/tvOS user. Just using the alias and fix some cross-platform code to make it work on macOS. You can see the diff. Some changes are related to project structure. For example, we re-defined the same pch files, umbrella header files for each target, however the content are nearlly same so I put them into single one to simplify the problem.

If someone is interested in this, please review this. There may be some little issue (I run a simple demo on macOS and it works. But for large project it may not).

I'm trying to import SVGKit into my Swift tvOS project via CocoaPods and it's not working. I'm a newbie to both Swift development and CocoaPods, so I may be doing something wrong here.

I've added SVGKit to my podfile as such:

pod 'SVGKit', :git => 'https://github.com/SVGKit/SVGKit.git', :branch => '2.x'

There are no errors upon installation and a folder for SVGKit is created (as well as for CocoaLumberjack). But the folder for SVGKit is empty both in the project file as well as on disk. From this point, I have no idea if it actually installed properly, and if so, how to import it.

This post suggests that CocoaPods should work fine but gives no instructions. Issue #189 also asks about using SVGKit with Swift, but the instructions on that thread seem to suggest that I need to manually download/import/configure, something I was hoping CocoaPods would do for me.

Thanks in advance!

With these changes users can use pod 'SVGKit', :git => 'https://github.com/SVGKit/SVGKit.git' to install SVGKit as a Cocoapod. Ideally we would replace the outdated v1.0 that is in the Cocoapods spec repo, but to do that you would have to transition to tagging releases, the podspec works as is but it does throw a warning that it is just pointing to the 1.x branch instead of a tag. The Cocoapod's team doesn't accept pod specs with warnings.

Going forward on development with SVGKit here are a couple things to be aware of.

1. If you add any new source files outside the current directory structure or add new sub directories you will need to update the pod spec's s.ios.source_files to include that path.
2. CocoaLumberjack will be included as a dependency. This means it will use the latest published CocoaLumberjack version, and not the version you have been including in the project so far. This fixes cases where people add SVGKit to their app and they have a conflict since their app or another lib it uses had also included CocoaLumberjack.

I was experimenting with this library and I tried to load one of my SVG's which were manipulated through InkScape, unfortunately with no luck. The renderer was unable to render the file if it had gradient fills in it.

In your demos, this seems to be supported, so I managed to create a minimun implementation to present this problem. The file can be downloaded from http://www.panayotis.com/polygon.svg (unfortunately github didn't allow me to upload an SVG file).

It is a yellow polygon in front of a red square. The red square could be rendered, but the yellow polygon not.

Can you direct me to any solution to this problem? Thank you.

I don't know why and how to fix this but this svg path isn't rendered. It show well in a browser. Am i missing something ?

<?xml version="1.0"?>
<svg xmlns="http://www.w3.org/2000/svg" width="593" height="200" version="1.0" id="ezcGraph">
    <path d="M 2.50,101.00 L 378.40,101.00 A 81.90,57.52 0 0,1 283.45,157.78 Z" style="fill:#000000;" id="ezcGraphCircleSector_51"/>
</svg>

Best regards

Throughout the code you have references to DDLogCWarn and I get many compilation errors because of it. I changed them all to DDLogWarn and it compiles just fine.

However, I also had to change Pods-SVGKit-prefix.pch to import CocoaLumberjack.h instead of DDLog.h to get rid of "implicit declaration" warnings and indeed compilation errors as well for other log levels used.

Is this indeed a bug or am I missing something after I updated my pods?

Synchronous URL loading of xxxxxx.svg should not occur on this application's main thread as it may lead to UI unresponsiveness. Please switch to an asynchronous networking API such as URLSession.

Why?

New Issue Checklist

• [✅] I have read and understood the CONTRIBUTING guide
• [✅] I have reproduced the problem while running in Xcode, and read the Console log, and acted upon any relevant error or warning messages
• [N/A] I have reproduced the problem while running in Xcode's Debugger, and used breakpoints to examine the actual values of variables vs the expected values
• [ ✅] I am not using CocoaPods, or: I am using CocoaPods, but have verified my podspec points to SVGKit v2.x

Issue Description and Steps

Hey everyone! I was wondering if anyone's still had the CocoaLumberjack minimum version issue that has been brought up here before. My project's using SPM and currently I get either one of two errors: A. If my dependency is set on Version: Up to Next Major 3.0.0, then I see:

The package product 'CocoaLumberjack' requires minimum platform version 11.0 for the iOS platform, but this target supports 9.0

B. If my dependency is set on the branch 3.x, then I see:

'CocoaLumberjack/CocoaLumberjack.h' file not found

Not sure if I'm missing something, but has anyone encountered anything similar?

New Issue Checklist

• [x] I have read and understood the CONTRIBUTING guide
• [x] I have reproduced the problem while running in Xcode, and read the Console log, and acted upon any relevant error or warning messages
• [x] I have reproduced the problem while running in Xcode's Debugger, and used breakpoints to examine the actual values of variables vs the expected values
• [ ] I am not using CocoaPods, or: I am using CocoaPods, but have verified my podspec points to SVGKit v2.x

Issue Description and Steps

In some cases when the SVG's width/height is set to auto the app crashes: example svg

*** Terminating app due to uncaught exception 'CALayerInvalidGeometry', reason: 'CALayer position contains NaN: [nan nan]' I've found that if in CSSPrimitiveValue.m in the case of the unhandled CSS_STRING I return a non-zero value (f.e. 600) the app works correctly and SVG is rendered correctly.

New Issue Checklist

• [ x] I have read and understood the CONTRIBUTING guide
• [ x] I have reproduced the problem while running in Xcode, and read the Console log, and acted upon any relevant error or warning messages
• [x ] I have reproduced the problem while running in Xcode's Debugger, and used breakpoints to examine the actual values of variables vs the expected values
• [ x] I am not using CocoaPods, or: I am using CocoaPods, but have verified my podspec points to SVGKit v2.x

Issue Description and Steps

Crashlytics reports:

Fatal Exception: NSInternalInconsistencyException
Update your source code or disable assertions: you are using an iPod that didn't exist when this code was written, we have no idea what the pixel count per inch is!

Fix :

In SVGLength.m change

if( [platform hasPrefix:@"iPod4"]
	   || [platform hasPrefix:@"iPod5"]
	   || [platform hasPrefix:@"iPod7"])
		return 326.0f;

to

if( [platform hasPrefix:@"iPod4"]
	   || [platform hasPrefix:@"iPod5"]
	   || [platform hasPrefix:@"iPod7"])
           || [platform hasPrefix:@"iPod9"])
		return 326.0f;

Can you create new version with .iOS(.v11)?? We have minimal iOS version 11 in app.

If we use 3.0.0 (minimal iOS 9) version we have error with Cocoalimberjack v 3.8.0 (minimal iOS 11)

You can use my last commit

.package(url: "https://github.com/CocoaLumberjack/CocoaLumberjack.git", .upToNextMinor(from: "3.7.0"))

OR update .iOS(.v9) to .iOS(.v11)