When initializing a TORoundedButton in the following way:

let button = RoundedButton(text: "I agree")
button.tintColor = UIColor.appPurple
button.textColor = .white
button.backgroundColor = .white
button.cornerRadius = 4

This is the result:

Tapping on the button makes this glitch go away, because self.titleLabel.backgroundColor = self.isTapped ? [UIColor clearColor] : self.tintColor; is called.

This PR sets the titleLabel's backgroundColor on layoutSubviews to avoid this bug.

While every other framework builds directly into the build folder, somehow this framework ends up in the build/static folder. Any way it can be consistent with others? Thanks!

While trying to install the library using Swift Package Manager in Xcode, I get an error.

TORoundedButton has no Package.swift manifest for version 1.1.2

I have been generating rounded-stretchable images for years (dynamically, with code) to set as the backgroundImage of my UIButtons to the same goal as your library.

This also has the advantage that I get highlight-colorization for free.

It wasn't clear after reading your README why I should instead use your library.

Thanks for your time!

I saw this in the readme

most developers will achieve this look by simply giving a UIButton a solid background, and then using the Core Animation cornerRadius API to round the corners.

As simple as this is, this is gross overkill for a lot of circumstances in which you'd use a buttonI

In the implementation, I saw cornerRadius API

- (void)setCornerRadius:(CGFloat)cornerRadius
{
    // Make sure the corner radius doesn't match
    if (fabs(cornerRadius - _cornerRadius) < FLT_EPSILON) {
        return;
    }
    
    _cornerRadius = cornerRadius;
    self.backgroundView.layer.cornerRadius = _cornerRadius;
    [self setNeedsLayout];
}

So what's the difference? please help me out

I don't know what may be the cause yet, but what I see is that if I use RoundedButton (Swift) inside UICollectionViewCell (added to contentView), it doesn't handle any action. If I switch to UIButton the same addTarget:... start working, this is why I suspect there is maybe something missing in this component.

I use RoundedButton in other places and it works just fine ;)

I really can't explain this behavior more at this point, I'm sorry.

I noticed that calling the roundedButton.isEnabled = false doesn't dim it - which is the case in other UIControls.

I noticed that in all setters _isDirty = YES; [self setNeedsLayout]; are called, and thought about using the same pattern; however, there is no need to layout all the subviews again, so I thought setting alpha directly a more reasonable solution.

Trivial code change allows me to set the button title to a string that contains two lines of text. Example:

let button = RoundedButton() button.attributedText = NSAttributedString(string: "Line 1\nLine2)

See issue #39

I have added a UITapGestureRecognizer to my UIViewController's view and noticed that tapping on the RoundedButton embedeed in that view is also registered by the gesture recognizer. I don't think it's a desired effect

At the moment, the text label in the middle of the button is aligned by simply centering the UILabel in the very middle of the super view.

However, depending on the actual text in the label, depending if the text has any characters with a descender (eg, p or y ), it's possible two buttons lined up would have different vertical alignments of their buttons.

Depending on how UILabel works, this might not be necessary, but just in case, I'll be checking to see if I need to include extra vertical alignment math to properly center the labels.

Stack Overflow reference: https://stackoverflow.com/questions/41981675/in-swift-how-to-get-the-y-position-of-a-text-baseline-of-a-uilabel

This one is actually a better implementation of #15 - It makes more sense to set the containerView's alpha instead of the whole view's alpha.

What do you think, @TimOliver ?

Hi @TimOliver

I love your simple, but powerful implementation of this kind of button - exactly what I need for my apps. I ported this library to Swift 5 - along with the unit tests and the sample app.

If you are interested, I could add you as a collaborator to my private repo, you could have a look, and if you like it, maybe you'd like to release it alongside your Objective-C implementation.

Cheers, Peter

I noticed a strange behavior when setting colors for the button. What I'm doing is simply

            button.tintColor = theme.primary.withAlphaComponent(0.2)
            button.textColor = theme.primary

and label ends up with a strange frame behind it. See the screenshot