For my app, I wanted to customize the stock PageBulletinItem class with additional views so that we have a consistent look and feel between stock and modified Pages. Unfortunately, some parts of PageBulletinItem are public instead of open and can't be overridden, and the stack view of buttons is not available outside of makeArrangedSubviews().

Do you have any interest in exposing additional customization, and/or would you accept a PR for such a feature? I think it could be done cleanly with either additional function variables (like actionHandler), optional protocol funcs, or override-able funcs in PageBulletinItem. These customization points would be called inside PageBulletinItem.makeArrangedSubviews(). Example: open func viewsAboveTitle(_ interfaceBuilder: BulletinInterfaceBuilder) -> [UIView] and so on for the "space" before and after each element: | title | image | description | buttons |

Here's an example I made with a local copy of PageBulletinItem.

class TextFieldPageBulletinItem: CustomizedPageBulletinItem {
    
    fileprivate var errorLabel: UILabel?
    fileprivate var textField: UITextField?
    public var textInputHandler: ((_ text: String) -> Void)?
    
    override func makeArrangedSubviews() -> [UIView] {
        var arrangedSubviews = super.makeArrangedSubviews()
        
        let interfaceBuilder = InterfaceBuilderType.init(appearance: appearance)
        errorLabel = interfaceBuilder.makeDescriptionLabel()
        errorLabel!.text = ""
        errorLabel!.textColor = .red
        
        textField = UITextField()
        textField!.delegate = self
        textField!.borderStyle = .roundedRect
        textField!.returnKeyType = .done
        
        // find the optional stack view of buttons and insert above it
        var buttonStack: UIStackView?
        for view in arrangedSubviews {
            if let bs = view as? UIStackView {
                buttonStack = bs
                break
            }
        }
        if let buttonStack = buttonStack, let idx = arrangedSubviews.index(of: buttonStack) {
            // insert in reverse order
            arrangedSubviews.insert(textField!, at: idx)
            arrangedSubviews.insert(errorLabel!, at: idx)
        } else {
            // insert in correct order
            arrangedSubviews.append(errorLabel!)
            arrangedSubviews.append(textField!)
        }
        
        // since there isn't a method similar to "viewDidAppear" for BulletinItems,
        // we're using a workaround open the keyboard after a certain amount of time has elapsed
        DispatchQueue.main.asyncAfter(deadline: .now() + 0.5) { [weak self] in
            self?.textField?.becomeFirstResponder()
        }
        return arrangedSubviews
    }
}

extension TextFieldPageBulletinItem: UITextFieldDelegate {
    func isInputValid(text: String?) -> Bool {
        if text != nil && !text!.isEmpty {
             return true
        }
         return false
    }
    
    func textFieldShouldReturn(_ textField: UITextField) -> Bool {
        if let text = textField.text, isInputValid(text: text) {
            textField.resignFirstResponder()
            textInputHandler?(text)
            return true
        } else {
            errorLabel?.text = "You must enter some text to continue."
            textField.backgroundColor = .red
            return false
        }
    }
}

In this version, we add support for the Swift Package Manager. To make these changes possible, we decided to make the following breaking changes:

• Require iOS 11
• Remove the possibility to create items in Objective-C

We are planning to release this version on October 25, 2020. During the next month, please reply to this PR with feedback about any bugs or request.

To use the release candidate version, please use the following tag in your package manager: 5.0.0-rc.2

Hi i want to use this library inside my Xcode project but i can't do this because i'm using swit 4.2 and the master branch (installed with pod) use the 4.1 version. The library will be updated ?

Hi, thank you for your great BulletinBoard. Unfortunately, this is broken in IOS 13 in Darkmode, since e.g. the date picker is no longer visible, because the background of the bulletin board is not set by .systemBackground (white on white) Can you look at this please? Maybe you can set the backgrounds via .systemBackground and the font by .label. Thank you and best regards

I can't see a way to tell if the bulletin manager is already displaying an item. This would be super useful in my app if it could be implemented, if not already. Thanks!

New Issue Checklist

• [x] I updated BulletinBoard to the latest version.
• [x] I read the Contribution Guidelines.
• [x] I read the documentation.
• [x] I searched for existing GitHub issues.

Issue Description

Hi 👋, I just installed BulletinBoard 2.0.0 and I get a crash when I'm running my build. I get Thread 1: Fatal error: Unexpectedly found nil while unwrapping an Optional value in BulletinCloseButton.swift, line 50: let glyph = UIImage(named: "CloseGlyph", in: Bundle(for: BulletinCloseButton.self), compatibleWith: nil)!.

It looks like the CloseGlyph image is missing or something. I tried to set requiresCloseButton to false in my BLTNPageItem but it didn't change anything...

I looked into the BulletinBoard pod folder in my project and could find the CloseGlyph image. I can share some code if you need too.

Thanks!

Environment

• BulletinBoard Version: 2.0.0
• iOS Version: 11.3
• Device(s): iPhone 7, iPhone X simulator

Checklist

• [x] I've tested my changes.
• [x] I've read the Contribution Guidelines.
• [x] I've updated the documentation if necessary.

Motivation and Context

More customization for more controls and who doesn't love customization, right?

Description

1. Changed font sizes properties from let to var, making them alterable so users can define font size on their own
2. Added actionButtonCornerRadius and alternativeButtonCornerRadius for appearance in page items, cardCornerRadius for the bulletin card corner radius. (All default to 12)

Example use:

/// Card corner radius
bulletinManager.cardCornerRadius = 20
bulletinManager.prepare()
bulletinManager.presentBulletin(above: self)

/// Action button corner radius, make it rounder
page.appearance.actionButtonCornerRadius = 18

3. Make bulletin cards rounder and match more like when AirPods card shows up for iPhone X. (Default corner radius of 34, I know it's a lot but it does look good with the rounded edges on iPhone X)

Screenshots: This is what AirPods pairing looks like in iPhone X:

If user does not define cardCornerRadius before calling prepare on manager:

When swiping to dismiss a PageBulletinItem, it dismisses correctly but does not trigger the dismissalHandler. The dismissalHandler works fine with tap to dismiss.

New Issue Checklist

• [x] I updated BulletinBoard to the latest version.
• [x] I read the Contribution Guidelines.
• [x] I read the documentation.
• [x] I searched for existing GitHub issues.

Issue Description

After setting up a simple PageBulletinItem providing a title, descriptiontext, actionbuttontitle, alternativebuttontitle, setting isDismissable to TRUE as well as supplying an actionHandler and dismissalHandler. When presenting this item, tapping to dismiss triggers the dismissalHandler where as swiping does not.

Environment

• iOS Version: iOS 11.0.3
• Device(s): iPhone 6s

Checklist

• [x] I've tested my changes.
• [x] I've read the Contribution Guidelines.
• [x] I've updated the documentation if necessary.

Motivation and Context

This fixes the issue #172 Changes were tested with the example application provided.

Description

Fix was done by setting the correct frame in the BulletinPresentationAnimationController when animating the view in. Also fixed couple activity indicator style deprecation warnings.

Problem Description: Tapping on the close button after swiping upwards on the bulletin causes the UI to freeze. I believe this is an issue with the interactive pan gesture and the dismissBulletin method called by the close button.

Steps to reproduce:

1. Display a bulletin with requiresCloseButton = true.
2. Pan the bulletin controller upwards using the gesture. This is tricky but you basically need to pan while holding your finger down. Don't release the gesture.
3. Before releasing the window use your other finger to tap on the close button as many times as needed.
4. Release the finger being used to pan the controller.

Result The bulletin UI will freeze completely. The close button, actions, gesture, background view, and all subviews in the bulletin controller will no longer handle touches.

Expected Result The bulletin should be dismissed.

Notes We've had some users come across this while swiping downwards over the area where the close button is. I think this is the same issue but I could not reproduce it reliably.

Environment:

• Device: iPhone XR
• OS: iOS 12.0
• Version of BulletinBoard: 2.0.2

Checklist

• [x] I've tested my changes.
• [x] I've read the Contribution Guidelines.
• [x] I've updated the documentation if necessary.

Motivation and Context

Issue #97.

Description

Upgrade the Swift version of the framework and sample project from Swift 3 to Swift 4.2.

There is a bug when changing the alternativeButtonTitle: after setting the property the alternativeButton always receives the actionButtonTitle.

See BLTNActionItem.swift#L57:

• wrong: .setTitle(actionButtonTitle, for: .normal)
• fixed: .setTitle(alternativeButtonTitle, for: .normal)

Problem Description: BLTNBoard not building on simulator with M1 Mac

Steps to reproduce: On M1 Mac try to build project importing BLTNBoard via SPM

Environment:

• Device: Simulator
• Version of BulletinBoard: 5.0.0

Links to YouTube video, documentation, etc are all broken.

Sad to see such a great repository with so many stars not be maintained properly /: was really looking forward to using this and I cannot imagine how many people don't want to use after the documentation isn't even properly available/maintained.

Hi! I created a page containing a searchBar and a tableView. When the keyboard appears, the page goes up and the top comes out of the screen. I have tried several things, but I am unable to reduce the size of the tableView so that the search bar stays visible.

Here is my code, simplified, to use and try as is:

import UIKit
import BLTNBoard

class HistoricPage: FeedbackPageBLTNItem {
	
	fileprivate var tableView: UITableView?
	fileprivate var searchBar: UISearchBar?
	
	fileprivate var numberOfItems: Int = 20
	
	override func tearDown() {
		super.tearDown()
		tableView?.dataSource = nil
		tableView?.delegate = nil
		searchBar?.delegate = nil
	}
	
	override func makeViewsUnderTitle(with interfaceBuilder: BLTNInterfaceBuilder) -> [UIView]? {
		let stack = interfaceBuilder.makeGroupStack(spacing: 0)
		stack.alignment = .fill
		stack.distribution = .fill
		
		let searchBar = UISearchBar(frame: .zero)
		searchBar.searchBarStyle = .minimal
		let searchBarWrapper = interfaceBuilder.wrapView(searchBar, width: nil, height: nil, position: .pinnedToEdges)
		self.searchBar = searchBar
		
		let tableView = UITableView(frame: .zero, style: .plain)
		tableView.register(UITableViewCell.self, forCellReuseIdentifier: "CellIdentifier")
		tableView.rowHeight = 38
		let tableWrapper = interfaceBuilder.wrapView(tableView, width: nil, height: NSNumber(value: numberOfItems * Int(tableView.rowHeight)), position: .pinnedToEdges)
		self.tableView = tableView
		
		tableView.dataSource = self
		tableView.delegate = self
		searchBar.delegate = self
		
		stack.addArrangedSubview(searchBarWrapper)
		stack.addArrangedSubview(tableWrapper)
		return [stack]
	}
}

extension HistoricPage: UITableViewDataSource, UITableViewDelegate {
	
	func numberOfSections(in tableView: UITableView) -> Int {
		return 1
	}
	
	func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
		return numberOfItems
	}
	
	func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
		let cell = tableView.dequeueReusableCell(withIdentifier: "CellIdentifier", for: indexPath)
		cell.textLabel?.text = String(indexPath.row+1)
		return cell
	}
	
	func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
		self.searchBar?.resignFirstResponder()
	}
}

extension HistoricPage: UISearchBarDelegate {
	
	func searchBarTextDidBeginEditing(_ searchBar: UISearchBar) {
		// Something to do here to resize tableView/tableWrapper?
	}
	
	func searchBar(_ searchBar: UISearchBar, textDidChange searchText: String) {
		if let text = searchBar.text, let numberOfItems = Int(text) {
			tableView?.setContentOffset(.zero, animated: true) // scroll to top
			self.numberOfItems = numberOfItems
			self.tableView?.reloadData()
			// Something to do here to resize tableView/tableWrapper according to number of items?
		}
	}
}

Thanks for the help anyone can give me 🙏

Checklist

• [x] I've tested my changes.
• [x] I've read the Contribution Guidelines.
• [x] I've updated the documentation if necessary.

Motivation and Context

This is a Pull Request to fix issue #128. Someone requested that you could change the alignments of the title text, description text as well as the image.

This PR solves that problem.

I tested on Xcode's 12.4 simulators of iPhone 8 and iPhone 12

Description

To change the alignment of title when instantiating a page FeedbackPageBLTNItem() set the page's .titleAlignment to be whatever you want (.left, .right, ect). If a user does not specify then the default alignment is center.

Similarly, to change the alignment of description use the .descriptionAlignment to set to desirable alignment And also to change the alignment of image use the .imageContentMode to set to desirable alignment