It is giving me compilation error for MarqueeLabel 3.2.0, I have not ported my code to 4.2, even using older version of NotificationBanner is giving MarqueeLabel 3.2.0, which is giving me compilation error.

Hello I'm trying to display a StatusNotificationBanner when a match in my application is cancelled, but I think I am making something wrong because this is what happens after a few seconds of the notification being displayed

This is how I am making the call

MyService.instance.cancelRunningMatch { (success) in
            if success {
                let banner = StatusBarNotificationBanner(title: "Match successfully cancelled", style: .success)
                banner.show()
                self.navigationController?.popViewController(animated: true)
            } else {
               print("error when trying to cancel match")
            }
            self.cancelBtn.isEnabled = true
        }

Could you please help me? thanks in advance! Edit: It happens on the simulator (iPhone 7) and on a iPhone 6, but cannot replicate on an iPhone 8

We happened to root caused this issue when the notification was sent after the app became inactive.

We did some code to send the notification, and this part of code was triggered when app become inactive. This causes crash every time, the root cause is bannerPositionFrame is nil.

Hey, awesome library. I was looking through it and thought it would be cool to be able to set your own colors for the default Banner Styles outside of setting the background color directly. Here is a stab at making that possible.

Hi,

I have installed NotificationBanner through Cocoapods and when I build my project, I have the following errors:

Pod install

pod install
Analyzing dependencies
Fetching podspec for `Sensa-Model` from `../../Sensa-Model`
Fetching podspec for `Sensa-Network` from `../`
Fetching podspec for `Sensa-Stylesheet` from `../../Sensa-Stylesheet`
Downloading dependencies
Using Alamofire (4.7.3)
Using AsyncSwift (2.0.4)
Using Freddy (3.0.3)
Using MarqueeLabel (3.2.0)
Using Moya (10.0.2)
Using Nimble (7.3.1)
Using NotificationBannerSwift (1.8.0)
Using ObjcExceptionBridging (1.0.1)
Using Quick (1.3.2)
Using ReachabilitySwift (4.3.0)
Using Realm (3.11.1)
Using RealmSwift (3.11.1)
Using Result (3.2.4)
Using Sensa-Model (1.0.46)
Installing Sensa-Network 1.0.18
Using Sensa-Stylesheet (1.0.6)
Using SnapKit (4.0.1)
Using SwiftMsgPack (1.0.0)
Using XCGLogger (6.1.0)
Generating Pods project
libs NotificationBannerSwift to Swift 3.2
libs NotificationBannerSwift to Swift 3.2
Integrating client project
Sending stats
Pod installation complete! There are 5 dependencies from the Podfile and 19 total pods installed.

Stack

   CocoaPods : 1.5.3
   Ruby : ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-darwin16]
   RubyGems : 2.7.4
   Host : Mac OS X 10.13.6 (17G65)
   Xcode : 10.1 (10B61)
   Git : git version 2.17.2 (Apple Git-113)
   Apple Swift version 4.2.1 (swiftlang-1000.11.42 clang-1000.11.45.1)

When I try to display the notification on a real device it shows that error:

Thread 1: Fatal error: Unexpectedly found nil while implicitly unwrapping an Optional value

On this line:

self.frame = bannerPositionFrame.startFrame

Help please.

xcode 9 macOS 10.12

error log:

mypath/Carthage/Checkouts/NotificationBanner/NotificationBanner/Classes/StatusBarNotificationBanner.swift:49:68: error: type 'UIFont' has no member 'Weight'
        titleLabel!.font = UIFont.systemFont(ofSize: 12.5, weight: UIFont.Weight.bold)
                                                                   ^~~~~~ ~~~~~~
UIKit.UIFont:46:14: note: did you mean 'xHeight'?
    open var xHeight: CGFloat { get }
             ^
mypath/Carthage/Checkouts/NotificationBanner/NotificationBanner/Classes/NotificationBanner.swift:90:68: error: type 'UIFont' has no member 'Weight'
        titleLabel!.font = UIFont.systemFont(ofSize: 17.5, weight: UIFont.Weight.bold)
                                                                   ^~~~~~ ~~~~~~
UIKit.UIFont:46:14: note: did you mean 'xHeight'?
    open var xHeight: CGFloat { get }
             ^

** BUILD FAILED **


The following build commands failed:
	CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler
	CompileSwift normal arm64
(2 failures)

Hello,

I am using Reachability with your NotificationBanner. For example, when there is no internet, I am displaying a status bar notification saying "No Internet Connection". I am facing this very odd bug.

At the top of my ViewController I declare a variable

var isBannerShown = false
var banner: StatusBarNotificationBanner?

I also have a function that fires when reachability changes. It will go off when you go from online -> offline and vice versa.

    func reachabilityChanged(note: Notification) {
        if banner == nil {
            banner = StatusBarNotificationBanner(title: "No Internet Connection")
            banner?.autoDismiss = false
        }
        let reachability = note.object as! Reachability
        switch reachability.connection {
            case .none:
                isBannerShown = true
                banner?.show(queuePosition: .front, on: self)
                self.isNetworkDown = true
                self.sectionIndexes = [:]
                self.tableViewIndexController.tableViewIndex.reloadData()
                self.searchBar.isUserInteractionEnabled = false
                self.sections = []
            case .cellular, .wifi:
                if isBannerShown {
                    print("Banner is currently displayed")
                    banner?.dismiss()
                    isBannerShown = false
                }
                sections = createSections()
        }
    }

This type of behavior is causing the banner to crash. I have no idea why. When I go and comment out

bannerPositionFrame = BannerPositionFrame(bannerPosition: bannerPosition,
                                                  bannerWidth: appWindow.frame.width,
                                                  bannerHeight: bannerHeight,
                                                  maxY: maximumYPosition())

everything works as normal. The app I am working on doesn't deal with different orientations. It is always in vertical mode.

Any suggestions on why this is happening?

Hi! I just discovered this beautiful package and tried this:

let banner = FloatingNotificationBanner(title: "...", subtitle: "....", style: .info)
banner.haptic = .medium

banner.show()

but the banner style shows like the default, not in a floating view, am I doing something wrong?

I'm using XCode 13, swift 5.5, swiftui 3.0

Thanks

It seems like iOS 13 when showing a StatusBarNotificationBanner it appears behind the status bar when i'd expect it to be on top. Working fine on iOS 12 in the Simulator.

Replacing

private let appWindow: UIWindow? = {
    if #available(iOS 13.0, *) {
        return UIApplication.shared.connectedScenes
            .first { $0.activationState == .foregroundActive }
            .map { $0 as? UIWindowScene }
            .map { $0?.windows.first } ?? UIApplication.shared.delegate?.window ?? nil
    }

    return UIApplication.shared.delegate?.window ?? nil
}()

with

private let appWindow: UIWindow? = {
   return UIApplication.shared.keyWindow
}()

solved the problem.

This PR solves the issue with the banners ending up behind the dynamic island. I have tried all on iPhone 14 Pro and Max and also tried it on iPhone 14 to make sure nothing broke.

Things to note:

• Not sure the hasDynamicIsland logic is correct. It worked on the different simulators I tried.
• Not sure I have manipulated the height and the margins in the right place. Maybe there is a better way to do it.
• Not sure the numbers are perfect. Could be some more padding for certain types but not very knowledgable about the project to make it work perfect for all.

Fixes #394

Once you trigger the notifications multiple times, the app crashes. Here are some screenshot of where the error is occurring:

This happens once you activate the notification in an async function that takes some time to execute, for example, fetching some data. It doesn't matter if you put it into a DispatchQueue.main.async { }, it still crashes

I am trying to perform some action after a StatusBarNotificationBanner was tapped. Unfortunately onTap is not triggered.

If I increase the banner height, taps are registered but only up to the statusbar but not in the status bar area. It this expected behavior or is this a bug?

banner.dismissOnSwipeUp = false
banner.dismissOnTap = true
banner.autoDismiss = false
banner.bannerHeight = 200
banner.isUserInteractionEnabled = true
banner.onTap = {
    print("Hello World")
}
banner.show()

It would be great if we have the opportunity to change not only a banner background. In my project, I need to control the corner radius, border width and border colour. I can make these changes myself and create a pull request for you. Just give me some recommendations about how you see that feature in your framework.