This is a complete reorganization of the current file structure. In the process I had to make a few more things 'public' since all the implementations were in one file allowing for shared knowledge.

I don't know if this is something you're looking to do, however I would like to start the discussion about it. This PR supersedes all my other pull (https://github.com/cruffenach/CRToast/pull/122, https://github.com/cruffenach/CRToast/pull/121, https://github.com/cruffenach/CRToast/pull/120, https://github.com/cruffenach/CRToast/pull/115) requests as well as adds a few other features from other users that have mentioned changed in the issues (https://github.com/miwillhite/CRToast/commit/498a731fb818c3aa7e2e5cf2b6a5bb56c8befc9f, https://github.com/cruffenach/CRToast/pull/69). I'm not 100% sure the changes in https://github.com/cruffenach/CRToast/pull/69 are successful & still pass but thats another issue.

Is this something that you would like to do? I feel that it adds a few requested features as well as fixes a few bugs. Maybe not in the same way but I tried to stay consistent to the current codebase. issues with the current code format have been brought up so i felt that refactoring was a decent idea even if it does come at a slight loss of elegance.

This is a gargantuan PR to look over so I totally understand not being super stoked about seeing it :grin: sorry.

I am calling CRToast from UIViewcontroller with below code;

(void) userParamsSaved { NSDictionary *options = @{ kCRToastTextKey : @"Hello World!", kCRToastTextAlignmentKey : @(NSTextAlignmentCenter), kCRToastBackgroundColorKey : [UIColor redColor], kCRToastAnimationInTypeKey : @(CRToastAnimationTypeGravity), kCRToastAnimationOutTypeKey : @(CRToastAnimationTypeGravity), kCRToastAnimationInDirectionKey : @(CRToastAnimationDirectionLeft), kCRToastAnimationOutDirectionKey : @(CRToastAnimationDirectionRight) }; [CRToastManager showNotificationWithOptions:options completionBlock:^{}];

} and get

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid size {320, 0} for item <CRToastView: 0x1093935f0; frame = (-320 0; 320 0); userInteractionEnabled = NO; layer = <CALayer: 0x10932fd70>> in Dynamics'

what i am missing?

I needed the following hack in order to prevent the same toast message from being displayed over and over.

id manager = [CRToastManager valueForKeyPath:@"manager"];
id notification = [manager valueForKeyPath:@"notification"];
NSString *existingTitle = [notification valueForKeyPath:@"text"];
NSString *existingSubtitle = [notification valueForKeyPath:@"subtitleText"];
if ([existingTitle isEqualToString:title] && [existingSubtitle isEqualToString:message]) {
    return;
}

The problem is that if the same message is displayed often, it keeps animating away and back again. I would prefer that it is ignored or that the old toast is replaced without animation.

Is there a better way of achieving my goal?

CRToast automatically handles notification queuing, which is great -- it's essentially fire-and-forget. Currently, there is an optional block that you can provide to be called after a notification shows. Unfortunately, there isn't a way to get notified when a notification is actually being shown.

The scenario here is that several notifications are queued to show, and you want to play a sound / vibration each time a notification is dequeued/shown.

This change simply adds an additional block property to CRToast, and a new constructor that lets the caller provide it. The block is called immediately before the notification is shown.

I did my best to emulate the project formatting / conventions -- if you have feedback, I'm happy to do an iteration or two. Thanks for providing this library -- it's really great.

Thanks,

Andy

This PR enables the ability to set an autorotate flag. This was useful for me to require all toasts to come in through portrait, formerly when a toast came in rotating the device would rotate the status bar.

I'm getting the Status Bar showing up all weird. I'm just using the regular code in viewWillAppear... any ideas? NSDictionary *options = @{ kCRToastTextKey : [NSString stringWithFormat:@"Hello World!"], kCRToastTextAlignmentKey : @(NSTextAlignmentCenter), kCRToastBackgroundColorKey : [UIColor blueColor], kCRToastAnimationInTypeKey : @(CRToastAnimationTypeGravity), kCRToastAnimationOutTypeKey : @(CRToastAnimationTypeGravity), kCRToastAnimationInDirectionKey : @(CRToastAnimationDirectionLeft), kCRToastAnimationOutDirectionKey : @(CRToastAnimationDirectionRight) }; [CRToastManager showNotificationWithOptions:options completionBlock:^{ NSLog(@"Completed"); }];

When using a white status bar, the text goes black right before the notifications show until right after they disappear and then flashes back to white.

Hello,

We've been noticing a pretty large memory leak that causes our app to crash pretty often when a number of these are shown during a session user session. We have an app that shows roughly 80-100 of these in a single session and probably stressing it quite a bit. We've seen that this eventually causes the device to hard reset due to either memory leaking or excessive page allocation. We see that roughly 4-8MB are allocated and freed when a notification is shown from the top.

We've profiled this in Instruments and aren't able to catch much because it seems to be rather elusive. We've pulled the library and replaced with a our own and all crashes have stopped.

Here's our usage that resulted in the memory leaks:

`// // POTPopupManager.m // Potion // // Created by Gabe Brown on 10/15/15. // Copyright © 2015 Potion Incorporated. All rights reserved. //

import "POTPopupManager.h"

import "CRToast.h"

@implementation POTPopupManager

@synthesize staticOptions;

/**

• Class initializer

• @return Instance of POTPopupManager */ +(NSMutableDictionary *)getOptions {

NSDictionary *staticOptions = @{ kCRToastNotificationTypeKey: @(CRToastTypeNavigationBar), kCRToastNotificationPresentationTypeKey: @(CRToastPresentationTypeCover), kCRToastTextAlignmentKey : @(NSTextAlignmentCenter), kCRToastBackgroundColorKey : [UIColor orangeColor], kCRToastAnimationInTypeKey : @(CRToastAnimationTypeSpring), kCRToastAnimationOutTypeKey : @(CRToastAnimationTypeGravity), kCRToastAnimationInDirectionKey : @(CRToastAnimationDirectionBottom), kCRToastAnimationOutDirectionKey : @(CRToastAnimationDirectionTop), kCRToastNotificationPresentationTypeKey: @(CRToastPresentationTypeCover), kCRToastTimeIntervalKey: @(3.0), kCRToastInteractionRespondersKey: @[ [CRToastInteractionResponder interactionResponderWithInteractionType:CRToastInteractionTypeTapOnce automaticallyDismiss:YES block:^(CRToastInteractionType interactionType) { // DO NOTHING } ], [CRToastInteractionResponder interactionResponderWithInteractionType:CRToastInteractionTypeSwipe automaticallyDismiss:YES block:^(CRToastInteractionType interactionType) { // DO NOTHING } ] ] };

NSMutableDictionary *options = [[NSMutableDictionary alloc] initWithDictionary:staticOptions];

return options;

}

/**

• Shows the popup on the main thread and calls the callback / +(void)showPopupWithCompletion:(void (^)(void))completion options:(NSMutableDictionary)options {

dispatch_async(dispatch_get_main_queue(), ^{

[CRToastManager showNotificationWithOptions:options
                            completionBlock:^{
                                if(completion) {
                                    completion();
                                }
                            }];

});

}

/**

• Shows an success popup on the main thread

• @param message The message to display
• @param completion Method called when completed */

+(void)showSuccessPopupWithMessage:(NSString*)message completion:(void (^)(void))completion {

NSMutableDictionary *options = [POTPopupManager getOptions];

[CRToastManager dismissAllNotifications:YES];
options[kCRToastTextKey] = message;
options[kCRToastBackgroundColorKey] = [UIColor colorWithRed:0.20 green:0.69 blue:0.20 alpha:1.0];
options[kCRToastTextColorKey] = [UIColor whiteColor];
[POTPopupManager showPopupWithCompletion:completion options:options];

}

/**

• Shows an info popup on the main thread

• @param message The message to display
• @param completion Method called when completed / +(void)showInfoPopupWithMessage:(NSString)message completion:(void (^)(void))completion {

NSMutableDictionary *options = [POTPopupManager getOptions];

[CRToastManager dismissAllNotifications:NO]; options[kCRToastTextKey] = message; options[kCRToastBackgroundColorKey] = [UIColor blackColor]; options[kCRToastTextColorKey] = [UIColor whiteColor]; [POTPopupManager showPopupWithCompletion:completion options:options]; }

/**

• Shows an info popup on the main thread

• @param message The message to display
• @param completion Method called when completed / +(void)showInfoPopupWithMessage:(NSString)message completion:(void (^)(void))completion duration:(float)duration {

NSMutableDictionary *options = [POTPopupManager getOptions];

[CRToastManager dismissAllNotifications:NO]; options[kCRToastTextKey] = message; options[kCRToastBackgroundColorKey] = [UIColor blackColor]; options[kCRToastTextColorKey] = [UIColor whiteColor]; options[kCRToastTimeIntervalKey] = @(duration);

[POTPopupManager showPopupWithCompletion:completion options:options];

}

/**

• Shows an warning popup on the main thread

• @param message The message to display
• @param completion Method called when completed */

+(void)showWarningPopupWithMessage:(NSString*)message completion:(void (^)(void))completion {

NSMutableDictionary *options = [POTPopupManager getOptions];

[CRToastManager dismissAllNotifications:NO];
options[kCRToastTextKey] = message;
options[kCRToastBackgroundColorKey] = [UIColor colorWithRed:0.59 green:0.04 blue:0.04 alpha:1.0];
options[kCRToastTextColorKey] = [UIColor whiteColor];
[POTPopupManager showPopupWithCompletion:completion options:options];

}

/**

• Shows an info popup on the main thread

• @param message The message to display
• @param completion Method called when completed / +(void)showErrorPopupWithMessage:(NSString)message completion:(void (^)(void))completion {

NSMutableDictionary *options = [POTPopupManager getOptions];

[CRToastManager dismissAllNotifications:NO]; options[kCRToastTextKey] = message; options[kCRToastBackgroundColorKey] = [UIColor colorWithRed:0.59 green:0.04 blue:0.04 alpha:1.0]; options[kCRToastTextColorKey] = [UIColor whiteColor]; [POTPopupManager showPopupWithCompletion:completion options:options];

}

@end`

This accounts for an 'edge' case where we have centered text & a centered accessory view. To account for this we move the accessory off to the left side so that the text can remain centered while not covering it up with said accessory view.

This may not be the prettiest solution so I'm open to suggestions if anyone has them.

Took screen shots of the results

cc @nmock, @jadar

It will be great to have toast at bottom of screen like android snackbar or below the navigation bar like crouton library in android to avoid app rejection of covering the status bar...Thanks

I've been reject twice because of following reason:

After further review, we notice that your app does not comply with the Apple iOS Human Interface Guidelines. 

Specifically, we noticed that your app provides an overlay that partially or totally blocks the status bar.

So, using it carefully.

Testing to try to get subtitles in the notification, but it simple will not appear. The following is my options array:

var options:[String:Any] = [kCRToastTextKey: "Morgan: ", kCRToastBackgroundColorKey: UIColor.herGrey, kCRToastTextColorKey: UIColor.herBlack, kCRToastNotificationTypeKey: NSNumber(value: CRToastType.navigationBar.rawValue), kCRToastFontKey: UIFont.herMediumFont(ofSize:16), kCRToastTextAlignmentKey:NSNumber(value: NSTextAlignment.left.rawValue),kCRToastSubtitleTextAlignmentKey: NSNumber(value: NSTextAlignment.left.rawValue), kCRToastSubtitleTextKey: "Hey girl heyyyy", kCRToastSubtitleFontKey: UIFont.herLightFont(ofSize:16), kCRToastSubtitleTextMaxNumberOfLinesKey: 1]

Here is what I see:

This is on iPhone 8 Plus, iOS 11.4.

Is it possible I am missing something ?

I use a toast with icon, title and subtitle. I only want the subtitle to be one line, so setting kCRToastSubtitleTextMaxNumberOfLinesKey to 1.

When the subtitle is some short text, it works fine

but with a longer subtitle there is a strange space between the title and the subtitle

I guess a sizeToFit call is missing somewhere.