Hi there,

I’ve been using this repo for a while now and am really liking it. You did a really good job with it! I ported it to SpriteKit over the last week, and was about to PR it when I had some thoughts.

The most important change is that it’s written in SpriteKit, which means that users would have to import that framework as well, adding to their app’s binary size. SpriteKit will be way more “expensive”, storage-wise, than this framework, which might be problematic especially given cellular download limits.

Users of a mature framework might not be okay with having to add SpriteKit in order to continue to use new versions, which is why I’m posting this as an issue instead of directly PRing.

I’m happy to open a PR so that the existing implementation can be replaced with my SpriteKit port, or I can upload it as a new project (crediting you as the original creator, of course), depending on whichever way you’d like to go with this.

Please let me know how you’d like to proceed. Thanks for making this!

I currently have the progress view in a table view cell. The progress value sets correctly, but there is no animation, despite using UIView.animate. Other animations work fine. It seems that upon reloading the cell, animation works correctly.

I was seeing this issue as well with my app, but have now found an easy way to reproduce:

1. Check that you have the latest Xcode version, which currently is 11.4, earlier versions are fine
2. Download sample project
3. Edit the scheme ProgressRingExample to use the "release" build configuration (see screenshot)
4. Connect an iPhone to your computer and select that device to run the app on

This will result in a crash: GradientGenerator.swift line 113: let img = ctx.makeImage()!

I am trying to animate the .progress property witch works wonderful within a UIView.animate block. I want to have control over the animation progress though, so I put it within a UIViewPropertyAnimator (so I can manipulate the animator.fractionComplete property). This doesn't seem to work. Is there something special to keep in mind for animating the RingProgressView?

I would like to have the possibility not to show a single "dot" if progess is 0.0, and simply only show the backdrop shadow ring. I've provided a possible solution for this, though I'm not sure that the naming is optimal.

I would like to hear your thoughts on this.

I have a framework that I have built myself, with its own podspec and one of its dependencies is MKRingProgressView. Note that my framework and the rest of its dependencies are written in objective-c.

pod lib lint does validate successfully with my framework's podspec, although whenever I do a pod install on another project with my framework, I get this error on the MKRingProgressView framework whenever I try to compile:

The "Swift Language Version" (SWIFT_VERSION) build setting must be set to a supported value for targets which use Swift. This setting can be set in the build settings editor.

Isn't it necessary that MKRingProgressView needs to specify the swift version in its podspec as well?

Also, it looks like a few of open var are not translated as properties when MKRingProgressView-Swift.h is imported out of an objective-c project. Adding the @objc attribute to these variables may fix it.

Hello,

I have two rings inside of a standard UIViewController, and when I add the second one it says

"MKRingProgressView was compiled with optimization - stepping may behave oddly; variables may not be available."

When the app crashes.

Also, I am getting a error: IB Designables: Failed to render and update auto layout status for HomeViewController (h2x-s1-kZZ): The agent crashed

Any idea what could be causing this?

We really like this Pod!

We are actually using the progress rings for a timer but love that it looks like the native watch rings. That being said we were wondering if it was possible to make the progress evenly incremented without updating progress every second.

We were doing the update every second but the progress than "stepped". We did the below code once a second in a Timer.scheduleTimer. The variable progress is the % of seconds left (ex: 25/30) with the view saying 25 seconds.

CATransaction.begin() CATransaction.setAnimationDuration(1.0) timer.progress = progress // updated every second CATransaction.commit()

Instead we moved to this approach where we start the Timer and start the progress animation to have a duration of the full countdownSecs (ex: 30 seconds). Note we setup the progress ring before this to have progress = 1.0.

CATransaction.begin() CATransaction.setAnimationDuration(Double(countdownSecs)) timer.progress = 0.0 CATransaction.commit()

We think this looks smoother as an animation but the progress is no longer incrementing in even values.

Example: If the timer is for 30 seconds, when the ring is half full we expect the time to be 15 seconds.

Is there a way to make this progression even?

Thanks for the library!

I noticed the rings weren't accessible to a screenreader user, so I thought it might be worth adding. The only additional property I've added is the identifier: String? in MKRingProgressView and it is optional.

The reason these are computed properties is mostly to account for updated frames on rotation. Also, note that grouped accessibility overrides individual accessibility, but this is intentional and supports users of the library that use them grouped or one at a time.

Happy to make changes as needed.

I’d love to have the ability to update a ring’s progress without any animation. When displaying multiple rings in a single view controller, if you animate rings as they appear, you have to watch the animation multiple times as you scroll and that gets tiring, and if you try to instead animate them all at once, this can cause a drop in framerate. So being able to selecting statically update rings would be nice.

Hello when i am upgrading MKRingProgressView 2.2.2 to 2.2.3 It gives us the error below

libsystem_platform.dylib 0x19f07e554 _platform_memmove + 100 1 CoreGraphics 0x1a6333738 CGDataProviderCreateWithCopyOfData + 220 2 ??? 0x0 (Missing) 3 ??? 0x0 (Missing) 4 MKRingProgressView 0x1033cc210 $s18MKRingProgressView04RingB5LayerC11drawContent33_772FEB58C33FFBD64D515695F0C0FBB5LL2inySo12CGContextRefa_tFSo07CGImageQ0aSgyXEfU1_Tf4nnnnx_n + 680 5 MKRingProgressView 0x1033caf78 $s18MKRingProgressView04RingB5LayerC11drawContent33_772FEB58C33FFBD64D515695F0C0FBB5LL2inySo12CGContextRefa_tF + 2208 6 MKRingProgressView 0x1033cc56c $s18MKRingProgressView04RingB5LayerC12contentImageSo10CGImageRefaSgyFySo010UIGraphicsG15RendererContextCXEfU_TA + 44 7 MKRingProgressView 0x1033cc5a0 $sSo30UIGraphicsImageRendererContextCIgg_ABIegg_TRTA + 20 8 MKRingProgressView 0x1033ca6c4 $sSo30UIGraphicsImageRendererContextCIegg_ABIyBy_TR + 36 9 UIKitCore 0x1a30a99b4 -[UIGraphicsRenderer runDrawingActions:completionActions:format:error:] + 432 10 ??? 0x0 (Missing) 11 ??? 0x0 (Missing) 12 ??? 0x548a681033ca580 (Missing) 13 MKRingProgressView 0x1033ca3f8 $s18MKRingProgressView04RingB5LayerC7displayyyFTo + 28 14 QuartzCore 0x1a5f552dc CA::Layer::layout_and_display_if_needed(CA::Transaction) + 428 15 ??? 0x0 (Missing) 16 ??? 0x0 (Missing) 17 ??? 0x0 (Missing) 18 ??? 0xb5014019f2f3500 (Missing) 19 ??? 0x241e55019f2ee200 (Missing) 20 ??? 0x0 (Missing) 21 ??? 0x0 (Missing) 22 ??? 0x0 (Missing) 23 ??? 0x68537301a3479400 (Missing) 24 ??? 0x0 (Missing) 25 libdyld.dylib 0x19f16ce18 start + 4*

We have also downgrade the version to 2.2.2 , but gives us the error

Please help us with this issue,

Thanks in advance

Hi @maxkonovalov,

Can we expect a new version to be released supporting Swift versions > 5.7? Also will this library be kept up to date with newer versions for now at least?

Kind regards, Stefan

I notice rings 'blinking' when I put them in collection view.

When I reload data, cells are reused and updated with the new progress. However, I can see that the ring is presenting the old values and its progress is updated after few miliseconds.

I'm still debuging this but it seems to be connected with MKRingProgressLayer trying to animate the progress even though it's not in a UIView.animate { ... }.

I'm trying to use the example application with the Xcode 9 and iOS 11 GMs here, and seeing significant performance differences between the two.

On my mid-2014 15-inch MacBook Pro, the example app absolutely flies, working perfectly, pretty much. Meanwhile, on my 6s Plus, it's dropping frames left, right, and centre. I tried messing with the usual suspects (clear memory, low power mode, etc.) but device just keeps dropping frames.

I know there's a performance difference between simulator and device, but it usually tends to be in the device's favour, especially with graphics stuff. There's also an OpenGL simulator bug in the GM, which might be at play here: https://twitter.com/xenadu02/status/911463433521860609

Any ideas for increasing on device performance? I tried but can't seem to find any way to toggle CPU-based rendering like with CIContext, for example.

Thanks

I am using this ring progress view inside a collection view. When i start scrolling the collection view and the collection view creates another cell, it is not smooth. I used instruments to see what could be the problem and i noticed that the heaviest function was the method contentImage in the MKRingProgressView class.

Can you please try to see if is there any way to improve performance? Thank you