Hi, @Codeido Thanks for accepting my PR.

We have a problem in previous PR's implementation 😶: Everythings works OK if the developer configures the button only through the storyboard. But, if there is a need to change the title of the button programmatically, then a problem arises:

button.setTitle("Button title", for: .normal) // Won't change the title

The cause of the problem was the getAttributedString() method, which always returned the value .attributedText and ignored the value of .text;

I fixed the issue. Now we have a flexible function:

// Get the NSMutableAttributedString with kern value: optional("string") ?? "";
// Button's previous attributedText is kept, only mutableString value is changed.
private func getAttributedString(with string:String?, letterSpacing spacing:CGFloat) -> NSMutableAttributedString {
    var attr:NSMutableAttributedString!
    if let string = string, let attrText = self.titleLabel?.attributedText {
        let attrString = NSMutableAttributedString(attributedString:attrText)
        attrString.mutableString.setString(string)
        attr = attrString
    } else {
        attr = NSMutableAttributedString(string:string ?? "")
    }
    
    attr.addAttribute(NSAttributedStringKey.kern, value: spacing, range: NSRange(location: 0, length: attr.length))
    return attr
}

In the future PR with another attributed string features, we may create another common private function which will return titleLabel's NSMutableAttributedString with a single string parameter.

Thanks!

Hello! I've placed UIButton in my storyboard and tried to type PMSuperButton in class, but there is no PMSuperButton. If wrote it there, then error: Unknown class PMSuperButton in Interface Builder file. But in .swift files I can import PMSuperButton , create and works with them. Thanks!

You can find more about it here.

https://stackoverflow.com/questions/39732312/xcode-8-ib-designables-failed-to-render-and-update-auto-layout-status-the-a

Add file manually to project

The following errors appear for each open var: Overriding declaration requires an 'override' keyword Overriding non-open var outside of its defining module

xcode: Version 10.1 (10B61) swift: version 4.2.1

I'm trying to use the method showLoader(), the loader appears and spins but the text does not hide as shown in the example in the first part of https://github.com/pmusolino/PMSuperButton.

Rounded button with shadow and gradient doesn't show up properly.

If I set clipToBounds to true, button is rounded, but shadow disappears (obviously).

Hi,

I have created a UIButton and added the PMSuperButton class, it does show the Super Button inspector properties, in the preview it also renders the changed property. But once build to the device nothing shows up.

Any ideas?

Thanks,

Niels

Hi, Really love this button. Tried a lot of other buttons out there, but I've found this one special, because of rounded borders 😉

I think buttons with letter spacings look nice and modern. So, I thought it would be handy to have it in PMSuperButton.

` let myFirstButton = PMSuperButton.self

    myFirstButton.setTitle("✸", for: .normal)
        myFirstButton.setTitleColor(.blue, for: .normal)
        myFirstButton.frame = CGRect(x: 15, y: -50, width: 300, height: 500)
        myFirstButton.addTarget(self, action: #selector(pressed), for: .touchUpInside)

`

Here's my code, it's probably pretty nubby. Just trying to find a way to programmtically add the button and edit it with your creation.

Major Feature (Haptic Feedback)

• In this push haptic feedback feature is added.
• Other than that no codes are changed.
• Since haptic feedback is available from iOS 10 so I had added a security check for iOS detection in the code.
• Indentation is followed
• No empty line left
• Markdown provided
• code is simplified, at most possible

@pmusolino do have a look and if possible do merge it. If you find any changes do ping me happy to correct it.

Happy Coding Gokul Nair

Hi @pmusolino I saw your framework PMSuperButton, its quite interesting. I know this repo had been inactive for a bit long, but why not provide it a new life. Actually I am really interested in contribution into the repo. I have an amazing feature for your PMSuperButton. With the immense improvement in UX Apple brought Haptic Feedback into their phones, so why not use that exceptional feature into your framework. It will be really amazing. This small piece of addition will really help to advance your framework.

With this we can start redesigning this framework. We can add various new features which this framework is lagging. So if you are interested in adding Haptic Feedback do tell me, I will create a PR and Push the file.

Do give a response, this will help me to know the status, so that I can work further on this project.

I have the code ready, ts just your approval and I can make an PR.

When using SPM to get the library in Xcode I got this error :

I fixed it by not specifying a version number for the package but by directly pulling the master branch. It would be better to get it working with versions numbers (for example 3.0.0 < 4.0.0).

Hi, I'm adding buttons programatically. This is what I have and I can't seem to get the background image, shadow and animation working. All works when I add a button in storyboard view.

            let button = PMSuperButton() //UIButton()
            let bgrImage = UIImage(named: "someImage")
            //button.setImage(bgrImage, for: .normal) //-> this works ok
            button.setBackgroundImage(bgrImage, for: UIControl.State.normal)
            

            button.shadowColor = UIColor.gray
            button.shadowOffset = CGSize(width: 2, height: 2)
            button.shadowRadius = 2
            button.shadowOpacity = 2
            button.animatedScaleWhenSelected = 1
            button.animatedScaleWhenHighlighted = 1
            button.animatedScaleDurationWhenSelected = 1
            button.animatedScaleDurationWhenHighlighted = 1

Any idea what am I doing wrong?