I'm getting the following error on iOS 10. This is a new error so not seen a lot on Stackoverflow about this: http://stackoverflow.com/questions/39565424/swift-uiviewreportbrokensuperviewchain-cause-by-layer-manipulation

Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'View has lost track of its superview, most likely through unsupported use of CALayer API on the view's layer. If this isn't a crash yet, it will be in the near future. Problem view: <UIView: 0x7e70e630; frame = (0 0; 72 205); alpha = 0; layer = <CALayer: 0x7a6521b0>> Expected parent: <ZFRippleButton.ZFRippleButton: 0x7a906fb0; baseClass = UIButton; frame = (528 12; 72 205); opaque = NO; autoresize = RM+BM; layer = <CALayer: 0x7e7144e0>> Break on UIViewReportBrokenSuperviewChain to debug.'

I'm addressing a UIViewReportBrokenSuperviewChain issue which makes my app to crash. My buttons are added on the view using Interface Builder, no code. They were working fine on Xcode 7 / iOS 9. No changes are made with Xcode 8 / iOS 10, I just opened the project, run it on a real device and get this crash.

I'm using ZFRippleButton 0.5.1.

2016-10-21 10:02:48.620067 Cinemappy[9732:2494425] *** Assertion failure in void UIViewReportBrokenSuperviewChain(UIView *__strong, UIView *__strong, BOOL)(), /BuildRoot/Library/Caches/com.apple.xbs/Sources/UIKit/UIKit-3599.6.1/UIView.m:190
2016-10-21 10:03:05.951306 Cinemappy[9732:2494425] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'View has lost track of its superview, most likely through unsupported use of CALayer API on the view's layer. If this isn't a crash yet, it will be in the near future. 
    Problem view: <UIView: 0x15fc91740; frame = (0 0; 1000 1000); alpha = 0; layer = <CALayer: 0x1746298c0>>
    Expected parent: <ZFRippleButton.ZFRippleButton: 0x15fc90b40; baseClass = UIButton; frame = (0 0; 1000 1000); opaque = NO; autoresize = RM+BM; tintColor = UIExtendedSRGBColorSpace 1 1 1 1; layer = <CALayer: 0x174821f20>>
Break on UIViewReportBrokenSuperviewChain to debug.'
*** First throw call stack:
(0x1894dc1c0 0x187f1455c 0x1894dc094 0x189f66898 0x18f604f9c 0x18f605658 0x18fc7b390 0x189f122bc 0x189f07ab8 0x189f0765c 0x189f07444 0x18f42a76c 0x18f42a4d0 0x18f371be0 0x19553fd04 0x19553fad4 0x195553d5c 0x18f6195e8 0x18f33beac 0x1893c91a4 0x1893c90a0 0x18f32ac30 0x18f427330 0x18f61f2c4 0x18f32254c 0x18c7ea40c 0x18c7df0e8 0x18c7defa8 0x18c75bc64 0x18c
libc++abi.dylib: terminating with uncaught exception of type NSException

Too long touch up animation interval causes slow response to fast consecutive button press! However I know that the original one is more beautiful. So I add an user-defined runtime attribute "fastTouchUpResponse" for developer to make the choice.

I'm getting this error when installing via cocoa pods: libtool: unknown option character `X' in: -Xlinker.

Manually adding the ZFRippleButton.swift file to the project works fine.

Thanks.

Dear team,

When we upgrade the library to support Swift3, when we do such as : rippleButton.rippleColor = UIColor.green, produce error : Failed to set (rippleColor) user defined inspected property on (UIButton): [<UIButton 0x113d20f00> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key rippleColor.

While for the Swift 2 version, we can set it programmatically.

Best Regards,

Hello!

Thank you for fix previews issue. But the code still have errors. You have some methods as private, this methods should be public.

http://joxi.ru/8ZrJodMieDlvmj

            cell.controlButton.rippleBackgroundColor = .grayColor()
            cell.controlButton.rippleColor = .lightGrayColor()
            cell.controlButton.ripplePercent = 1

Can you fix it?

This bug occurs under the following conditions:

1. Autolayout is used. (I use Stack View.)
2. Track touch location is off or default.

In event "layoutSubviews()", the old rippleView.center is kept in order to get touch location from event "beginTrackingWithTouch" when track touch location is enabled. However the center position is always changed when auto layout is used. When track touch location is off, the wrong center position is kept.

I've been using this class for cells in a uitableview, and there are certain cases when the touch ends up cancelled instead of ended. This causes the button to get stuck a state as if it were permanently pressed down.

Consequently I took the code that handled an ended touch and overrode the cancel handler to perform the same action.

Hello first, I really like your button. I was having the same issue as #4 so I've overriden layoutSubviews to update the rippleView and the backgroundView frames. I've also added a corner radius property so as to have rounded buttons. What do you think?

PS I updated the storyboard layout to reflect this change when you rotate the view and made the class @IBDesignable to see the changes immediately. PPS sorry for my bad english

I usually set my frames to CGRectZero on initialize and update the frame later based on the size of the text in the button.

If I work that way, the ripple doesn't show.

Allow public access to ripple views in case user implementations need to add even more subviews, which should be inserted beneath those added by ZFRippleButton.

Hi, your code is clean and awesome and I really appreciate you making it open source. I think supporting Swift 4.2 would make this code more readable and valuable. Thus, this PR.

I really like this library. Now i am facing issue which when i tapped on button then image that i set has been disappeared but when my finger has released then image appears as usual. Can you solve this problem?

button.rippleColor = UIColor.red button.backgroundColor = UIColor.red button.setTitle("File Server", for: .normal) button.setImage(UIImage(named: "filesharing"), for: .normal) button.titleLabel?.font = UIFont(name: "SFCompactText-Regular", size: 16) button.titleEdgeInsets = UIEdgeInsets(top: 0, left: 10, bottom: 0, right: 0)

Hi there,

I've gotten two errors below after updating to Xcode 8.2.1:

Main.storyboard: error: IB Designables: Failed to render and update auto layout status for ViewController (BYZ-38-t0r): dlopen(ZFRippleButton.framework, 1): no suitable image found. Did find: ZFRippleButton.framework: required code signature missing for 'ZFRippleButton.framework'

Main.storyboard: error: IB Designables: Failed to update auto layout status: dlopen(ZFRippleButton.framework, 1): no suitable image found. Did find: ZFRippleButton.framework: required code signature missing for 'ZFRippleButton.framework'

Not sure but maybe it's not related to new update of Xcode.

Thank you, Serhiy

I am using this repository in more then one project and i found this little unexpected behavior which is fixed by writing those lines in the class file. I want this to be on the main repo. Please review and merge if found appropriate. Thank you.