Previous README was a bit outdated and the instructions for backgroundEffect said pullToDismiss?.background instead of pullToDismiss?.backgroundEffect, which confused me so I took a look at the source code and corrected the mistake in case anybody else uses this and is confused

Updates the README to what current source code for PullToDismiss.swift looks like

• UIBlurEffectStyle has been renamed to UIBlurEffect.Style -> this is the error in CustomBlurView: UIVisualEffectView
• .sendSubview(toBack:) has been renamed to sendSubviewToBack(_:) -> this is the error in class PullToDismiss: NSObject

This is in order to prepare the underlying view for any updates that occurred on the view above.

Because the dismiss percentage is abstracted and private, this or something similar is necessary in some applications/instances.

I noticed that this works well with UIPageViewController (embedded within an additional parent, for example) only if resolving the topmost parent UIViewController. I'm assuming that this is probably most ideal in all situations, but that the previous convenience of calling "dismiss" on the closest UIViewController also worked in most instances.

This fixes the issue that I ran into. — An alternative would be to have a weak property that can be overridden to track which UIViewController to actually dismiss in case it's a less typical choice, but I'm guessing that's unnecessary.

@sgr-ksmt Previously README had pullToDismiss?.background instead of pullToDismiss?.backgroundEffect which was wrong and confused me and I figured it out by looking through the source code for PullToDismiss.swift. Thanks again for this repo! 👍

Issue

• Issue Number: #39

Updates the README.md so that it has the correct instructions for changing PullToDismiss's backgroundEffect.

Thanks again for the repo and open sourcing it, using it currently right now in my app and I noticed an issue with the README. Probably going to post a PR soon as its an easy change.

The README says pullToDismiss?.background instead of pullToDismiss?.backgroundEffect for changing the background which is wrong and I figured it out through having to look through the source code PullToDismiss.swift.

Added Objective-C compatibility. Tested in a live production app and it works without any issues. Structs are now classes inheriting from NSObject, and extensions are public. I don't believe this will cause any issues with existing swift integrations, but I'd be happy to look into this further if that is in fact the case.

• [x] Realistic animation #24, #26
• [x] Redesign of ProxyDelegate #25, #27
• [x] Update README.md
• [x] Prepare Migration Guide
• [x] Create unavailable.swift for migration from 1.x.
• [x] Update CHANGELOG.md

As of now, we need some specific delegate methods to make PullToDismiss work. If we want to use delegate methods other than the specific ones, we have no choice but to implement them as a method in PullToDismiss's subclass.

You know, that is not cool. 😢

class CustomPullToDismiss: PullToDismiss {
    func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
        return tableViewDelegate?.tableView?(tableView, heightForRowAt: indexPath) ?? 44.0
    }
}

class SampleViewController: UIViewController {
    @IBOutlet private weak var tableView: UITableView!
    private var pullToDismiss: PullToDismiss?
    override func viewDidLoad() {
        super.viewDidLoad()
        pullToDismiss = CustomPullToDismiss(scrollView: tableView)
        pullToDismiss.delegateProxy = self
    }
}

extension SampleViewController: UITableViewDelegate {
    // called by CustomPullToDismiss
    func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
        return indexPath.section == 0 ? 44.0 : 60.0
    }

    // ...
}

That is why I decided to restructure the design of delegate proxy so that implementing more delegate methods into the subclass will be no longer needed.

Is there a way to specify the hieght of the PullToDismiss view, without having it take up the entire screen? I tried this:

let vc = LikesTableController()
        vc.preferredContentSize = CGSize(width: view.frame.width, height: 200)
        present(vc, animated: true)

but it doesn't work....

func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {

}

this function of UITableView does not work when using PullToDismiss. How to fix it ?????

This doesn't always work: https://github.com/sgr-ksmt/PullToDismiss/blob/master/Sources/PullToDismiss.swift#L173-L175

Example: if you drag a UINavigationController with a UIViewController that has a UIScrollView in it, upward (into negative space) before dragging it downward, it may skip over the detection range of 0 -> 0.5 that's prescribed here, and the status bar is hidden on that view.

Depending on what you're doing, this is an oversight.

Hi, I find the dismiss action too sensitive to drag velocity, so that the modal is dismissed too easily. Is it possible to expose some property (similar to dismissableHeightPercentage property) so that we're able to increase resistance to drag velocity?