We noticed that your app’s main functionality is to market your service, with limited or no user-facing interactive features or functionality. Apps that are primarily marketing materials or advertisements are not appropriate for the App Store.

Please see attached screenshots for details.

The next submission of this app may require a longer review time.

Next Steps

• Review the Minimum Functionality section of the App Store Review Guidelines.
• Ensure your app is compliant with all sections of the App Store Review Guidelines and the Terms & Conditions of the Apple Developer Program.
• Once your app is fully compliant, resubmit your app for review.

Submitting apps designed to mislead or harm customers or evade the review process may result in the termination of your Apple Developer Program account. Review the Terms & Conditions of the Apple Developer Program to learn more about our policies regarding termination.

If you believe your app is compliant with the App Store Review Guidelines, you may submit an appeal. Alternatively, you may provide additional details about your app by replying directly to this message.

This repo has no license information, making it in fact legally not redistributable.

Also, when redistributing the binary form, I'm quite confident you do not follow licenses of used libraries, making it in fact illegal.

Hey @syky27, as mentioned in #11, I did some cleanup at the project:

• [x] Remove dependencies source from repository - #12
• [x] Remove unnecessary dependencies - #11
  • ~I did not remove SwiftyJSON library for now, since the Swift 4 JSON handling is not very convenient in this case~
• [x] Refactor the network layer to be less complicated
• [x] Refactor model objects to into separate files, use multiple menus for one restaurant (simulates food categories)
• [x] Remove unused files and test targets
• [x] Map Xcode project to match 1:1 file system folder structure (default for Xcode 9)
• [x] Move parsing logic out of APIWrapper
• [x] Fix commit messages to match repo style
• [x] Basic error handling

~Since not everything is done, marked the PR as WIP.~ Feel free to add comments and/or proposals. When this PR is merged, issues #8, #11 and #12 may be closed.

This PR introduces CZ/EN localization discussed in #22. All hardcoded strings are now replaced with localized strings based on user's phone preferences.

Localization string keys are converted to name-spaced enum to ensure compile-time check of strings validity. The enums are generated with SwiftGen using aggregated Xcode target.

I have also added Danger action, which checks whether both languages are updated together.

✅ The README is updated.

Hey @syky27! I would like to open discussion about map of restaurants from obedar API.

Context

I am using LunchGuy few times a week and usually, I check only one or two restaurants, since I don't know where the rest of them is located. It would be nice to have:

1. Map view with all restaurants from API
2. Possibility to open restaurant in Google Maps/Apple Maps from menu (for details like ratings, web site, phone numbers, ...)

Proposal

Create new LocationProvider protocol which will return CLLocationCoordinate2D for given restaurant. I saw tomaskadlec/lunch_guy#54 and tomaskadlec/lunch_guy#58 and I know that it's not currently implemented at backend. However, the list of restaurants has now less than twenty items, so we can create static provider. It would simply match restaurant by its name and return coordinates from hardcoded set. Once the backend implements this feature, we can just swap implementation of LocationProvider.

The UI would contain:

1. Navigation bar item in restaurant list, which would switch between map view and list view
   • The map will show pins with restaurants with possibility show its name on tap and then open menu from that
   • This is similar to Yelp app
2. Navigation bar item in restaurant menu, which would open action sheet with possibility to open Google Maps and Apple Maps

What do you think?

Hey @syky27, I would like to propose changes in app localization.

Context

Currently the app is only localized to Czech. However, some strings are displayed in English. We should implement separate localization for both languages and use the one that user has set as default in system preferences. We should also remove the string literals from controllers source code.

Proposal

Create separate localizable.strings files for Czech and English. Then, wen use SwiftGen to generate localization enums so we can get rid off string literals 🎉.

As always, this issue is open for discussion and I can take care of implementation.

I am trying to upload my app to app store. But it got rejected for two time now with "Guideline 4.2.2". I am attaching the screen shots below please suggest what i can do to make this approved.

if you want i can add you to testflight.

This PR adds OSS licenses into iOS Settings app. With this, LunchGuy finally comply to licenses included in its dependencies and fixes #4.

The license plist files are autogenerated using LicensePlist tool which needs to be installed using homebrew explicitly. The Xcode project now also includes aggregated target which runs LicensePlist in background. If the tool is not installed, the target build fails.

I also included action for Danger, which warns whenever the Podfile was updated, but the license plists remained unmodified.

Hey @syky27! As discussed in #16, I started with implementation of static location provider for restaurants. Current state is visible on the attached image.

PR roadmap:

• [x] Create static location resolver for restaurants
• [x] Create simple shared data storage
• [x] Add possibility to switch between list and map views
• [x] Add caption for pins on map
• [x] Open restaurant menu from map
• [x] Open Google Maps/Apple Maps with POI from restaurant menu
• [x] Position map correctly when the app starts
• [x] Add changelog entry

pod 'SwiftyJSON' replace with swift4 native JSON Codable parsing

pod 'RealmSwift' no need to persist anything, Realm was just for testing...

pod 'SwiftFetchedResultsController' This is so useless...

Hey @syky, I would like to open discussion about empty screens design.

Context

Time to time, menus for some restaurants are not available and the screen is empty without any information.

Proposal

For restaurant list and menu detail, we may implement 'empty state'. This would just simple view with illustration and text like "No restaurant available." and "No menu for today.". This does not implement any new feature but makes better UX.

Unfortunately, my taste in graphic is wild and I am not sure if I can design it nicely. I can give it a try, but it would be super cool if someone other made at least draft. If not, I can create some simple designs before implementing it.

Hi. I made a program, and I wont to publish to app store, but app store rejected by Guideline 4.2.2 - Design - Minimum Functionality. And they wrote:

Guideline 4.2.2 - Design - Minimum Functionality We still noticed that your app’s main functionality is to market your service, with limited or no user-facing interactive features or functionality. Apps that are primarily marketing materials or advertisements are not appropriate for the App Store.

Next Steps

We encourage you to review your app concept and work towards creating an app that offers customers an engaging and lasting experience that also meets the App Store’s high expectations for quality and functionality. For example, an app for a restaurant should offer more functionality beyond a standard mobile website that include its phone number, address, and hours. You should instead include functionality like table reservations, mobile ordering, etc. that do not currently exist on the mobile website.

Due the fact that API is not working and I am not willing to lay my hands on any PHP code I am letting this app to die.

I might be willing to fix it once the API and scraper starts working again.

If anyone wants to fix the api, here you go: https://github.com/tomaskadlec/lunch_guy