PDF Reader Core for iOS

In iOS 8, the file system layout of app containers has changed on disk. Because of this change, the main .app bundle and the Documents/Library directories are stored in different places on the disk.

i.e: Application Directory: /private/var/mobile/Containers/Bundle/Application/E49D4518-5F07-425A-B743-03386C4644AF/Reader.app Documents Directory: /var/mobile/Containers/Data/Application/98A0FF1A-F97E-4A6E-B10E-B58E5DCFA72B/Documents

vfrReader creates a relativePath to store when archiving the ReaderDocument (to handle cases where the user may restore from a backup or use iCloud etc). This was fine in previous versions of iOS because it removes the applicationPath from the filePath of the supplied pdf.

However, in iOS 8. If i was loading a document from my main bundle (this can be reproduced in the demo app), the document would try to calculate its relativeURL from the NSDocumentDirectory minus the lastPathComponents.

If you use the two paths from above and try to do that, It is trying to remove /var/mobile/Containers/Data/Application/98A0FF1A-F97E-4A6E-B10E-B58E5DCFA72B/ from /private/var/mobile/Containers/Bundle/Application/E49D4518-5F07-425A-B743-03386C4644AF/Reader.app/Reader.pdf

This obviously doesn't work as the range.length was NSNotFound causing the application to crash.

To fix the issue, I have modified the code to remove the _fileName ivar (so it is no longer archived) and to use a new _filePath ivar instead. Because unarchiveFromFileName:password: supported being able to only pass in the lastPathComponent (i.e Reader.pdf). I have had to depreciate this method and I have replaced it with unarchiveFromFilePath:password:.

The application will still compile fine, but anybody trying to use the old method will have an assertion raised telling them to use the new method. You must pass the absolute filePath into this new method as it will also update the _filePath ivar on the document once it has been unarchived.

Let me know if you have any more questions. Liam

Allows for setting barTintColor and tintColor to change the look of the Reader. Example:

ReaderViewController *readerViewController = [[ReaderViewController alloc] initWithReaderDocument:document];
[readerViewController setBarTintColor:[UIColor colorWithRed:0.1 green:0.3 blue:0.8 alpha:0.9]];
readerViewController.view.tintColor = [UIColor colorWithWhite:1 alpha:1];

This sets both the toolbar and pagebar background color. The buttons and the Done-button text automatically changes color to the tintColor of the ReaderViewController.

iOS 6 still uses the old appearance.

Hi - nice project. I have been using this library within a project I am working on and it has been great. One thing that I felt needed improvement was the pagination. When you reached the end of the preloaded pages (3 by default), you will get a "bounce" and have to wait until the scroll view decelerates until you can continue.

This made it rather difficult to scroll quickly through several pages quickly. I have adjusted the behaviour in this feature branch to fix that annoyance.

I have made several other customisations to the project, I will likely publish them as separate branches and do pull requests when I think they are ready (and if you'd like them), however I feel this patch is beneficial to almost everyone as it improves user experience.

Cheers!

When using reader core as a pod, some settings cannot be changed. Now you can customize the toolbar, background colors and shadows. There is also a thumbnails-only view-mode.

Signed-off-by: Tom Kremer [email protected]

CONTEXT

We're using a highly customised version of vfrReader for one of our projects. In order to do various transforms we need to know the size of a ReaderContentPage, but it is not cleanly exposed in the current implementation

WHAT THIS PR DOES

This PR simply exposes the 2 variables pageWidth and pageHeight as properties, so that outside (and derived) classes can read them.

WHY IS IT NECESSARY? Without this change, derived classes have to re-read the page info from the pdf context.

ALTERNATIVE SOLUTION If you're not keen on exposing this as a property, perhaps it could be made protected using @protected instead?

See https://github.com/vfr/Reader/issues/71

Enable with : LANDSCAPE_DOUBLE_PAGE Enable single first page (for magazines) : LANDSCAPE_SINGLE_FIRST_PAGE

Patched with minimal changes

Hi,

I have added support for controlling the light and dark color you use in the gradients of the three toolbars. Now you can set the theme colors once for your ReaderViewController and then the toolbars will have their colors set accordingly.

Furthermore, I removed some deprecation warnings. It still compiles (without warnings) for iOS 5 but I have not tested iOS 4. I guess you don't really support iOS 4 anyway, right?

Thank you for open sourcing this great PDF viewer!

Best regards, Mads

--Fix for CATiledLayer crash

I was getting crashes due to the catiledlayer's delegate not being nilled on dealloc. This fixed it for me and I haven't seen another crash in a few months. The fix is from the following: http://stackoverflow.com/questions/6012796/ios-catiledlayer-crash

--Resolves an intermittent flickering issue while scrolling

Looks like there was an attempt to fix this in the past by setting the fade duration to a very small number. I would still get the flicker a certain times and setting the fade duration to 0 fixed it.

stringByAddingPercentEscapesUsingEncoding is deprecated as of iOS9.0 replaced with stringByAddingPercentEncodingWithAllowedCharacters.

https://developer.apple.com/documentation/foundation/nsstring/1415058-stringbyaddingpercentescapesusin

This also addresses a bug where external anchor links with a # in the name are incorrectly encoded to %23. i.e. http://site/index.html#anchor is sent to http://site/index.html%23anchor

Reference SO https://meta.stackexchange.com/questions/259368/ios-app-url-percent-encoding-and-decoding-bug

ReaderViewController *readerViewController = [[ReaderViewController alloc] initWithReaderDocument:document];
readerViewController.delegate = self;
readerViewController.scrollDirection = ReaderScrollDirectionVertical;

The last option is new and allow "top to bottom" scrolling.

As part of http://blog.cocoapods.org/Test-Jammin/, I decided to add some basic tests and Travis CI support to this repo.

The tests exercise:

• simple PDF validity (and make sure that the filename doesn't matter)
• page numbers

Here's an example successful Travis CI run too: https://travis-ci.org/mmmulani/Reader/builds/59030158

I know this is not a supported library any longer, but this is a fix I put in this past summer to fix an issue when a person scrolls pages quickly, it resulted in content not loading, presenting the user with a blank page. This should fix this issue for people that have not updated to a newer library.