The fastest zero-tap iOS menu.

[x] There is no issue opened before about this. [x] Issue is reproduceable in demo project.

What did I do?

• Downloaded the demo project.
• Wanted to check how it works with many menu items, so I copy pasted default menus 3 times. (4 times menu items at the end.) Change nothing else.
• Ran on iPhone 6s with iOS 11.2.1

What happened?

• CaroicaGestureManager.swift file, panned(yLocation:, edge:, state:, fromGesture:)method, line 76
• let yRange: ClosedRange<CGFloat> = 20.0...frameHeight - container.menuHeight
• Fatal error occured: Thread 1: Fatal error: Can't form Range with upperBound < lowerBound.
• Reason: With 4x menu items, container.menuHeight became greater than frameHeight I suppose.

Hey there!

In my project I need to have different color theme for menu than the default one. So for better extensibility and reusability those 2 are required.

@arn00s please review once you'll have a chance And btw menu is awesome :) found couple bugs -> will contribute to that later. Thanks.

As of 2.0.1 iconMargins is not working (properly) because here constrains are assumed to be arranged in "CSS order":

private func applyMarginConstraints(margins: (top: CGFloat, right: CGFloat, bottom: CGFloat, left: CGFloat)) {
	iconConstraints[0].constant = margins.top
	iconConstraints[1].constant = margins.right
	iconConstraints[2].constant = margins.bottom
	iconConstraints[3].constant = margins.left
	setNeedsLayout()
}

by in reality they are arranged differently:

func makeAnchorConstraints(to superview: UIView) -> [NSLayoutConstraint] {
	return [self.topAnchor.constraint(equalTo: superview.topAnchor),
		self.rightAnchor.constraint(equalTo: superview.rightAnchor),
		self.leftAnchor.constraint(equalTo: superview.leftAnchor),
		self.bottomAnchor.constraint(equalTo: superview.bottomAnchor)]
}

(note how left and bottom are misplaced)

Furthermore, (because of how iOS resolving constants in constraints depending on anchors order) left and bottom should be negative to achieve desired result.

So, this PR contains fix for those issues and cleanup of some duplicating code (addSubview, create constraints, addConstraints)

What did I do?

• Downloaded the demo project and ran it on iPhone 6s with iOS 11.2.1 without any modification.
• Travelled between content pages many times. (Not to be a prick, just to present the menu to my collegues.)

What happened?

• Memory usage gone beyond 150 MB.

Any ideas?

I traced the memory usage while travelling between pages. I saw 2 things.

• WebView data is not released when you go to another page.
• MapView data is released but not completely when you go to another page.

I don't know if these are issues about the menu, or something else, but false alarm better than no alarm :]

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[test.MainViewController cariocaMenuDidSelect:indexPath:]: unrecognized selector sent to instance 0x7ffa48e00be0'

this happen when ever I click on cell for the menu.

collision is easy to detect when having cariocaMenu?.boomerang = .verticalAndHorizontal

and while in app using menu:

1. Swipe from right to open menu -> menu appears on the .left as expected
2. Then swipe from left to open menu -> menu appears on the .right as expected
3. Then swipe from the right again to open menu -> menu appears on the .right again which is WRONG. Expected behavior: menu should appear on the .left -> same as in step 1.

Collision was happening due to check in hideMenu() which was setting openingEdge property which was already set before in gestureTouched() -> which makes next time when gestureTouched() gets fired again -> the menu view's state is not being updated to correct one cuz openingEdge always equals to .right and newEdge also equals .right in this scenario

1. Make a delegate in CariocaMenu class to be public to make it possible to set a delegate outside of the demo project, i.e. in a user's app utilizing this POD.
2. Make CariocaMenu.showIndicator() method public to make it possible to initialize the initial position and style of the indicator in a user's app utilizing this POD.

The library doesn't handle well when rotating the screen.

Steps to reproduce

• In portrait mode (Unlock rotation)
• Open the menu
• Scroll to About
• Open the menu again
• Rotate to landscape

Expected result

• The Menu Centered in landscape mode

Actual Results

• The Menu is half visible. (If you play it a couple of time, the menu button will disappear)

Hey! I am trying to apply icon instead of emoji but the problem is that the icon is way too big. This is how I add icon:

var menuItems: [CariocaMenuItem] = [
        CariocaMenuItem("Test1", .icon(UIImage(named: "test1Icon")!)),
        CariocaMenuItem("Test2", .icon(UIImage(named: "test2Icon")!))
    ]

This is the output:

My icon is 15x15

Hey, I am trying to dismiss presented ViewController but instead on dismissing, it goes to Carioca's default viewcontrollerViewController. My initial ViewController is UINavigationController but I do not think that is an issue. Is it a bug or I am stupid?

And this is how I present:

let emptyViewController = EmptyViewViewController.fromStoryboard()
present(emptyViewController, animated: true, completion: nil)

Firstly, thank you for an awesome library! Great work! It would be great to have a similar library for android.

Has this library been ported to android or is there a similar looking library for android that you're aware of?

I tried to run the Demo project, but it does not respond to pan gesture in the menu, could you check this? just try to run it :) Very thanks, I may use this library on the app I'm developing, and once then, I'll give you the link ❤️