Whisper is a component that will make the task of display messages and in-app notifications simple. It has three different views inside

• Rename free functions to lowercase first letter. This preserves Whisper namespace, and make ColorList, FontList, Config under namespace. 😈 THIS IS BREAKING CHANGES 👿
• Allow Shout text to be 2 lines
• Update layout to deal with when Shout image is nil or subtitle is empty

Hi!

Thank you for this wonderful library but I am having troubles with the migration to swift 4 from swift 3.

I am using Xcode 9 and Whisper version 5.1.0 that comes with swift 4 support but when trying to run my project I have 16 issues regarding this library. All issues are the same_

Argument of '#selector' refers to instance method 'orientation ... that is not exposed to Objective-C

and

'shared' is unavailable: Use view controller based solutions where appropriate instead

Since I am seeing that this library is working with swift 4 what I am doing wrong?

Thank you!

The latest beta XCode is having issues with the show method. There is a show method on UIViewController that it keeps getting confused with. Not sure why it can't differentiate between the two but it can't.

A better way of defining these methods might be the following:

public func showAnnouncement(_ announcement: Announcement, to: UIViewController, completion: (() -> Void)? = nil)

public func showMurmur(_ murmur: Murmur, action: WhistleAction = .show(1.5))

public func showMessage(_ message: Message, to: UINavigationController, action: WhisperAction = .Show)

Then you can leave the first label off when calling:

showAnnouncement(announcementVar, to: self) showMurmur(murmurVar, .show(2.0)) showMessage(messageVar, to: self.navigationController, .Show(2.0))

Facebook uses a nice in-app banner when the user taps "Post". The user see a progress bar indicating the posting process, while at end, signalling it's done.

Would be great if such one will be added to Whisper.

Hi! I have two TableViewControllers as you can see in the video I've attached here. In the 2nd one I show a permanent Whisper notification (the only thing I've changed is the WhisperView height to 38). When the user press back, on viewWillDisappear() I invoke Silent(navigationController!) and the insets for the first TableViewControllers breaks. It returns top = -38 instead of top = 0.0, as my navigationBar is opaque, not transparent. The second time I do it, as you can see in the video, the insets becomes worst, because this time it returns top = -76, so 38 x 2. And it goes on and on. I have tried to solve this but couldn't exactly found the right line to modified in the pod. Hope you can help me! Thank you very much! Pablo

Hello, Merry X-Mas !

I have a problem when I try to show Whisper at the functions viewDidLoad or viewDidAppear the tableview add strange space at it's top, please take a look in to the attached photo

if I show Whisper by using the button it work perfect.

You could found this bug in my demo project : https://github.com/0x686169/NiceWhisper

Hope you fix this soon as soon.

Thank you very much,

Hi, If I try to call a Murmur my application restart to the Initial View Controller.

var murmur = Murmur(title: "Can you retry please?")
Whistle(murmur) //Restart if this is not commented

Same behavior with iPhone or simulator. Only tested with latest SDK iOS 9.2.0. Any idea?

Well, I guess there's no perfect solution, but what would you think of having the whistles display all the way from the top of the screen on the iPhone X?

In the current implementation Whisper has no intention to use buttons in the whisper. Is it possible to add buttons with different callbacks to manage this?

the setup is like this: when u click button A, it call Whisper.show

If u click multiple time on that buttonA, ur screen will keep pushed up and it getting smaller

You create new UIWindow in WhistleFactory() on 20nd line.

It cause the application crash on didFinishLaunchingWithOptions methods because of followings in my opinion.

http://stackoverflow.com/a/33958144/3022613

2016-05-11 04:32:22.166 Smart Citizen[742:145841] *** Assertion failure in -[UIApplication _runWithMainScene:transitionContext:completion:], /BuildRoot/Library/Caches/com.apple.xbs/Sources/UIKit/UIKit-3512.60.7/UIApplication.m:3401
2016-05-11 04:32:22.168 Smart Citizen[742:145841] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Application windows are expected to have a root view controller at the end of application launch'
*** First throw call stack:
(0x1834f2e38 0x182b57f80 0x1834f2d08 0x183e78124 0x1888e6ad0 0x1888e3674 0x184e937ac 0x184e93618 0x184e939c8 0x1834a9124 0x1834a8bb8 0x1834a68b8 0x1833d0d10 0x1886ab834 0x1886a5f70 0x1000ae594 0x182f6e8b8)
libc++abi.dylib: terminating with uncaught exception of type NSException

Can you provide any solution for this? Why do you need to create new UIWindow?

BTW: Without Whisper pod everything works well, same AppDelegate.swift file.

If you want to investigate problem I can share my project folder.

Is there a reason why the whistleWindow is not removed after displaying? It's causing issues in my code whenever I call UIApplication.shared.windows.first, which returns the whistleWindow and not the expected keyWindow.

I forked the project and made whistleWindow an optional and I set it to nil when the display has finished.

public func hide() {
    let finalOrigin = view.frame.origin.y - titleLabelHeight - Dimensions.notchHeight
    UIView.animate(withDuration: 0.2, animations: {
      self.whistleWindow?.frame.origin.y = finalOrigin
      }, completion: { _ in
        if let window = self.previousKeyWindow {
          window.isHidden = false
          self.whistleWindow = nil // Setting this to nil... Will this cause any problems?
          self.previousKeyWindow = nil
          window.rootViewController?.setNeedsStatusBarAppearanceUpdate()
        }
    })
  }

Will this solution cause any problems?

Hi there,

It's a great library. Thank you for your work.

I am experiencing the following issue:

When I display a Murmur the iOS status bar text is not overlapped by the Murmur text. It's kind of a merged info. I am using Xcode 12.0.1 and iPhone 8 device/simulator. Both iOS 13.7 and 14.0.1 produces the issue.

It's happening in both Light and Dark mode. Please let me know if I am doing something wrong. Thanks!

let murmur = Murmur(title: "Updating...", backgroundColor: .orange, titleColor: .white)
Whisper.show(whistle: murmur, action: .present)

swift5 iOS13之后，有SceneDelegate，导致Whisper `let murmur = Murmur(title: "This is a permanent whistle...", backgroundColor: UIColor.red, titleColor: UIColor.white)

    Whisper.show(whistle: murmur, action: .present)`

失效，无法显示