Thanks for the library. I try to use it in a scroll view with transaction animation when an image is loaded:

CachedAsyncImage(
    url: imageURL,
    urlCache: .imageCache,
    transaction: Transaction(animation: .default)
) { phase in
    switch phase {
    case .empty:
        ProgressView()
            .frame(height: 100)
    case .success(let image):
        image
              .resizable()
    case .failure:
        Image(systemName: "wifi.slash")
    @unknown default:
        EmptyView()
    }
}
.frame(maxHeight: 200)

private extension URLCache {
    static let imageCache = URLCache(
        memoryCapacity: 512 * 1000 * 1000,
        diskCapacity: 10 * 1000 * 1000 * 1000
    )
}

But once an image is loaded it continues to animate cell appearance (and other View content) when scrolling down and up again. URLCache doesn't return anything before the app relaunch.

Great job on this! I was having a huge problem with AsyncImage redownloading images in lazy stacks that this lib completely eliminates.

The one difference I noticed is that transaction animations don't appear to work. I had a nice ease animation with AsyncImage that does not trigger when I swap it with CachedAsyncImage. Here's my body

var body: some View { GeometryReader { geo in AsyncImage( url: url, transaction: Transaction(animation: .easeInOut) ) { phase in switch phase { case .empty: Rectangle() .fill(Color.gray1) case let .success(image): image.resizable() .scaledToFill() case .failure: Rectangle() .fill(Color.gray1) @unknown default: EmptyView() } } .frame(width: geo.size.width, height: geo.size.height) .clipped() } } }

It seems after I switched from AsyncImage to your CachedAsyncImage, 404 is no longer an error. Thus when the code tried to load an URL that returned 404, the code would never reach phase.error, thus a placeholder is always showing.

When provided with an URL that ends up being redirected (301), no cache hit occurs during initialization, as URLCache.cachedResponse expects the redirected URL to be provided instead. This leads to _phase being set to .empty, even though the ensuing .load call will result in a cache hit, because URLSession.data does behave properly.

... that's my theory, at least 😬

I saw, that f24cfe71158f428e9a396a19335221f0fe19e10e did away with animating on cache hit. What was the reason for that change?

There is a print statement here that I don't think should be included because having no URL is a valid state and the print doesn't seem to have any purpose. The current inclusion of the statement spams my console since I use this library to asynchronously load a list of users.

I'd personally like to see it removed or at least have it made toggleable so I don't have to see it.

As of 3/1/22 the master branch has this issue.

Good work, thanks, Lorenzo! Im using library to fetch and cache images like this:

       CachedAsyncImage(
        url: URL(string: path),
        urlCache: .imageCache,
        transaction: Transaction(animation: .easeInOut)) { phase in
            
            switch phase {
            case .empty:
                ProgressView()
                    .progressViewStyle(.circular)
            case .success(let image):
                image
                    .resizable()
                    .aspectRatio(contentMode: .fill)
            case .failure:
                Image("")
            @unknown default:
                Image("")
            }
        }
        .frame(
            width: frameForBaseImage().0,
            height: frameForBaseImage().1
        )
        .cornerRadius(filesGroupingSelection == .yearGrouping ? 4 : 8)

But transaction doesn't work at all(

First off, amazing work! Thanks 🙏

I was debugging an issue I have with images no caching correctly (likely due to size or cookies?) and it got me going through the code.

Could you point me to where the caching occurs? I only see one storeCachedResponse that in my case never gets triggered because there aren't any redirects.

Does the session automatically do it in this line: let (data, _, metrics) = try await session.data(for: request)? I was under the likely incorrect impression we had to explicitly call storeCachedResponse.

I mean, will the image still be cached after I exit and re-enter the app, or is just while the app is "alive"? For example I open the app today, and then I open it again in the next month, will the image be still cached?

Thank you!

Whenever I archive with your SPM it fails. I was doing a little reading into the matter, and it seems that you're missing some things in your Package.swift file that is causing the problem.

platforms: [ .iOS(.v15) ],

I have a LazyVGrid inside a Scrollview.. scrolling from start to finish works great , as I scroll backward the scrollview jumps around.. I think the issue is the scrollview content size for each grid item is changing. If I hard code the frame of the image it no longer hitches. I think I should be able to do that as all my images are the same size.. but I didn't run into this issue when trying other image caching frameworks like SDWebImageSwiftUI for example. Just thought you might want to know if it's something that can be looked at.

ScrollView {

    LazyVGrid(columns: columnLayout) {

        ForEach(settings.wallpaperDataFiltered, id: \.guid) { wallpaper in

            ZStack {
                NavigationLink(destination: WallpaperUI()) {
                   
                    KFImage.url(URL(string: wallpaper.thumbUrl))
                              .fade(duration: 0.25)
                              .resizable()
                              .aspectRatio(contentMode: .fit)
                        
                }
            
            }

        }

    }

}

Hello @lorenzofiamingo, thank you for this great library! However when the image is really big, it seems like loading from cache slows down main UI thread. Could this operation be moved to background thread by any chance? When initially loading from server, navigation happens immediately and shows loading indicator, which looks good. But when it is already in cache, this is how the animation looks like. In any case have a beautiful day! https://user-images.githubusercontent.com/9447630/177713459-6e510665-a336-4b95-a173-f6a76a0445be.mp4