This fixes #15 and thus makes this library usable in App Extensions.

It's simple, but it seems to work pretty well. If have test for a few days now and I didn't notice any adverse effects. Changes to defaults in the main app even render in the widget almost instantly.

Hi there,

there is a strange thing going on with the keyboard / toolbar when switching the theme which is apparently caused by this "hack" in ThemeManager https://github.com/regexident/Gestalt/blob/master/Gestalt/ThemeManager.swift#L259

It causes the toolbar to "detach" from the keyboard and slide in and out from the top of the screen. I assume the keyboard view itself breaks when being removed and added again afterwards.

Do you know if there is a better way to change the appearance or is this still the only possible "solution"?

Thanks in advance :)

It's a bit hard to see on the screenshot but I also included the sample project.

Sample project: BrokenKeyboard.zip

I use gestalt same as you describe in Usage part. I don't use storyboard or xib (entire project is in code). I have custom views in my controller and every view has it's own theme also controller. When i push or present controller for first time everything is fine, but if i pop or dissmiss and push again i get "Detected redundant observation" from some view or controller. I looked up in your demo project and in appdelegate there is var disposables: [Disposable]?. I haven't implement that stuff. I check for retain cycle all views and controller deinitialized properly. Any help for Detected redundant observation??

I'd like to use your library in a dynamic library which is shared between the main app and a today widget (which is also themeable). The problem is that your code won't compile when used in a target with extension safe API, because UIApplication.shared.windows is not available in app extensions and you are using it here:

https://github.com/regexident/Gestalt/blob/7e9093b1c821ec6e1edda17674ea34ec4faeef4d/Gestalt/ThemeManager.swift#L226-L235

Could you explain to me what this part of the code is doing? As I understand it from the comment this covers some kind of edge case? Is this strictly necessary?

I could provide code (and a PR) that will execute the above snippet only in environments where it is allowed and ignore it in environments where extension safe API is required. Thus, it would make your library usable in targets where only extension safe API is allowed. In my case this would mean using the same dynamic library would only execute the above snippet in my main app and not in the extension. Would this break anything?

Hi, thanks for this great library!

Cocoapods currently point to earlier version (1.1.0) can you please update it to point to the latest one (2.0) ?

https://cocoapods.org/pods/Gestalt

Thanks!

I'm probably misunderstood something but how do I apply the styling initially?

As soon as a view registers the observer in its viewDidLoad method the theme switching obviously works, but how should the theme be applied initially?

I first thought to simply call apply initially the same way as observe but that results in an error:

self.apply(theme: \MyTheme.view)
self.observe(theme: \MyTheme.view)

And storing the current theme somewhere and applying it from there seems wrong, like im missing the intended implementation:

self.apply(theme: Somewhere.currenTheme.view)

Kind regards Mario

Hi Vincent,

I've been using Gestalt in an app and recently noticed that it was licensed MPL. I wasn't sure what that means with respect to shipping to the App Store and my source code. My app is for commercial purposes, and I plan to keep it closed source, but I'm still a bit confused as to what I need to do to be MPL compliant.

I was hoping you could clarify what needs to be done with my app (open source, display the copyright notice prominently, not be able to ship it at all, etc) to know whether I can use Gestalt.

Thanks a lot!

This PR adds a new property to the ThemeManager that allows to set a list of window class names, which are then checked during the appearance hack.

This change fixes a problem where the appearance hack would change the views of the UITextEffectsWindow, which then leads to side-effects when a keyboard is shown.

These changes here are purely additive to not break any existing integrations.

The property will be set through the ThemeManager like follows

ThemeManager.default.allowedWindowClasses = [UIWindow.classForCoder()]

Closes #25

In my app I change the currently selected theme, and save it to disk like so:

ThemeManager.default.theme = OfflineService.AppThemer.currentlySelectedColorScheme
// OfflineService.AppThemer.currentlySelectedColorScheme is a `ColorScheme` that conforms to `Theme`

The themes are dynamically downloaded from CloudKit, stored in the OfflineService, and then accessed when the user manually changes their theme.

Before when I used to be able to setup my app like this, and it would propagate whenever a change occurred:

ThemeManager.default.apply(theme: ColorScheme.self, to: self, animated: true) { viewController, colorScheme in
    self.view.backgroundColor = colorScheme.backgroundColor
}

Now I'm using the new API in version 2.0 like so, and changes aren't propagating when a theme change occurs:

func apply(theme: ColorScheme) {
    self.view.backgroundColor = theme.backgroundColor
}

I understand there needs to be some registration, such as self.observe(theme: \ApplicationTheme.custom.stageDesign) in the sample project, but since my themes don't get stored in source code, they're generated by downloading the themes, I'm not sure how to properly call self.observe.

I tried a few ideas, including self.observe(theme: \OfflineService.appThemer.currentlySelectedColorScheme), but none of them seemed to work.

I can't seem to figure out if there's a way to observe the theme changes for something that doesn't exist in the source, and was wondering if you had any ideas.

Thanks a lot!

First of all, thanks for creating this awesome library! I adopted it quickly in my app. The current version however has an invalid CFBundleShortVersionString of 2.0.0-b2

Alpha-numeric appendix is not allowed.

Please update the info.plist so that the library can be directly used with Cocoapods/Carthage

Apple states:

Invalid or Non-Increasing CFBundleShortVersionString - The value specified in the bundle's Info.plist file for the key CFBundleShortVersionString must be a string consisting of at most three dot-separated components, where each component is composed only of the digits 0 through 9. For example, any of the following are syntactically valid values for CFBundleShortVersionString: "1.0", "4.2.1", "3.46", "1.112.0"; whereas the following are all syntactically invalid: "1.4.0.0.0.0.5", "GX5", "3.4.2b6", "2.6GM", "1.0 (Gold)", "-3.6". Additionally, each updated version of the same application must have a CFBundleShortVersionString that increases relative to that of the previous version that was actually made available for sale on the iTunes Store. For example, if a previously-available version had a CFBundleShortVersionString of "1.4", then any of the following would be acceptable as the next update: "1.4.1", "1.4.332", "1.5"; but all of the following (though syntactically valid) would be unacceptable: "1.4", "1.3", "1.3.9", "0.9". For more information about the CFBundleShortVersionString key and the Info.plist file, see Apple's Runtime Configuration Guidelines.

Add support for Swift Package Manager. Builds and exports the "Gestalt" SPM library.

To actually use it, you need a UI/AppKit enabled SPM, like SwiftXcode.

Using Gestalt 1.x, there are hundreds of files in my project have lines like this:

ThemeManager.default.apply(theme: Theme.self, to: self) { themeable, theme in
    ...
}

But in 2.0.0, ThemeManager.default.apply(...) is gone, is there an easy way to not change every file in my project to migrate to 2.0.0? (eg. write an extension to ThemeManager to get this method back)

Hi there,

I was wondering if it'd be possible to add a changelog so it's more easily visible what's changed between versions. I generally read between the commits, but it's hard to tell exactly what's changing between version 1.2.0 and 2.0.

Thanks!