I have a simple question, sorry for being a ios newbie.

How do I change the title and sub title wording as I am displaying the placeholders?

I found out that the wordings are in PlaceholderData.swift, in public struct PlaceholderData.

Lets say I do not wish to hard code them here, but set it to something when I am calling tableView.showNoConnectionPlaceholder(), how do I do it?

I also found the file PlaceholdersProvider.swift, which I set it to be :

var noConnectionData: PlaceholderData = .noConnection
        noConnectionData.image = #imageLiteral(resourceName: "hg_default-error")
        noConnectionData.title = "Testing no connection title"
        noConnectionData.subtitle = "Testing no connection sub title"
        let noConnection = Placeholder(data: noConnectionData, style: commonStyle, key: .noConnectionKey)

But the message is still the same

How do I do it?

Thanks

Hi @HamzaGhazouani,

Good job on this awesome library! I love it!

I have noticed that a crash occurs on iOS 9.x (tested on iOS 9.3.5) if you use HGPlaceholders for a UICollectionView that has a header and/or footer. You can reproduce this issue by simply running your latest Example project (that you have pushed ~2 hours ago).

The issue is related to not updating the defaultLayout with the proper layout after the dataSource changes.

Could you please take a look?

Also, I think it is also wise to declare the PlaceholderCollectionViewCell as open, since this is already the case for PlaceholderTableViewCell. I think most devs would like to subclass it eventually.

Looking forward to your feedback. Keep up the good work!

Cheers, Sasho

Hi,

I played around the example project and found that the placeholder has a button "try again", and user can tap that.

However in my project, there is no action button, but I can tap on the white space below the subtitle and the log is printing "Placeholder action button tapped"

How and where do I set the action button to visible?

Thanks

Hi, I tried using your library, it's looking very nice, but has a little problem when changing the device orientation while the navigationItem.searchController.isActive = true. This is the error I'm getting in the console:

*** Assertion failure in -[HGPlaceholders.TableView _classicHeightForRowAtIndexPath:], /BuildRoot/Library/Caches/com.apple.xbs/Sources/UIKitCore/UIKit-3698.84.16/UITableView.m:15329
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid row height provided by table delegate. Value must be at least 0.0, or UITableViewAutomaticDimension.'

After some debugging I'v noticed that the hight from the delegate is -119: So I tried the most obvious thing, I'v added tableViewHeight = tableViewHeight >= 0.0 ? tableViewHeight : UITableView.automaticDimension before the method return (line 154), but guess what? Somehow the value is still -119 😓 So I thought maybe the UITableView.automaticDimension is also returning -119? so let's try just tableViewHeight = 0. No, it didn't worked, tableViewHeight was still -119. 😧

Hope you'll be able to reproduce and detect how to solve this problem. I didn't understand yet how is that possible to change the value by this way (tableViewHeight = 0) and it won't change, like this line doesn't exists. 😨

Thanks, Ido.

Hi @HamzaGhazouani,

I was thinking whether it would be nice to have the option to choose whether the placeholders should disable the scrolling functionalities of UITableViews and UICollectionViews.

One good example why I think that sometimes we need to have that one enabled is let's say you want to check for new data by triggering a pull to refresh action. Currently, if an empty state is visible, there is no way you can trigger this action, since the scrolling is disabled.

What are your thoughts on this?

Best regards, Sasho

Hey I'm writing the follow code on my tableView

` import UIKit import HGPlaceholders

class SentMemesTVC: UITableViewController{

var placeholderTableView: TableView?

var memes = [Meme]()

override func viewDidLoad() {
    super.viewDidLoad()
    self.clearsSelectionOnViewWillAppear = false
    
    reloadTable()
  
    NotificationCenter.default.addObserver(self, selector: #selector(reloadTable), name: NSNotification.Name(rawValue: NOTIF_RELOAD_TABLE), object: nil)
    
    
    
    placeholderTableView = tableView as? TableView
    placeholderTableView?.placeholderDelegate = self as PlaceholderDelegate
    
    
    placeholderTableView?.placeholdersProvider = .basic
    placeholderTableView?.showErrorPlaceholder()
}

override func prepare(for segue: UIStoryboardSegue, sender: Any?) {
    if segue.identifier == TO_MEME_EDITOR{
        if let memeEditor = segue.destination as? MemeMainVC{
            if let meme = sender as? Meme{
                memeEditor.meme = meme
            }
        }
    }
}

override func numberOfSections(in tableView: UITableView) -> Int {
    return 1
}

override func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
    return memes.count
}

override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
    if let cell = tableView.dequeueReusableCell(withIdentifier: "MemeTableCell", for: indexPath) as? MemeTableCell{
        let memeCell = memes[indexPath.row]
        cell.configureCell(meme: memeCell)
        return cell
    }
    return UITableViewCell()
}

override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
    let meme: Meme = memes[indexPath.row]
    performSegue(withIdentifier: TO_MEME_EDITOR, sender: meme)
}

override func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
    return 114
}

@objc func reloadTable(){
    let appDelegate = UIApplication.shared.delegate as! AppDelegate
    memes = appDelegate.memes
    self.tableView.reloadData()
}

@IBAction func toMemeEditor(_ sender: Any){
    performSegue(withIdentifier: TO_MEME_EDITOR, sender: nil)
}

}

extension SentMemesTVC: PlaceholderDelegate {

func view(_ view: Any, actionButtonTappedFor placeholder: Placeholder) {
    print(placeholder.key.value)
    placeholderTableView?.showDefault()
}

}

`

but nothing is happening

Hey @HamzaGhazouani,

I have discovered that if you try to archive the project for distribution (AdHoc), and at the same time you have added and are using this library as a Pod, the archiving fails with an error:

Symbol(s) not found for architecture arm64

I have also verified that this is not a case when the library is added to the project manually.

Please take a look and if you need some additional info, please let me know.

Cheers, Sasho

'The type Method is declared in two imported modules. You have to specify the module from which to use the type. Use Alamofire.Method instead of Method' in one stackoverflow answer. I cannot related struct Placeholder with HGPlaceholders. I also use Kingfisher library which has Placeholder struct in it.

Loved your library, keep going!

The cast for me does not work: The error appears here:

placeholderTableView = notificationTableView as! TableView

I am not using a UITableViewController, but just a UITableview in a UIViewController.

I follow the demo project and create the placeholderTableView as my UITableView (notificationTableView) as TableView. Force Cast creates the following issue: Could not cast value of type 'UITableView' to 'HGPlaceholders.TableView'

Optional cast with ? does not do anything.

The rule of content inset of scroll view has been changed since iOS 11 To take content inset into account, we probably need to use adjustedContentInset instead of contentInset.

Hey @HamzaGhazouani,

I have also discovered that if you have let's say a footer added to the UITableView (one common example is adding a blank UIView inside viewDidLoad (e.g. tableView.tableFooterView = UIView() to the table view's footer view in order to remove the separators if there are only 1 or 2 rows in the table view) which has been added programmatically in viewDidLoad for example, for some reason, the footer view is removed and set to nil.

This is not the case if you have added it via Storyboard.

Could you please take a look?

Cheers, Sasho

https://github.com/marcosgriselli/Sizes/issues/25 I have the same issue but with this pod. Here is an example how did they fix that: https://github.com/marcosgriselli/Sizes/pull/31/commits/ab7105a6a6b98ccfd8e11ec5f561d4f658fdab95

Hi @HamzaGhazouani

Thanks for the great library. I had one question that how do I set the dynamic title and subtitle which is received from server api? Please help me with this.

When i use your library on UICollection view with custom layout, after removing all items, i got crash here: override func layoutAttributesForItem(at indexPath: IndexPath) -> UICollectionViewLayoutAttributes? { return cache[indexPath.item] } But, on method prepare, i always clean my cache.

Helps only invalidation collection view layout after reloadData()