otherwise, the carthage build command for tvOS (/usr/bin/xcrun xcodebuild -project Example.xcodeproj -scheme StatefulViewController-tvOS -configuration Release -sdk appletvos ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build) fails

UIActivityIndicatorView as loadingView Always on top left even when it's set with a larger frame, it is always small in the corner. Is there a work around this? As the insets method applies for all the state views.

carthage version: 0.16.2 xcodebuild -version: Xcode 8.0 Build version 8A218a

following problem does occur when i used carthage update

xcodebulid Output

A shell task (/usr/bin/xcrun xcodebuild -project /Users/donnieyi/Workspace/CampusAssistant/CampusAssistant-iOS/Carthage/Checkouts/StatefulViewController/Example.xcodeproj -scheme StatefulViewController-iOS -configuration Release -sdk iphoneos ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build) failed with exit code 65:

Someone had this problem?

This works by creating a new ViewStateMachine subclass that manages a container view. The views for each state are added to this container view and this container view is added to the UITableViewController.view. When the state is set to .Content, the container view is removed from its superview, but retained by the state machine.

No public APIs have been broken by this PR and the fix works automatically without any new code having to be implemented by the end user. Documentation for all new public classes, and properties has been provided. The demo project has been updated to use a UITableViewController to demonstrate this. It works exactly as expected in all scenarios.

This PR closes #19.

Please let me know if you have any questions about my implementation.

Hi Awesome project, but we have an issue when the view of the UIViewController is an UITableview (example below)

class VC: UIViewController {
    override func loadView() {
        view = UITableView()
    }
}

so it adds the loadingView/emptyView inside of the tableView

This PR Adds a tvOS framework target. The new consists of the exact same source files and even shares the Info.plist with the iOS target. I also added a new shared scheme so the tvOS target can be built using Carthage.

Finally, I added a platform badge to the README.md to mark tvOS and iOS as supported platforms.

Note: tvOS CocoaPods support is already handled in #16.

If already on the main thread, the call to DispatchQueue.main.sync in transitionToState(...) will delay a loading view presentation briefly so that the main view is shown before valid data is present.

This could be resolved with something like the following logic:

if Thread.isMainThread {
      ...
} else {
   DispatchQueue.main.sync() {
      ...
   }
}

Hi, thanks for this helpful library! I'm currently struggeling to add a custom state. I tried to add the additional state to the state machine as described in the readme. Unfortunately, the app crashes when it tries to create the StatefulViewControllerState with my custom viewKey in the getter of currentState and lastState, because the initialization of the state is forced to not be nil: StatefulViewControllerState(rawValue: viewKey)! and my custom viewKey is not part of the default state enum. How can this be solved?

Thanks for this really great library!

I have a problem:

I can not put a different frame for LoadingView, for example:

loadingView = UIView (frame: CGRectMake (0, 0, 100, 100))

this does not work, the loadingView always frame the superview, never changes, can help me?

The loadInitialData method is called multiple times (viewDidLoad, UIApplicationDidBecomeActive) and is always doing the Network request. After calling startLoading() the currentState var will not be updated. The printed loadingState is always content.

    func loadInitialData()
    {
        println(currentState.rawValue)
        if (currentState == .Loading) {
            return
        }
        startLoading()
        println("loadingState: \(currentState.rawValue)")
        FoyerApi.shared.getStories(refresh:true, lastStoryId: nil) { (stories:[Story]?, error:NSError?) in
            self.endLoading(error: error)
            if let _stories = stories {
                self.insertStories(_stories, refresh: true)
            }
        }
    }

As Ray Wenderlich discusses here, when adding protocol conformance to a model, prefer adding a separate extension for the protocol methods..

So this:

class MyViewController: UIViewController, StatefulViewController {
    // ...
}

should be like this:

extension MyViewController: StatefulViewController {

func loadDeliciousWines() {
    startLoading()

    let url = NSURL(string: "http://example.com/api")
    let session = NSURLSession.sharedSession()
    session.dataTaskWithURL(url) { (let data, let response, let error) in
        endLoading(error: error)
    }.resume()
                                          }
}

UIView that conforms StatefulViewController protocol does not be destroyed.

Here is a StatefulViewControllerDemo.zip to illustrate this issue.

PS: the core code

class StateView: UIView, StatefulViewController {

    public var defaultLoadingView: UIView? {
        let defaultView = UIView()
        defaultView.backgroundColor = UIColor.white

        let label = UILabel()
        label.textColor = UIColor.blue
        label.text = "loading..."
        defaultView.addSubview(label)
        label.snp.makeConstraints { (maker) in
            maker.height.equalTo(20)
            maker.centerX.equalToSuperview()
            maker.top.equalToSuperview().offset(160)
        }
        return defaultView
    }

    public var defaultEmptyView: UIView? {
        let defaultView = UIView()
        defaultView.backgroundColor = UIColor.white

        let label = UILabel()
        label.textColor = UIColor.blue
        label.text = "no content"
        defaultView.addSubview(label)
        label.snp.makeConstraints { (maker) in
            maker.height.equalTo(20)
            maker.centerX.equalToSuperview()
            maker.top.equalToSuperview().offset(160)
        }
        return defaultView
    }


    override init(frame: CGRect) {
        super.init(frame: frame)

        loadingView = defaultLoadingView
        emptyView = defaultEmptyView
        setupInitialViewState()
    }

    required init?(coder aDecoder: NSCoder) {
        fatalError("init(coder:) has not been implemented")
    }

    // FIXME: StateView cannot be destroyed
    deinit {
        print("StateView deinit ...")
    }

    func hasContent() -> Bool {
        return false
    }

}

error: SWIFT_VERSION '3.0' is unsupported, supported versions are: 4.0, 4.2, 5.0. (in target 'StatefulViewController-iOS') any plan to update to swift 4.x or 5.x?