So at least on an iphone, when the web view controller is introduced without a navigation controller (for instance, if it's presented modally) you create a new nav bar and nav item, and then release the nav item ... but then in setupToolbar, you access navItem again, after it's been released.

Added Checks for a modal presented Controller. If the WebView has been pushed, the 'Done' button will not be presented and the back button will be respected.

If you present the non-modal (didn't try the modal) VC like so:

SVWebViewController *vc = [[[SVWebViewController alloc] initWithAddress:@"http://www.someslowsite.com"] autorelease]; [self.navigationController pushViewController:vc animated:YES];

Then quickly hit the Back button while the site is loading, you can often get a bad access fault thrown. This was tracked down to not clearing the delegate (mainWebView.delegate = nil;) before the VC gets autoreleased.

Not sure where the best place to implement this fix would be but I put it in viewWillDisappear: and re-registered the delegate in viewWillAppear: because there's no existing dealloc method.

Hi Sam, I have added better support for page loading within a html5 site, such as on youtube. The pageFinishedLoading delegate would not be called after a page has loaded, so I attached an observer to the WebProgressEstimateChangedNotification to call the delegate.

I've also made many changes to the SVModalWebView class to add a navbar and have it's settings controlled by a separate SVWebSettings object.

I was hoping you would like to merge some of these changes when you get the time.

Cheers! Ben.

Hello there,

I was wondering if you noticed that this library is not working properly in iOS 9. When webview is loaded, it only shows the blank screen in the device or simulator. It was working fine up to iOS 8.4.

We use SVWebViewController to access pages from our website that require authentication. In order to ensure the user is authenticated, we have to first make an API call before the page is loaded in the WebView.

We tried making the API call before loading SVWebViewController, but it adds perceived latency, so instead we decided to handle the authenticating API call at the point where the view is actually loaded.

This PR just defines -loadURL: which -loadView delegates to to do the actual loading. The default implementation remains unchanged, but it's possible to do some asynchronous work here in a subclass.

By setting the new boolean useActivityViewController to YES, SVWebViewController will now present a UIActivityViewController instead of a UIActionSheet. SVWebViewController also now has an applicationActivities property where the programmer can pass in an array of custom UIActivities to display alongside the included ones.

For this implementation, I have included git submodules TUSafariActivity and ARChromeActivity for SVWebViewControllerAvailableActionsOpenInSafari and SVWebViewControllerAvailableActionsOpenInChrome because UIActivityViewController does not come with these activities. However, this means any person who clones your repo has to now do the extra step of updating the modules, so if you were aiming to be the easiest WebViewController to add to a product you may want to remove references to these.

when presented as modal view controller on iPhone the navbar disappears when you scroll down. Also, there's no bouncing when trying to scroll over the top.

Can be deactivated via webViewController.obtrusiveNavBar = YES;

Using the modal web view controller in an iPad page sheet, clicking the share button gives:

Terminating app due to uncaught exception 'NSGenericException', reason: 'UIPopoverPresentationController (<_UIAlertControllerActionSheetRegularPresentationController: 0x7fb38c8e7fe0>) should have a non-nil sourceView or barButtonItem set before the presentation occurs.'

I’ve recently added SVWebViewController to the CocoaPods package manager repo.

CocoaPods is a tool for managing dependencies for OSX and iOS Xcode projects and provides a central repository for iOS/OSX libraries. This makes adding libraries to a project and updating them extremely easy and it will help users to resolve dependencies of the libraries they use.

However, SVWebViewController doesn't have version tags. I’ve added the current HEAD as version 0.0.1, but a version tag will make dependency resolution much easier.

Semantic version tags (instead of plain commit hashes/revisions) allow for resolution of cross-dependencies.

I have leaks in sample app when controller appear/disappear many times. GeneralBlock-... http://www.flickr.com/photos/62807440@N04/5760975321/in/photostream

Dears, I faced a silly bug when I load this url inside uiwebview , the url load the request successfully at the first then the uiwebview covered with white view except the title of page . Although I tried to load the same page from Safari and chrome and it loaded successfully without any problems. Url is https://www.filgoal.com/home/views?name=comments&type=article&id=287239

Thank you in advance Nada Gamal

I'm using the modal to load a site. This site has a few steps at a few different URLs. Once the user reaches a specific URL, I plan on closing the modal.

How can I achieve this?